Class Android notifications as a Message to improve delivery speed #14653

Julesssss · 2023-01-30T15:29:17Z

Background

Android notifications are still being throttled and delivered in bursts, despite us recently using the maximum priority, and introducing notification categories.

Solution

This PR simply categorizes notifications as Messages, in an attempt to increase delivery prioritization by the OS.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/258825

Tests

Confirm notifications are received

Create and install a release build to an Android emulator or (preferably) physical device (S.O.)
Sign in on the android device
On a separate client, send a message to the Android device
It should appear as a notification

Offline tests

QA Steps

N/A - changes to the app delivery window are vague and not testable. The existing notification regression tests will cover the regular cases.

For internal QA, @Julesssss will attempt to confirm this improvement.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android is the only modified platform.

melvin-bot · 2023-01-31T12:04:43Z

@eVoloshchak @jasperhuangg One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…isation

Julesssss · 2023-01-31T12:18:31Z

@eVoloshchak here's a screenshot of the internal Stack Overflow post:

jasperhuangg · 2023-01-31T17:37:38Z

I've got a physical android device that I can test this out with!

Julesssss · 2023-01-31T17:50:11Z

I've got a physical android device that I can test this out with!

Nice, let me know if you have any issues and I can help out.

jasperhuangg · 2023-01-31T18:23:23Z

@Julesssss does the Android build onto a physical device normally take like >5 minutes for you?

eVoloshchak · 2023-01-31T19:46:58Z

@jasperhuangg, the build took almost 8 minutes for me, I think it shouldn't take this long (it didn't in the past). I'm wondering if network could affect this

eVoloshchak · 2023-01-31T19:47:05Z

If you long press on a notification and then press Settings it correctly flashes the Message notifications category, so can confirm the category was applied

eVoloshchak · 2023-01-31T19:47:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android

Screen_Recording_20230131-212950_Settings.mp4

jasperhuangg · 2023-01-31T19:47:32Z

It took a few seconds but it showed up as expected!

jasperhuangg · 2023-01-31T19:49:18Z

Can also confirm that it's a message notification:

jasperhuangg · 2023-01-31T19:50:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android

melvin-bot · 2023-01-31T19:52:56Z

🎯 @eVoloshchak, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #14710.

Julesssss · 2023-02-01T16:33:46Z

@Julesssss does the Android build onto a physical device normally take like >5 minutes for you?

Yeah, usually 8 and it's incredibly annoying as native builds take about 20 seconds 😭

OSBotify · 2023-02-01T16:39:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-02-02T00:44:42Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.2.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-04T00:17:53Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-02-04T01:55:54Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-04T02:02:01Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

intoduce Android notification categorisation

5d4af70

Julesssss self-assigned this Jan 30, 2023

Julesssss added the InternalQA This pull request required internal QA label Jan 30, 2023

Julesssss marked this pull request as ready for review January 31, 2023 12:03

Julesssss requested a review from a team as a code owner January 31, 2023 12:03

melvin-bot bot requested review from eVoloshchak and jasperhuangg and removed request for a team January 31, 2023 12:04

Merge branch 'main' into jules-improveNotificationDeliveryWithCategor…

071e53e

…isation

jasperhuangg approved these changes Jan 31, 2023

View reviewed changes

eVoloshchak approved these changes Jan 31, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Jan 31, 2023

[Hold for payment 2/10] Payment issue for E/App PR#14653 #14710

Closed

Julesssss merged commit 817cd8a into main Feb 1, 2023

Julesssss deleted the jules-improveNotificationDeliveryWithCategorisation branch February 1, 2023 16:33

thienlnam mentioned this pull request Feb 2, 2023

Deploy Checklist: New Expensify 2023-02-02 #14771

Closed

30 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Class Android notifications as a Message to improve delivery speed #14653

Class Android notifications as a Message to improve delivery speed #14653

Julesssss commented Jan 30, 2023 •

edited

Loading

melvin-bot bot commented Jan 31, 2023

Julesssss commented Jan 31, 2023

jasperhuangg commented Jan 31, 2023

Julesssss commented Jan 31, 2023 •

edited

Loading

jasperhuangg commented Jan 31, 2023 •

edited

Loading

eVoloshchak commented Jan 31, 2023

eVoloshchak commented Jan 31, 2023

eVoloshchak commented Jan 31, 2023 •

edited

Loading

jasperhuangg commented Jan 31, 2023

jasperhuangg commented Jan 31, 2023

jasperhuangg commented Jan 31, 2023 •

edited

Loading

melvin-bot bot commented Jan 31, 2023

Julesssss commented Feb 1, 2023

OSBotify commented Feb 1, 2023

OSBotify commented Feb 2, 2023

OSBotify commented Feb 4, 2023

OSBotify commented Feb 4, 2023

OSBotify commented Feb 4, 2023

Class Android notifications as a Message to improve delivery speed #14653

Class Android notifications as a Message to improve delivery speed #14653

Conversation

Julesssss commented Jan 30, 2023 • edited Loading

Background

Solution

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 31, 2023

Julesssss commented Jan 31, 2023

jasperhuangg commented Jan 31, 2023

Julesssss commented Jan 31, 2023 • edited Loading

jasperhuangg commented Jan 31, 2023 • edited Loading

eVoloshchak commented Jan 31, 2023

eVoloshchak commented Jan 31, 2023

eVoloshchak commented Jan 31, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jasperhuangg commented Jan 31, 2023

jasperhuangg commented Jan 31, 2023

jasperhuangg commented Jan 31, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Jan 31, 2023

Julesssss commented Feb 1, 2023

OSBotify commented Feb 1, 2023

OSBotify commented Feb 2, 2023

OSBotify commented Feb 4, 2023

OSBotify commented Feb 4, 2023

OSBotify commented Feb 4, 2023

Julesssss commented Jan 30, 2023 •

edited

Loading

Julesssss commented Jan 31, 2023 •

edited

Loading

jasperhuangg commented Jan 31, 2023 •

edited

Loading

eVoloshchak commented Jan 31, 2023 •

edited

Loading

jasperhuangg commented Jan 31, 2023 •

edited

Loading