Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Use slack v3 to try and fix failed slack announcements #14770

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

roryabraham
Copy link
Contributor

Details

Slack announcement composite action is failing. This will be our second attempt to fix it.

Fixed Issues

$ n/a

Tests

None.

Offline tests

None.

QA Steps

None.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
    • I wrote clear testing steps that cover the changes made in this PR
      • I added steps for local testing in the Tests section
      • I added steps for the expected offline behavior in the Offline steps section
      • I added steps for Staging and/or Production testing in the QA steps section
      • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
      • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
      • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
    • I included screenshots or videos for tests on all platforms
    • I ran the tests on all platforms & verified they passed on:
      - [x] Android / native
      • Android / Chrome
      • iOS / native
      • iOS / Safari
      • MacOS / Chrome / Safari
      • MacOS / Desktop
        - [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
    • I followed proper code patterns (see Reviewing the code)
      • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
      • I verified that comments were added to code that is not self explanatory
      • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
      • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
        • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
      • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
      • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
      • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
      • I verified the JSDocs style guidelines (in STYLE.md) were followed
    • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
    • I followed the guidelines as stated in the Review Guidelines
    • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
    • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
    • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
    • I verified that if a function's arguments changed that all usages have also been updated correctly
    • If a new component is created I verified that:
      - [x] A similar component doesn't exist in the codebase
      • All props are defined accurately and each prop has a /** comment above it */
      • The file is named correctly
      • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
      • The only data being stored in the state is data necessary for rendering and nothing else
      • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
      • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
      • All JSX used for rendering exists in the render method
      • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
        - [x] If any new file was added I verified that:
        - [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
        - [x] If a new CSS style is added I verified that:
        - [x] A similar style doesn't already exist
      • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
        - [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
    • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
    • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
    • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

None.

@roryabraham roryabraham self-assigned this Feb 2, 2023
@roryabraham roryabraham requested a review from a team as a code owner February 2, 2023 20:12
@melvin-bot melvin-bot bot requested review from joelbettner and removed request for a team February 2, 2023 20:12
@melvin-bot
Copy link

melvin-bot bot commented Feb 2, 2023

@joelbettner Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luacmartins
Copy link
Contributor

luacmartins commented Feb 2, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A just affects GH actions

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@luacmartins luacmartins merged commit e6ece3e into main Feb 2, 2023
@luacmartins luacmartins deleted the Rory-FixSlackAnnouncement branch February 2, 2023 20:22
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Duration
App start TTI 684.209 ms → 701.666 ms (+17.456 ms, +2.6%)
App start runJsBundle 184.467 ms → 191.469 ms (+7.002 ms, +3.8%)
App start nativeLaunch 19.724 ms → 20.938 ms (+1.213 ms, +6.2%)
App start regularAppStart 0.014 ms → 0.017 ms (+0.003 ms, +19.5%) 🟡
Open Search Page TTI 644.756 ms → 623.093 ms (-21.663 ms, -3.4%)
Show details
Name Duration
App start TTI Baseline
Mean: 684.209 ms
Stdev: 32.914 ms (4.8%)
Runs: 633.1461620000191 642.7539229998365 643.5488829999231 645.6887659998611 648.2813969999552 652.5696680000983 654.4241100000218 656.3163120001554 659.1411950001493 659.3980600000359 662.0772319999523 662.6241540000774 665.5065319999121 668.5193480001763 673.2368319998495 677.9303430002183 679.1198029997759 691.5900510000065 695.5870710001327 698.3186130002141 698.6694979998283 699.378142000176 700.453422000166 703.3322299998254 708.3428469998762 708.9203269998543 714.373676000163 716.841926000081 719.2103579998948 735.6420760001056 747.1516220001504 772.6026280000806

Current
Mean: 701.666 ms
Stdev: 30.592 ms (4.4%)
Runs: 642.2717769998126 656.8495609997772 659.8105609999038 662.2502299998887 662.4181440002285 664.9035950000398 670.8974819998257 671.8905910002068 672.2795589999296 678.8844269998372 679.7837809999473 686.7105959998444 692.4145979997702 699.3095820001327 701.6130570000969 701.8588560000062 706.4031119998544 709.822769000195 715.3713130000979 716.5095669999719 717.0260709999129 718.5798860001378 720.5440239999443 721.2298229997978 725.6607260000892 735.6926210001111 736.5946490000933 742.285523999948 742.7888319999911 744.1145529998466 746.5421939999796 749.9912740001455
App start runJsBundle Baseline
Mean: 184.467 ms
Stdev: 15.370 ms (8.3%)
Runs: 158 163 165 169 171 171 173 173 173 174 175 177 177 182 184 185 185 188 190 190 191 191 193 193 196 196 199 206 220 226

Current
Mean: 191.469 ms
Stdev: 23.561 ms (12.3%)
Runs: 162 162 165 165 166 167 171 171 173 174 175 176 177 179 180 182 184 188 189 189 203 203 208 215 216 217 217 226 228 230 233 236
App start nativeLaunch Baseline
Mean: 19.724 ms
Stdev: 1.573 ms (8.0%)
Runs: 17 18 18 18 18 18 18 18 19 19 19 19 19 19 20 20 20 20 20 21 21 21 21 21 21 21 22 22 24

Current
Mean: 20.938 ms
Stdev: 2.221 ms (10.6%)
Runs: 18 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 21 21 21 22 22 22 22 23 23 23 24 25 26 27
App start regularAppStart Baseline
Mean: 0.014 ms
Stdev: 0.001 ms (5.6%)
Runs: 0.012369000352919102 0.012735999654978514 0.012980000115931034 0.013019999954849482 0.0131029998883605 0.013306000269949436 0.013346000108867884 0.0134680001065135 0.013549000024795532 0.013590000104159117 0.013671999797224998 0.013712000101804733 0.013793999794870615 0.013875000178813934 0.013875999953597784 0.013996999710798264 0.014037999790161848 0.014119000174105167 0.014200999867171049 0.014201000332832336 0.0143630001693964 0.014405000023543835 0.014444999862462282 0.014444999862462282 0.014485999941825867 0.014649000018835068 0.014812000095844269 0.01509599993005395 0.015463000163435936 0.015502000227570534 0.015544000081717968

Current
Mean: 0.017 ms
Stdev: 0.001 ms (4.9%)
Runs: 0.015420999843627214 0.015583999920636415 0.015583999920636415 0.015746999997645617 0.015829000156372786 0.01590999960899353 0.015951000154018402 0.016112999990582466 0.016358000226318836 0.016398000065237284 0.016439000144600868 0.016439000144600868 0.016478999983519316 0.016478999983519316 0.016521000303328037 0.016600999981164932 0.016764000058174133 0.01680499967187643 0.016805000137537718 0.016805000137537718 0.016887000296264887 0.01696800021454692 0.017008999828249216 0.017212000209838152 0.01733399974182248 0.01733399974182248 0.017741000279784203 0.018107000272721052 0.01822899980470538 0.01839200034737587 0.01859499979764223
Open Search Page TTI Baseline
Mean: 644.756 ms
Stdev: 37.614 ms (5.8%)
Runs: 596.7233079997823 597.8572999997996 600.2545580002479 600.8404540000483 606.7156170001253 608.5950119998306 610.6066080001183 615.1591799999587 618.6256099999882 621.2450359999202 623.4818120002747 623.737914999947 628.2994799995795 631.0125739998184 632.0207519996911 632.7334799999371 633.9316819999367 635.8263759999536 638.916300999932 639.0664880000986 645.1388749997132 650.1891689999029 657.2175700003281 659.8105869996361 666.1354580000043 673.7853200002573 673.9512939997949 680.1820069998503 683.6485190000385 711.1910810000263 716.4811609997414 719.9150800001808 743.6405440000817

Current
Mean: 623.093 ms
Stdev: 12.403 ms (2.0%)
Runs: 594.4171959999949 603.5315759996884 606.0805669999681 607.0424799998291 608.2463790001348 610.1005450002849 611.1112059997395 614.2742509995587 614.5507820001803 616.7701409999281 616.9994720001705 619.3594160000794 623.0806889999658 623.8920900002122 624.0303549999371 625.1459559998475 625.3971350002103 627.0238449997269 627.8067219997756 628.4829100002535 628.6364339999855 628.9066570000723 629.7172039998695 630.9661860000342 631.4486489999108 631.7969569996931 633.9963380000554 637.0512290000916 641.6832280000672 643.2910970002413 651.0488289999776

@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2023

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.2.64-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 4, 2023

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 4, 2023

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Feb 4, 2023

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants