Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Remove 2 methods that are no longer used in Deprecated API #14821

Merged
merged 2 commits into from
Feb 3, 2023
Merged

[No QA] Remove 2 methods that are no longer used in Deprecated API #14821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4263391
Remove 2 methods that are no longer used in Deprecated API
yuwenmemon Feb 3, 2023
83347d4
PR Comments
yuwenmemon Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions src/libs/deprecatedAPI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,46 +23,6 @@ Request.use(Middleware.Retry);
// SaveResponseInOnyx - Merges either the successData or failureData into Onyx depending on if the call was successful or not
Request.use(Middleware.SaveResponseInOnyx);

/**
* @param {Object} parameters
* @param {String} parameters.authToken
* @param {String} parameters.partnerName
* @param {String} parameters.partnerPassword
* @param {String} parameters.partnerUserID
* @param {String} parameters.partnerUserSecret
* @param {Boolean} [parameters.shouldRetry]
* @param {String} [parameters.email]
* @returns {Promise}
*/
function CreateLogin(parameters) {
const commandName = 'CreateLogin';
requireParameters([
'authToken',
'partnerName',
'partnerPassword',
'partnerUserID',
'partnerUserSecret',
], parameters, commandName);
return Network.post(commandName, parameters);
}

/**
* @param {Object} parameters
* @param {String} parameters.partnerUserID
* @param {String} parameters.partnerName
* @param {String} parameters.partnerPassword
* @param {Boolean} parameters.shouldRetry
* @returns {Promise}
*/
function DeleteLogin(parameters) {
const commandName = 'DeleteLogin';
requireParameters(['partnerUserID', 'partnerName', 'partnerPassword', 'shouldRetry'],
parameters, commandName);

// Non-cancellable request: during logout, when requests are cancelled, we don't want to cancel the actual logout request
return Network.post(commandName, {...parameters, canCancel: false});
}

/**
* @param {Object} parameters
* @param {String} parameters.returnValueList
Expand Down Expand Up @@ -123,8 +83,6 @@ function User_SecondaryLogin_Send(parameters) {
}

export {
CreateLogin,
DeleteLogin,
Get,
PersonalDetails_Update,
ResendValidateCode,
Expand Down
2 changes: 1 addition & 1 deletion tests/utils/TestHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function signInWithTestUser(accountID = 1, login = 'test@user.com', password = '
Session.beginSignIn(login);
return waitForPromisesToResolve()
.then(() => {
// Response is the same for calls to Authenticate and CreateLogin
// Response is the same for calls to Authenticate and BeginSignIn
HttpUtils.xhr
.mockImplementation(() => Promise.resolve({
onyxData: [
Expand Down