Fix infinite plaid spinner when coming online and other add payment method weirdness #14827

ctkochan22 · 2023-02-03T22:39:23Z

@Expensify/pullerbear

Details

Addressing the infinite spinner that happens when going back online when adding a Personal Bank Account.

On top of this, we are going to remove disabling this button when loading personal payment methods

Fixed Issues

$ #14575

Tests

Same as QA

Offline tests

Included in QA

QA Steps

Create an account on new dot
Go to Account Settings -> Payments
Click "Add Payment Method" so the menu option will come up, then go offline
Click and choose "Bank Account"
You should see a full page blocker
Go back online, and verify that Plaid kicks off properly

Example down in screen shots section

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://recordit.co/efD6c9iL8O

Mobile Web - Chrome

https://recordit.co/AEkSMN9OV6

Mobile Web - Safari

https://recordit.co/9N64VhCCd8

Desktop

2023-02-03_14-30-24.mp4

iOS

Android

melvin-bot · 2023-02-03T22:40:04Z

@sobitneupane @alex-mechler One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane

Though I already have a Paypal account added, If I am offline Add Payment Method contains Paypal.me and I am allowed to add Paypal account. (When I am online Add Payment Method does not contain Paypal.me if I already have a Paypal account added.)

My previous Paypal account gets replaced by newly added Paypal account when I go back online.

Screen.Recording.2023-02-05.at.13.56.02.mov

ctkochan22 · 2023-02-06T21:32:34Z

Though I already have a Paypal account added, If I am offline Add Payment Method contains Paypal.me and I am allowed to add Paypal account.

That seems like a possible bug for sure. However, can you open another PR? It doesn't seem related to adding a bank account and kicking off plaid from offline

ctkochan22 · 2023-02-06T21:32:41Z

@sobitneupane

ctkochan22 · 2023-02-07T05:52:27Z

@sobitneupane will you be able to test this PR please?

sobitneupane · 2023-02-07T06:00:22Z

@ctkochan22 Add payment method button used to be disabled when offline. So, #14827 (review) issue was not existent before. But we are enabling Add payment method even when offline with this PR.

sobitneupane · 2023-02-07T06:35:52Z

Screenshots/Videos

Web

Screen.Recording.2023-02-07.at.11.51.25.mov

Mobile Web - Chrome

Screen.Recording.2023-02-07.at.12.00.12.mov

Mobile Web - Safari

RPReplay_Final1675751561.MP4

Desktop

Screen.Recording.2023-02-07.at.11.55.14.mov

iOS

RPReplay_Final1675751191.MP4

Android

Screen.Recording.2023-02-07.at.12.07.39.mov

sobitneupane · 2023-02-10T12:10:58Z

I am not sure if this is something we want to handle. If we consider it as an issue, we can either handle it in this PR or create another github issue to deal with it.

ctkochan22 · 2023-02-16T00:15:33Z

Sorry @sobitneupane , circling back now. Had to hop onto an issue that required immediate attention. Looking now

ctkochan22 · 2023-02-16T05:05:38Z

I think we should create another github for how we handle paypal offline separate from this PR.

ctkochan22 · 2023-02-16T05:09:16Z

I don't think its a breaking bug, but I'm going to bring it up in slack and get some buy in. I think we should simply handle paypal like any other form.

Meaning, we'll have to change a good amount of its behavior

ctkochan22 · 2023-02-16T05:09:31Z

I may reel back this PR. Fix the spinner first

ctkochan22 · 2023-02-16T19:30:49Z

SO I'm going to re-introduce the offline disabling of the AddPaymentsMethod button, and just remove the isLoadingPaymentMethod condition. So it'll only be disabled for when the user is offline, not when payment methods are loading

ctkochan22 · 2023-02-16T19:42:05Z

@sobitneupane I updated the PR and tests in the description. Can you test please?

sobitneupane · 2023-02-17T09:04:25Z

@ctkochan22 I can still reproduce this issue.

Steps to Reproduce:

Login to Expensify
Go offline
Go to Settings > Payments
Go online and press "Add Payment method"
Press on PayPal.me and add a PayPal account

Screen.Recording.2023-02-17.at.14.42.29.mov

In my opinion, we should not consider #14681 as a bug but as an intentional behavior.

ctkochan22 · 2023-02-17T22:16:01Z

@sobitneupane I can do this on main as well. So it shouldn't block this PR. I'll create a new GH bug for it.

Also great find!

ctkochan22 · 2023-02-17T22:33:24Z

Oh no you're right, it specific to this PR because I removed the loading. Lets roll back that chance and I'll bring it up in slack how we want to approach it

ctkochan22 · 2023-02-17T23:01:43Z

Updated

sobitneupane · 2023-02-20T05:08:47Z

@ctkochan22 I think we should remove #14681 from Fixed issues in PR body because this PR will not solve #14681 issue.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-02-20.at.10.48.53.mov

Mobile Web - Chrome

Screen.Recording.2023-02-20.at.11.00.15.mov

Mobile Web - Safari

RPReplay_Final1676871206.MP4

Desktop

Screen.Recording.2023-02-20.at.11.03.04.mov

iOS

RPReplay_Final1676871141.MP4

Android

Screen.Recording.2023-02-20.at.11.14.14.mov

ctkochan22 · 2023-02-20T16:55:13Z

I agree thanks

ctkochan22 · 2023-02-20T17:48:45Z

@alex-mechler Ready for your review!

alex-mechler · 2023-02-21T18:46:28Z

There was a canceled job that had timed out, reruning that to verify it passes before merging

OSBotify · 2023-02-21T18:55:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-02-21T21:15:07Z

🚀 Deployed to staging by https://github.com/alex-mechler in version: 1.2.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-22T22:57:36Z

🚀 Deployed to production by https://github.com/melvin-bot[bot] in version: 1.2.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Kosuke Tseng added 2 commits February 3, 2023 13:13

remove form wrapper

6e6c95d

remove disabling on load

52235fd

ctkochan22 requested a review from a team as a code owner February 3, 2023 22:39

ctkochan22 self-assigned this Feb 3, 2023

melvin-bot bot requested review from alex-mechler and sobitneupane and removed request for a team February 3, 2023 22:40

fix lint

05b7292

sobitneupane reviewed Feb 5, 2023

View reviewed changes

ctkochan22 mentioned this pull request Feb 8, 2023

Add payment method appears disabled for a brief second in Payments page #14681

Closed

6 tasks

Merge branch 'main' into ckt_paymentMethod_fixPBASpinner

f408b04

re-introduce formalertwrapper

3047702

Undo isloadingPayments change

9214756

sobitneupane reviewed Feb 20, 2023

View reviewed changes

sobitneupane approved these changes Feb 20, 2023

View reviewed changes

alex-mechler approved these changes Feb 21, 2023

View reviewed changes

alex-mechler merged commit 2f09b3e into main Feb 21, 2023

alex-mechler deleted the ckt_paymentMethod_fixPBASpinner branch February 21, 2023 18:51

OSBotify mentioned this pull request Feb 21, 2023

Deploy Checklist: New Expensify 2023-02-21 #15329

Closed

19 tasks

MelvinBot mentioned this pull request Feb 22, 2023

[HOLD for payment 2023-03-01] Infinite loader is displayed when the internet is restored while trying to add a new bank account #14575

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix infinite plaid spinner when coming online and other add payment method weirdness #14827

Fix infinite plaid spinner when coming online and other add payment method weirdness #14827

ctkochan22 commented Feb 3, 2023 •

edited

Loading

melvin-bot bot commented Feb 3, 2023

sobitneupane left a comment

ctkochan22 commented Feb 6, 2023

ctkochan22 commented Feb 6, 2023

ctkochan22 commented Feb 7, 2023

sobitneupane commented Feb 7, 2023

sobitneupane commented Feb 7, 2023

sobitneupane commented Feb 10, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

sobitneupane commented Feb 17, 2023 •

edited

Loading

ctkochan22 commented Feb 17, 2023

ctkochan22 commented Feb 17, 2023

ctkochan22 commented Feb 17, 2023

sobitneupane commented Feb 20, 2023

sobitneupane left a comment

ctkochan22 commented Feb 20, 2023

ctkochan22 commented Feb 20, 2023

alex-mechler commented Feb 21, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 22, 2023

Fix infinite plaid spinner when coming online and other add payment method weirdness #14827

Fix infinite plaid spinner when coming online and other add payment method weirdness #14827

Conversation

ctkochan22 commented Feb 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 3, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

ctkochan22 commented Feb 6, 2023

ctkochan22 commented Feb 6, 2023

ctkochan22 commented Feb 7, 2023

sobitneupane commented Feb 7, 2023

sobitneupane commented Feb 7, 2023

Screenshots/Videos

sobitneupane commented Feb 10, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

ctkochan22 commented Feb 16, 2023

sobitneupane commented Feb 17, 2023 • edited Loading

ctkochan22 commented Feb 17, 2023

ctkochan22 commented Feb 17, 2023

ctkochan22 commented Feb 17, 2023

sobitneupane commented Feb 20, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

ctkochan22 commented Feb 20, 2023

ctkochan22 commented Feb 20, 2023

alex-mechler commented Feb 21, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 22, 2023

ctkochan22 commented Feb 3, 2023 •

edited

Loading

sobitneupane commented Feb 17, 2023 •

edited

Loading