Code

New contact method#15330

Code

Merged

marcaaron merged 47 commits intomainExpensify/App:mainfrom cristi_new-contact-methodExpensify/App:cristi_new-contact-methodCopy head branch name to clipboardApr 10, 2023

+266-421

Commits

Commits on Feb 21, 2023

• Add button for new contact in Contact methods page.

  cristipaval

  committed
  4298833

  Copy full SHA for 4298833

• Create NewContactMethodPage

  cristipaval

  committed
  d240884

  Copy full SHA for d240884

Commits on Feb 22, 2023

• Add description

  cristipaval

  committed
  2d50115

  Copy full SHA for 2d50115

• Add input field for login.

  cristipaval

  committed
  7fcecc5

  Copy full SHA for 7fcecc5

• Add password input when no passwordless beta

  cristipaval

  committed
  d46b4af

  Copy full SHA for d46b4af

• Add Button in new contact page.

  cristipaval

  committed
  9d1f147

  Copy full SHA for 9d1f147

• New contact methid button is not a fixed footer.

  cristipaval

  committed
  fc38d21

  Copy full SHA for fc38d21

• Submit form when no passwordless beta.

  cristipaval

  committed
  d028688

  Copy full SHA for d028688

• Merge remote-tracking branch 'origin/main' into cristi_new-contact-method

  cristipaval

  committed
  38a5de7

  Copy full SHA for 38a5de7

• Add form validation.

  cristipaval

  committed
  9c9c703

  Copy full SHA for 9c9c703

Commits on Feb 23, 2023

• For no, submit new contact method form only when no passwordless

  cristipaval

  committed
  0dcbed8

  Copy full SHA for 0dcbed8

Commits on Mar 1, 2023

• Merge remote-tracking branch 'origin/main' into cristi_new-contact-method

  cristipaval

  committed
  2a08b96

  Copy full SHA for 2a08b96

Commits on Mar 7, 2023

• Integrate New Contact Method command

  cristipaval

  committed
  782b3b2

  Copy full SHA for 782b3b2

• Merge remote-tracking branch 'origin/main' into cristi_new-contact-method

  cristipaval

  committed
  b58614d

  Copy full SHA for b58614d

• Fix conflicts after merge.

  cristipaval

  committed
  9723aa7

  Copy full SHA for 9723aa7

Commits on Mar 8, 2023

• Fix validateForm function

  cristipaval

  committed
  01ed14a

  Copy full SHA for 01ed14a

Commits on Mar 9, 2023

• Improve the onyx data when calling AddNewContactMethod command

  cristipaval

  committed
  64577c1

  Copy full SHA for 64577c1

• Show magic code stuff in ContactMethodDetailsPage only if there are no addedLogin errors.

  cristipaval

  committed
  636fc3c

  Copy full SHA for 636fc3c

• Show errorFields.addedLogin in ContactMethodDetails

  cristipaval

  committed
  017af2f

  Copy full SHA for 017af2f

• Delete contact method on server only if has been added successfully.

  cristipaval

  committed
  b2df6c4

  Copy full SHA for b2df6c4

• Show error description when a contact method failed to be added.

  cristipaval

  committed
  047ee98

  Copy full SHA for 047ee98

• Small typo in i18n

  cristipaval

  committed
  85e59bd

  Copy full SHA for 85e59bd

Commits on Mar 29, 2023

• Merge remote-tracking branch 'origin/main' into cristi_new-contact-method

  cristipaval

  committed
  335e47b

  Copy full SHA for 335e47b

• Remove LoginField.

  cristipaval

  committed
  28ad9d0

  Copy full SHA for 28ad9d0

• Remove AddSecondaryLoginPage

  cristipaval

  committed
  cbfd568

  Copy full SHA for cbfd568

• Do nothing if the new contact method is already claimed by the user.

  cristipaval

  committed
  3a7f5a6

  Copy full SHA for 3a7f5a6

• Disable autoCapitalize the input field on NewContactMethodPage

  cristipaval

  committed
  5f53d85

  Copy full SHA for 5f53d85

• Remove deprecated set secondary login command

  cristipaval

  committed
  3211e81

  Copy full SHA for 3211e81

Commits on Mar 30, 2023

• Show pending state for the added contact method while offline.

  cristipaval

  committed
  836ed2e

  Copy full SHA for 836ed2e

• Lint

  cristipaval

  committed
  9bae9f8

  Copy full SHA for 9bae9f8

• Lint

  cristipaval

  committed
  2959e90

  Copy full SHA for 2959e90

• Lint

  cristipaval

  committed
  47a6c4d

  Copy full SHA for 47a6c4d

• Lint

  cristipaval

  committed
  512fb39

  Copy full SHA for 512fb39

• Give me the green checkmark Linter, or Imma quit!

  cristipaval

  committed
  071b551

  Copy full SHA for 071b551

Commits on Apr 5, 2023

• Improve translations.

  cristipaval

  committed
  aba9ecf

  Copy full SHA for aba9ecf

• Remove unnecessary optimistic data.

  cristipaval

  committed
  ee5252f

  Copy full SHA for ee5252f

• Remove unnecessary default to null.

  cristipaval

  committed
  12cfc2c

  Copy full SHA for 12cfc2c

• Update src/pages/settings/Profile/Contacts/ContactMethodsPage.js

  Show description for c37480e
  

  cristipaval

  and

  marcaaron

  authored
  c37480e

  Copy full SHA for c37480e

• Update src/pages/settings/Profile/Contacts/ContactMethodsPage.js

  Show description for f9f0fde
  

  cristipaval

  and

  marcaaron

  authored
  f9f0fde

  Copy full SHA for f9f0fde

• Update src/pages/settings/Profile/Contacts/NewContactMethodPage.js

  Show description for f7e874c
  

  cristipaval

  and

  marcaaron

  authored
  f7e874c

  Copy full SHA for f7e874c

• Update src/ROUTES.js

  Show description for db660c7
  

  cristipaval

  and

  Beamanator

  authored
  db660c7

  Copy full SHA for db660c7

• Update src/libs/actions/User.js

  Show description for b7835f4
  

  cristipaval

  and

  Beamanator

  authored
  b7835f4

  Copy full SHA for b7835f4

• Address feedback.

  cristipaval

  committed
  e722fb6

  Copy full SHA for e722fb6

Commits on Apr 6, 2023

• Fix Linter errors.

  cristipaval

  committed
  73f6a78

  Copy full SHA for 73f6a78

Commits on Apr 10, 2023

• Improve the look of New Contact Method button

  cristipaval

  committed
  6b8383a

  Copy full SHA for 6b8383a

• Do not ask for confirmation when deleting a contact method which has errors.

  cristipaval

  committed
  7553807

  Copy full SHA for 7553807

• Add function doc.

  cristipaval

  committed
  539fa78

  Copy full SHA for 539fa78