Update style for get-help block #15484

marcochavezf · 2023-02-24T17:50:07Z

Details

We want to change the style for the Didn't find what you're looking for? to stand out hub blocks in the ExpensifyHelp homepage

Fixed Issues

$ #15479

Tests

Run the ExpensifyHelp site and verify the Didn't find what you're looking for? is updated according to the mock-up here.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

(Only production) Go to https://help.expensify.com/ and verify the Didn't find what you're looking for? is updated according to the mock-up here.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

ExpensifyHelp only works on web

iOS

ExpensifyHelp only works on web

Android

ExpensifyHelp only works on web

MelvinBot · 2023-02-24T17:50:54Z

@sobitneupane @arosiclair One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcochavezf · 2023-02-24T17:51:28Z

@shawnborton this is how the site looks like with the changes in this PR:

marcochavezf · 2023-02-24T17:52:24Z

Removing C+ review since this is a simple change in the ExpensifyHelp site

shawnborton · 2023-02-24T17:55:13Z

Looks good! Let's update the style of "Didnt find what you were looking for?" to match the heading above that says "Which best describes..."

arosiclair · 2023-02-24T20:04:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

marcochavezf · 2023-03-03T21:12:56Z

Sorry for the delay here, updated! @shawnborton @arosiclair

shawnborton · 2023-03-06T01:12:12Z

Looks good, thanks!

arosiclair

Looks good and tests well other than that h2 style

arosiclair · 2023-03-07T21:15:24Z

docs/_sass/_main.scss

@@ -577,6 +577,10 @@ button {
 .get-help {
    flex-wrap: wrap;
    margin-top: auto;
+
+    h3 {
+        padding-bottom: 8px;


We don't need this now that we switched to h2 right?

Oh that's correct, I removed it

OSBotify · 2023-03-10T17:57:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-13T12:55:39Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.2.83-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-03-13T14:45:00Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.2.83-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-14T03:00:10Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.83-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcochavezf added 2 commits February 24, 2023 11:38

update get-help block elements

af2e183

update padding for get-help title

db8ba2c

marcochavezf requested a review from a team as a code owner February 24, 2023 17:50

marcochavezf self-assigned this Feb 24, 2023

melvin-bot bot requested review from arosiclair and sobitneupane and removed request for a team February 24, 2023 17:50

marcochavezf removed the request for review from sobitneupane February 24, 2023 17:52

update style for get-help title

25090d3

arosiclair reviewed Mar 7, 2023

View reviewed changes

marcochavezf added 2 commits March 10, 2023 11:27

Merge branch 'main' into marco-updateGetHelpBlock

39cc124

remove get-help.h3

f4a2b56

marcochavezf requested a review from arosiclair March 10, 2023 17:29

arosiclair approved these changes Mar 10, 2023

View reviewed changes

arosiclair merged commit efddf2d into main Mar 10, 2023

arosiclair deleted the marco-updateGetHelpBlock branch March 10, 2023 17:53

OSBotify mentioned this pull request Mar 13, 2023

Deploy Checklist: New Expensify 2023-03-13 #15889

Closed

16 tasks

MelvinBot mentioned this pull request Mar 14, 2023

[HOLD for payment 2023-03-21] [ExpensifyHelp] Update style for "Didn't find what you're looking for?" block #15479

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update style for get-help block #15484

Update style for get-help block #15484

marcochavezf commented Feb 24, 2023

MelvinBot commented Feb 24, 2023

marcochavezf commented Feb 24, 2023

marcochavezf commented Feb 24, 2023

shawnborton commented Feb 24, 2023

arosiclair commented Feb 24, 2023 •

edited

Loading

marcochavezf commented Mar 3, 2023 •

edited

Loading

shawnborton commented Mar 6, 2023

arosiclair left a comment

arosiclair Mar 7, 2023

marcochavezf Mar 10, 2023

OSBotify commented Mar 10, 2023

OSBotify commented Mar 13, 2023

OSBotify commented Mar 13, 2023

OSBotify commented Mar 14, 2023

Update style for get-help block #15484

Update style for get-help block #15484

Conversation

marcochavezf commented Feb 24, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Feb 24, 2023

marcochavezf commented Feb 24, 2023

marcochavezf commented Feb 24, 2023

shawnborton commented Feb 24, 2023

arosiclair commented Feb 24, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

marcochavezf commented Mar 3, 2023 • edited Loading

shawnborton commented Mar 6, 2023

arosiclair left a comment

Choose a reason for hiding this comment

arosiclair Mar 7, 2023

Choose a reason for hiding this comment

marcochavezf Mar 10, 2023

Choose a reason for hiding this comment

OSBotify commented Mar 10, 2023

OSBotify commented Mar 13, 2023

OSBotify commented Mar 13, 2023

OSBotify commented Mar 14, 2023

arosiclair commented Feb 24, 2023 •

edited

Loading

marcochavezf commented Mar 3, 2023 •

edited

Loading