Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version to 1.2.77-4 on main #15587

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Update version to 1.2.77-4 on main #15587

merged 1 commit into from
Mar 1, 2023

Conversation

OSBotify
Copy link
Contributor

@OSBotify OSBotify commented Mar 1, 2023

Update version to 1.2.77-4

@OSBotify OSBotify requested a review from a team as a code owner March 1, 2023 02:45
@melvin-bot melvin-bot bot removed the request for review from a team March 1, 2023 02:45
@OSBotify OSBotify merged commit 44c19cb into main Mar 1, 2023
@OSBotify OSBotify deleted the version-BUILD-482E6BF9-387B-409C-ADCF-F65045FDEB7D branch March 1, 2023 02:45
OSBotify added a commit that referenced this pull request Mar 1, 2023
@OSBotify
Merge pull request #15587 from Expensify/version-BUILD-482E6BF9-387B-…
169afe3 
…409C-ADCF-F65045FDEB7D

Update version to 1.2.77-4 on main

(cherry picked from commit 44c19cb)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
Open Search Page TTI 612.254 ms → 670.833 ms (+58.579 ms, +9.6%) 🔴
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 612.254 ms
Stdev: 16.608 ms (2.7%)
Runs: 582.7482099998742 585.2372239995748 587.203857999295 587.6558839995414 589.3264159988612 590.4265950005502 594.5638430006802 601.8024909999222 606.6656489986926 607.4785159993917 608.8812669999897 609.140055000782 611.253824999556 611.4884850010276 611.6341559998691 611.7208259999752 611.9405109994113 612.4034839998931 613.0694580003619 614.030843000859 616.0289709996432 616.6803389992565 617.9118659999222 618.3678390011191 621.1041669994593 629.7050790004432 631.7641599997878 632.6187750007957 635.4372570011765 635.7528889998794 637.0894779991359 650.9839280005544

Current
Mean: 670.833 ms
Stdev: 21.479 ms (3.2%)
Runs: 636.4179289992899 638.4567869994789 647.4126379992813 647.5321860015392 650.7343349996954 651.1158450003713 651.324543999508 653.5050050001591 654.8884689994156 657.7359619997442 660.403279999271 662.2775069996715 663.1738689988852 663.3335779998451 663.8461920004338 665.1677250005305 666.3549810014665 666.8962409999222 669.0595710016787 669.5121259987354 671.8841970004141 676.8961999993771 678.152668999508 678.8994550015777 678.9119869992137 682.591105999425 687.9469410013407 688.5583089999855 697.8458660002798 704.3376470003277 704.5986740011722 723.1240240000188 724.5806080009788

Meaningless Changes To Duration

Show entries
Name Duration
App start TTI 726.837 ms → 747.278 ms (+20.441 ms, +2.8%)
App start runJsBundle 202.719 ms → 204.219 ms (+1.500 ms, +0.7%)
App start nativeLaunch 20.806 ms → 21.167 ms (+0.360 ms, +1.7%)
App start regularAppStart 0.014 ms → 0.015 ms (+0.001 ms, +4.9%)
Show details
Name Duration
App start TTI Baseline
Mean: 726.837 ms
Stdev: 25.646 ms (3.5%)
Runs: 681.209326999262 685.6151199992746 685.7155879996717 688.297759000212 697.2796849999577 698.579570999369 700.3645610008389 707.4474679995328 707.7955639995635 712.1473440006375 715.7624779995531 721.1324840001762 722.7969589997083 723.5685380008072 724.2579980008304 727.7466889992356 727.8928670007735 728.2378129996359 733.3858989998698 740.31741899997 741.1896749995649 742.3099780008197 747.3570259995759 750.025073999539 752.1763369999826 752.2336999997497 752.4618870001286 758.2534510008991 762.8987019993365 768.6775950007141 774.8095169998705

Current
Mean: 747.278 ms
Stdev: 32.515 ms (4.4%)
Runs: 689.8030060008168 698.8650299999863 707.8334470000118 714.9676370006055 715.4779240004718 719.5004110001028 720.4763089995831 720.7003840003163 721.2990390006453 725.0580380000174 726.5356959998608 729.4253899995238 731.3182289991528 733.718791000545 734.609913000837 740.5050700008869 741.0904879998416 742.0929979998618 744.80680100061 745.4626490008086 762.6035920009017 763.7779040001333 767.4493230003864 774.0490249991417 777.0687959995121 782.2141980007291 785.237362999469 785.9408899992704 787.4586050007492 796.7840940002352 801.9564050007612 824.7976779993623
App start runJsBundle Baseline
Mean: 202.719 ms
Stdev: 20.195 ms (10.0%)
Runs: 172 175 179 183 184 184 186 187 188 193 193 193 195 195 197 197 197 197 200 201 201 207 210 211 220 222 223 228 233 240 240 256

Current
Mean: 204.219 ms
Stdev: 14.628 ms (7.2%)
Runs: 180 182 184 186 187 190 192 194 196 196 197 197 198 198 199 199 200 203 203 207 208 210 213 216 218 221 223 225 226 226 227 234
App start nativeLaunch Baseline
Mean: 20.806 ms
Stdev: 1.767 ms (8.5%)
Runs: 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 21 21 21 21 22 22 22 22 23 23 23 23 24 26

Current
Mean: 21.167 ms
Stdev: 2.034 ms (9.6%)
Runs: 19 19 19 19 19 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 22 22 23 23 24 25 26 27
App start regularAppStart Baseline
Mean: 0.014 ms
Stdev: 0.001 ms (5.3%)
Runs: 0.01285799965262413 0.013304999098181725 0.013305999338626862 0.013508999720215797 0.013591000810265541 0.013956999406218529 0.013956999406218529 0.013957001268863678 0.014038000255823135 0.014118999242782593 0.014201000332832336 0.014281999319791794 0.014282001182436943 0.014322999864816666 0.014404000714421272 0.014485999941825867 0.014526000246405602 0.014526000246405602 0.014606999233365059 0.01464799977838993 0.014649000018835068 0.014689000323414803 0.01477000117301941 0.014771001413464546 0.015135999768972397 0.015380999073386192 0.015707001090049744 0.015991000458598137 0.016235999763011932

Current
Mean: 0.015 ms
Stdev: 0.001 ms (8.6%)
Runs: 0.012531999498605728 0.01314300112426281 0.013305999338626862 0.013508999720215797 0.013671999797224998 0.013833999633789062 0.013876000419259071 0.014039000496268272 0.014078998938202858 0.014119001105427742 0.014608001336455345 0.014649000018835068 0.014892999082803726 0.014973999932408333 0.015015000477433205 0.015095999464392662 0.015095999464392662 0.015298999845981598 0.015421999618411064 0.015502000227570534 0.01550300046801567 0.015706000849604607 0.015828000381588936 0.015949999913573265 0.015951000154018402 0.015951000154018402 0.016356999054551125 0.01648000068962574 0.016967998817563057 0.01729300059378147 0.017578000202775 0.017903000116348267

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Mar 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
automerge DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OSBotify