Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify emojiHeaderContainer style with a -1 top, only on non-native devices #15589

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Modify emojiHeaderContainer style with a -1 top, only on non-native devices #15589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbd7dc5
Modify emojiHeaderContainer style with a -1 top, only on non-native d…
patrickcze Mar 1, 2023
f59daa3
Adding a clear comment of why we are making this change to the emojiH…
patrickcze Mar 1, 2023
1391e60
Expanding for readability, and updating import order
patrickcze Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/styles/emojiHeaderContainerPlatformStyles/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// This change is only temporary until browser have fixed the issue with position: sticky causing the header to bounce on scroll in non-native apps
// https://github.com/Expensify/App/issues/15282
// https://bugs.chromium.org/p/chromium/issues/detail?id=734461
export default {
top: -1,
};
1 change: 1 addition & 0 deletions src/styles/emojiHeaderContainerPlatformStyles/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default {};
2 changes: 2 additions & 0 deletions src/styles/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import codeStyles from './codeStyles';
import visibility from './utilities/visibility';
import writingDirection from './utilities/writingDirection';
import optionAlternateTextPlatformStyles from './optionAlternateTextPlatformStyles';
import emojiHeaderContainerPlatformStyles from './emojiHeaderContainerPlatformStyles';
import pointerEventsNone from './pointerEventsNone';
import pointerEventsAuto from './pointerEventsAuto';
import overflowXHidden from './overflowXHidden';
Expand Down Expand Up @@ -1488,6 +1489,7 @@ const styles = {
height: CONST.EMOJI_PICKER_HEADER_HEIGHT,
justifyContent: 'center',
width: '100%',
...emojiHeaderContainerPlatformStyles,
},

emojiSkinToneTitle: {
Expand Down