Revert "Fix miss-matched SMS email suffix on sign in page"

[yuwenmemon]

Revert of #15351

@AndrewGable @luacmartins or @roryabraham please review
cc @Julesssss

Based on the discussion here https://expensify.slack.com/archives/C07J32337/p1677703372513129 we think this may be causing the performance regression we're seeing across most newly merged PRs in App. However, we don't currently have a way to test the performance regression flow on a specific branch, so we need to merge this in order for that to happen.

Tests

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

android-chrome.mp4

Mobile Web - Safari

ios-safari.mp4

Desktop

desktop.mp4

iOS

ios-app.mp4

Android

android-app.mp4

[MelvinBot]

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A straight revert

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[MelvinBot]

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[luacmartins]

It looks like we restarted Jest Unit Tests / test (job 3) (pull_request) just before the merge. Here's the thread for more context

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
Open Search Page TTI	618.848 ms → 676.562 ms (+57.714 ms, +9.3%) 🔴

Show details

Name

Duration

Open Search Page TTI

Baseline Mean: 618.848 ms Stdev: 18.931 ms (3.1%) Runs: 580.1321209999733 581.0692549999803 588.5075690001249 591.4421799997799 600.7012129998766 601.3940439997241 604.1504719997756 604.7805180000141 608.2589519997127 611.9559740000404 612.4888520003296 613.4118249998428 615.0928139998578 616.1925050001591 616.394125000108 616.8953450000845 616.8966879998334 618.6507569998503 619.0523689999245 619.0918379998766 622.2340090000071 624.5168460002169 628.0392660000362 629.3702389998361 633.1362310000695 635.1853029998019 637.091023999732 637.676188999787 638.538126999978 640.4822599999607 647.085165000055 648.9353029998019 663.134724999778 Current Mean: 676.562 ms Stdev: 18.035 ms (2.7%) Runs: 629.2653810000047 650.9194339998066 655.1367599996738 655.3249109997414 656.2130530001596 656.510214000009 656.6914070001803 661.1610109996982 662.5959069998935 662.7109380001202 663.628173999954 671.9466550000943 672.1951909996569 674.7062589996494 675.2862949999981 677.709309999831 678.7865809998475 680.4711509998888 680.7216400001198 681.4523120000958 682.3830570001155 684.3211670001037 685.9736740002409 688.3427740000188 689.3068039999343 690.9743649996817 693.4982099998742 694.7698160000145 699.3768719998188 700.3673510001972 700.7945969998837 701.8970139999874 711.0963139999658

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	718.082 ms → 735.887 ms (+17.805 ms, +2.5%)
App start runJsBundle	192.452 ms → 202.281 ms (+9.830 ms, +5.1%)
App start nativeLaunch	19.594 ms → 19.828 ms (+0.234 ms, +1.2%)
App start regularAppStart	0.014 ms → 0.015 ms (+0.001 ms, +5.1%)

Show details

Name	Duration
App start TTI	Baseline Mean: 718.082 ms Stdev: 27.174 ms (3.8%) Runs: 678.4033490000293 684.7531229997985 685.6430009999312 687.5314150000922 687.5500909998082 689.0363329998218 691.8497930001467 695.586633999832 695.603995999787 696.7049839999527 697.0718809999526 704.8909080000594 705.6245470000431 706.1822620001622 708.608324999921 709.7432949999347 721.3261910001747 721.9918760000728 724.6671719998121 724.9357480001636 725.9793420000933 727.2809910001233 730.9623969998211 731.7639399999753 737.4272369998507 739.0137900002301 743.2346660001203 753.2673240001313 754.1029460001737 758.1624750001356 772.1314229997806 787.5825939998031 Current Mean: 735.887 ms Stdev: 24.372 ms (3.3%) Runs: 687.8608929999173 688.9117809999734 696.5927809998393 708.4104329999536 708.4935240000486 713.3576349997893 713.4259959999472 713.6142179998569 715.6773270000704 715.7195680001751 720.3585600000806 728.253500000108 730.3395059998147 734.3436099998653 736.1752820000984 739.0898460000753 740.3943529999815 740.6710569998249 744.1117090000771 746.2742320001125 747.4494830002077 749.3110389998183 749.7770239999518 751.8129039998166 753.5810890002176 759.5773990000598 759.9301530001685 762.948679999914 767.721421000082 770.6179160000756 771.8293619998731 781.7505720001645
App start runJsBundle	Baseline Mean: 192.452 ms Stdev: 13.979 ms (7.3%) Runs: 167 168 171 177 178 178 183 183 185 185 186 186 188 189 191 191 192 192 192 194 199 200 202 203 207 207 208 209 216 216 223 Current Mean: 202.281 ms Stdev: 18.928 ms (9.4%) Runs: 176 177 178 180 182 187 187 188 188 191 191 191 192 193 198 198 199 199 200 205 207 211 211 212 214 218 220 220 234 235 242 249
App start nativeLaunch	Baseline Mean: 19.594 ms Stdev: 2.090 ms (10.7%) Runs: 17 17 17 18 18 18 18 18 18 18 18 18 18 18 19 19 19 19 19 20 20 20 21 21 21 21 22 22 23 24 24 24 Current Mean: 19.828 ms Stdev: 1.743 ms (8.8%) Runs: 18 18 18 18 18 18 18 18 19 19 19 19 19 20 20 20 20 20 20 20 20 20 21 21 21 22 22 24 25
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (4.0%) Runs: 0.012980000115931034 0.013224000111222267 0.013306000269949436 0.013631999958306551 0.0138349998742342 0.013875000178813934 0.013916000258177519 0.013996999710798264 0.01399700017645955 0.0139979999512434 0.014037999790161848 0.014037999790161848 0.014078999869525433 0.01407900033518672 0.014240999706089497 0.014322999864816666 0.01436399994418025 0.014403999783098698 0.01448499970138073 0.014485999941825867 0.014527000021189451 0.014567000325769186 0.014649000018835068 0.014688999857753515 0.014771000016480684 0.014851999934762716 0.014851999934762716 0.014973999932408333 0.015217999927699566 0.015217999927699566 0.015339999925345182 Current Mean: 0.015 ms Stdev: 0.001 ms (7.9%) Runs: 0.013346000108867884 0.013387000188231468 0.013549999799579382 0.013753000181168318 0.0138349998742342 0.013915999792516232 0.0139979999512434 0.0142000000923872 0.014323000330477953 0.01436399994418025 0.014405000023543835 0.014485999941825867 0.014486000407487154 0.014525999780744314 0.014527000021189451 0.014567000325769186 0.014607999939471483 0.01464799977838993 0.01501399977132678 0.015056000091135502 0.015176999848335981 0.015340999700129032 0.015422000084072351 0.01570699969306588 0.01587000023573637 0.016113999765366316 0.016316999681293964 0.016642000060528517 0.016927000135183334 0.01696800021454692 0.01725299982354045 0.01798499980941415

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[yuwenmemon]

Damn. Okay.

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.2.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅