Have "select all" only select visible members #15609

Gonals · 2023-03-02T12:40:35Z

Details

Fixed Issues

$ #15487

Tests

In NewDot, create a Workspace with several members
Then go to Settings>Workspaces>Workspace>Manage members
Start a search that only displays some (not all) the members
Click Select all. All visible members should get selected.
Remove your search. Select All should get unselected, but the previously selected members (and only them) should remain selected)
Add now a different search that returns non-selected member. Clicking Select All should replace the existing list with the visible one, not add to it.
In any situation, selecting and unselecting Select All should clear the list completely.

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

MelvinBot · 2023-03-02T12:41:13Z

@Santhosh-Sellavel @Luke9389 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Gonals · 2023-03-09T11:56:29Z

OFF HOLD! Ready for review

joekaufmanexpensify · 2023-03-09T15:49:57Z

Fixed Issues
$ #15487

(trying again as the PR wasn't linked to the issue the first time)

Santhosh-Sellavel · 2023-03-09T21:32:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-03-17.at.12.25.17.AM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-03-17.at.12.32.59.AM.mov

iOS & Android

Screen.Recording.2023-03-17.at.12.27.42.AM.mov

Santhosh-Sellavel · 2023-03-09T21:39:28Z

src/pages/workspace/WorkspaceMembersPage.js

        policyMemberList = _.filter(_.keys(policyMemberList), policyMember => policyMemberList[policyMember].pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
        const removableMembers = _.without(policyMemberList, this.props.session.email, this.props.policy.owner);


Shouldn't we remove this because we already get only removableMembers in memberList list

I left it as a sanity check to make sure no owners were incorrectly selected/unselected, but we can remove it and leave it only if the memberList is empty, if you feel strongly about it

We can remove this, this method is used in one place, which has memberList that is removable only. All these checks are taken care of there.

Santhosh-Sellavel · 2023-03-13T16:45:27Z

src/pages/workspace/WorkspaceMembersPage.js

+        // If a memberList is provided, only select those members. Otherwise, select all the policy ones
+        let policyMemberList = _.isEmpty(memberList) ? lodashGet(this.props, 'policyMemberList', {}) : memberList;
+


I'm not sure would why would we need this. There is a valid case where memberList can be empty that's when the workspace has an owner alone. Getting value from the prop is unnecessary,

Santhosh-Sellavel · 2023-03-13T16:47:21Z

src/pages/workspace/WorkspaceMembersPage.js

        policyMemberList = _.filter(_.keys(policyMemberList), policyMember => policyMemberList[policyMember].pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
        const removableMembers = _.without(policyMemberList, this.props.session.email, this.props.policy.owner);


We can remove this, this method is used in one place, which has memberList that is removable only. All these checks are taken care of there.

Santhosh-Sellavel · 2023-03-15T13:17:06Z

Bug:
On the manage member page,

Enter search text to filter user -> Select all toggle selection on -> Clear search
Only Visible user on search results was selected. Test pass ✅

Assuming No search text at start -> Select all -> Enter search text filter few users -> Press select toggle selection off -> Clear search
So expecting as the 1st case, pressing Select all should deselect only visible users on search instead, all the users are deselected. Test fail ❌

Screen.Recording.2023-03-15.at.6.38.32.PM.mov

@Gonals Thoughts on this, please?

Gonals · 2023-03-16T18:44:11Z

Bug: On the manage member page,

Enter search text to filter user -> Select all toggle selection on -> Clear search
Only Visible user on search results was selected. Test pass ✅

Assuming No search text at start -> Select all -> Enter search text filter few users -> Press select toggle selection off -> Clear search So expecting as the 1st case, pressing Select all should deselect only visible users on search instead, all the users are deselected. Test fail ❌

@Gonals Thoughts on this, please?

This is the expected behavior (step 7). We discussed it in the slack chat and decided we wanted this. Otherwise, it is really hard to "unselect" stuff from previous searchs

Santhosh-Sellavel · 2023-03-16T18:50:31Z

Cool, it feels weird though but thanks for reconfirming it's not a bug!

Santhosh-Sellavel

LGTM tests well!

@Luke9389 Over to you!

MelvinBot · 2023-03-20T17:36:05Z

@Santhosh-Sellavel @techievivek One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Gonals · 2023-03-20T17:37:31Z

@techievivek, over to you, as Luke left not long ago!

techievivek

The code is much more simplified now, thanks. I just have a few NAB suggestions.

src/pages/workspace/WorkspaceMembersPage.js

Gonals · 2023-03-21T16:26:16Z

Comments addressed!

techievivek

Thanks, merged 🎉

OSBotify · 2023-03-21T16:34:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-24T19:07:17Z

🚀 Deployed to staging by https://github.com/techievivek in version: 1.2.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-27T10:33:59Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Gonals added 6 commits March 1, 2023 14:13

check visible members, not all of them

c78406a

format list correctly

8e2a67b

format earlier

c81a3f0

clean up functionality

fb878ec

add header

307eb15

style

41ad492

Gonals requested a review from a team as a code owner March 2, 2023 12:40

Gonals self-assigned this Mar 2, 2023

melvin-bot bot requested review from Luke9389 and Santhosh-Sellavel and removed request for a team March 2, 2023 12:41

Gonals added 2 commits March 2, 2023 13:42

conflicts

9319f19

lint

c0bbf8d

Gonals mentioned this pull request Mar 9, 2023

[HOLD for payment 2023-04-03] Select all after search selects all the members rather then only selecting searched result in manage members of workspace #15487

Closed

6 tasks

Gonals added 2 commits March 9, 2023 11:56

Merge branch 'main' into alberto-selector

fa7bf99

add comment

b2ccdd4

Gonals changed the title ~~[HOLD] Have "select all" only select visible members~~ Have "select all" only select visible members Mar 9, 2023

Santhosh-Sellavel suggested changes Mar 9, 2023

View reviewed changes

Merge branch 'main' into alberto-selector

8289828

Santhosh-Sellavel suggested changes Mar 13, 2023

View reviewed changes

Gonals added 3 commits March 14, 2023 09:50

Merge branch 'main' into alberto-selector

654ad40

use provided list always

b90244a

use emails

4b2928e

Santhosh-Sellavel approved these changes Mar 16, 2023

View reviewed changes

Gonals requested review from a team and removed request for Luke9389 March 20, 2023 17:35

melvin-bot bot requested review from Santhosh-Sellavel and techievivek and removed request for a team March 20, 2023 17:36

Santhosh-Sellavel previously approved these changes Mar 20, 2023

View reviewed changes

techievivek reviewed Mar 20, 2023

View reviewed changes

src/pages/workspace/WorkspaceMembersPage.js Outdated Show resolved Hide resolved

src/pages/workspace/WorkspaceMembersPage.js Outdated Show resolved Hide resolved

Gonals added 2 commits March 21, 2023 15:02

Merge branch 'main' into alberto-selector

670045f

rename variables for simplicity

5e229f5

Gonals dismissed Santhosh-Sellavel’s stale review via 5e229f5 March 21, 2023 16:17

Santhosh-Sellavel approved these changes Mar 21, 2023

View reviewed changes

techievivek approved these changes Mar 21, 2023

View reviewed changes

techievivek merged commit 885de7e into main Mar 21, 2023

techievivek deleted the alberto-selector branch March 21, 2023 16:30

OSBotify mentioned this pull request Mar 24, 2023

Deploy Checklist: New Expensify 2023-03-24 #16489

Closed

44 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Have "select all" only select visible members #15609

Have "select all" only select visible members #15609

Gonals commented Mar 2, 2023 •

edited

Loading

MelvinBot commented Mar 2, 2023

Gonals commented Mar 9, 2023

joekaufmanexpensify commented Mar 9, 2023

Santhosh-Sellavel commented Mar 9, 2023 •

edited

Loading

Santhosh-Sellavel Mar 9, 2023 •

edited

Loading

Gonals Mar 13, 2023

Santhosh-Sellavel Mar 13, 2023

Santhosh-Sellavel Mar 13, 2023

Santhosh-Sellavel Mar 13, 2023

Santhosh-Sellavel commented Mar 15, 2023

Gonals commented Mar 16, 2023

Santhosh-Sellavel commented Mar 16, 2023

Santhosh-Sellavel left a comment

MelvinBot commented Mar 20, 2023

Gonals commented Mar 20, 2023

techievivek left a comment

Gonals commented Mar 21, 2023

techievivek left a comment

OSBotify commented Mar 21, 2023

OSBotify commented Mar 24, 2023

OSBotify commented Mar 27, 2023

		policyMemberList = _.filter(_.keys(policyMemberList), policyMember => policyMemberList[policyMember].pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
		const removableMembers = _.without(policyMemberList, this.props.session.email, this.props.policy.owner);

		// If a memberList is provided, only select those members. Otherwise, select all the policy ones
		let policyMemberList = _.isEmpty(memberList) ? lodashGet(this.props, 'policyMemberList', {}) : memberList;

Have "select all" only select visible members #15609

Have "select all" only select visible members #15609

Conversation

Gonals commented Mar 2, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 2, 2023

Gonals commented Mar 9, 2023

joekaufmanexpensify commented Mar 9, 2023

Santhosh-Sellavel commented Mar 9, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel Mar 9, 2023 • edited Loading

Choose a reason for hiding this comment

Gonals Mar 13, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Mar 13, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Mar 13, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Mar 13, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel commented Mar 15, 2023

Gonals commented Mar 16, 2023

Santhosh-Sellavel commented Mar 16, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

MelvinBot commented Mar 20, 2023

Gonals commented Mar 20, 2023

techievivek left a comment

Choose a reason for hiding this comment

Gonals commented Mar 21, 2023

techievivek left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 21, 2023

OSBotify commented Mar 24, 2023

OSBotify commented Mar 27, 2023

Gonals commented Mar 2, 2023 •

edited

Loading

Santhosh-Sellavel commented Mar 9, 2023 •

edited

Loading

Santhosh-Sellavel Mar 9, 2023 •

edited

Loading