Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Staging API] To Use Staging Server or not to use staging server" #15678

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Revert "[Staging API] To Use Staging Server or not to use staging server" #15678

merged 1 commit into from
Mar 6, 2023

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Mar 6, 2023 •
edited
Loading

Reverts #15517

image

@mountiny mountiny requested a review from a team as a code owner March 6, 2023 13:46
@mountiny mountiny self-assigned this Mar 6, 2023
@MelvinBot
Copy link

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@melvin-bot melvin-bot bot requested review from cead22 and removed request for a team March 6, 2023 13:46
@MelvinBot
Copy link

@cead22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss
Julesssss approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mountiny mountiny requested a review from Julesssss March 6, 2023 13:47
@Julesssss
Copy link
Contributor

Merging without checklists, as this is a revert PR!

@Julesssss Julesssss merged commit 719b7cd into main Mar 6, 2023
@Julesssss Julesssss deleted the revert-15517-dynamic-api branch March 6, 2023 14:23
@melvin-bot melvin-bot bot added the Emergency label Mar 6, 2023
@MelvinBot
Copy link

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Julesssss
Copy link
Contributor

@MelvinBot explained above

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 6, 2023
Closed
17 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2023

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.2.79-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally mvtglobally mentioned this pull request Mar 6, 2023
Merged
54 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Mar 7, 2023

🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.79-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cead22 cead22 Awaiting requested review from cead22

@Julesssss Julesssss Awaiting requested review from Julesssss

Assignees

@mountiny mountiny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mountiny @MelvinBot @Julesssss @OSBotify