Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow webp files on newdot #16031

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Conversation

allroundexperts
Copy link
Contributor

@allroundexperts allroundexperts commented Mar 16, 2023

Details

This PR adds webP as an accepted image format on New Dot.

Fixed Issues

$ #15565
PROPOSAL: #15565 (comment)

Tests

  1. Save a webp format image.
  2. Open the app, open any chat
  3. Press Add attachment and send the file
  4. Verify that the file uploads without any error.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

  1. Save a webp format image.
  2. Open the app, open any chat
  3. Press Add attachment and send the file
  4. Verify that the file uploads without any error.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
screen-recording-2023-03-24-at-20340-am_8j8o8rXs.mp4
Mobile Web - Chrome
screen-recording-2023-03-24-at-20913-am_yXNcsbbZ.mp4
Mobile Web - Safari
screen-recording-2023-03-24-at-20728-am_gibUlafM.mp4
Desktop
screen-recording-2023-03-24-at-20547-am_rxG3YqES.mp4
iOS
Screen.Recording.2023-03-24.at.2.19.01.AM.mov
Android
Screen.Recording.2023-03-24.at.2.15.12.AM.mov

@allroundexperts allroundexperts marked this pull request as ready for review March 16, 2023 15:16
@allroundexperts allroundexperts requested a review from a team as a code owner March 16, 2023 15:16
@melvin-bot melvin-bot bot requested review from PauloGasparSv and Santhosh-Sellavel and removed request for a team March 16, 2023 15:17
@MelvinBot
Copy link

@PauloGasparSv @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PauloGasparSv Are we good with the use of these libraries?

package-lock.json Outdated Show resolved Hide resolved
@PauloGasparSv
Copy link
Contributor

Hey @allroundexperts (and cc @Santhosh-Sellavel) sorry about this, but we had another internal discussion on this (originally to discuss the libs you added) and we decided that:

  1. We should fix the webp file upload this time so it actually works instead of validating the mimeType before uploading.
  2. So we should make a change in the API and the App to allow the webp extension

@allroundexperts would you please remove the change we have now from this P.R. and implement the changes for allowing the webp file extension in newDot (I think the change should be done here)?

I'll change the API logic to allow webp in the meantime.

@allroundexperts
Copy link
Contributor Author

Hey @allroundexperts (and cc @Santhosh-Sellavel) sorry about this, but we had another internal discussion on this (originally to discuss the libs you added) and we decided that:

  1. We should fix the webp file upload this time so it actually works instead of validating the mimeType before uploading.
  2. So we should make a change in the API and the App to allow the webp extension

@allroundexperts would you please remove the change we have now from this P.R. and implement the changes for allowing the webp file extension in newDot (I think the change should be done here)?

I'll change the API logic to allow webp in the meantime.

@PauloGasparSv Sure. I'll do that.

@allroundexperts
Copy link
Contributor Author

@PauloGasparSv However, I think we should still validate the file types. As an example, consider someone uploading a mp3 file renamed as a JPG. I think that will throw the same error.

@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Mar 17, 2023

@PauloGasparSv However, I think we should still validate the file types. As an example, consider someone uploading a mp3 file renamed as a JPG. I think that will throw the same error.

I agree we should validate it in the client too @allroundexperts! But I think we should go with the decision of the team this time.

If this happens again we can start another discussion and mention this issue as a reason to implement the mimeType check (someone will probably find this while investigating if something happens).

And it's good thing that the API will throw an error for invalid files even if the extension was changed, it confirms that it's ok to do this changes for now as we are validating the files somewhere.

Thks for the help and patience

@allroundexperts
Copy link
Contributor Author

@PauloGasparSv However, I think we should still validate the file types. As an example, consider someone uploading a mp3 file renamed as a JPG. I think that will throw the same error.

I agree we should validate it in the client too @allroundexperts! But I think we should go with the decision of the team this time.

If this happens again we can start another discussion and mention this issue as a reason to implement the mimeType check (someone will probably find this while investigating if something happens).

And it's good thing that the API will throw an error for invalid files even if the extension was changed, it confirms that it's ok to do this changes for now as we are validating the files somewhere.

Thks for the help and patience

Sounds good. I'll revert and add the requested changes.

@PauloGasparSv
Copy link
Contributor

BTW, I just finished the API P.R. but there is 1 problem that I'm trying to figure out:

image

Clicking on the webp image to view it works fine! But the image preview in the reportAction isn't showing up.

@allroundexperts
Copy link
Contributor Author

BTW, I just finished the API P.R. but there is 1 problem that I'm trying to figure out:

image

Clicking on the webp image to view it works fine! But the image preview in the reportAction isn't showing up.

Something might be wrong here:
https://github.com/allroundexperts/Expensify/blob/039db1fe75b1e2088f7a1997a935f66e7c928e51/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js#L11

However, this is just my guess. I can only test once the API changes are on staging. I've updated the PR with new code though.

@allroundexperts allroundexperts changed the title fix: added magic number validation for files fix: allow webp files on newdot Mar 17, 2023
@PauloGasparSv
Copy link
Contributor

Thks @allroundexperts, the problem was in the API side but that file helped me find it :D

I'm putting this on HOLD so we only merge this once the API P.R. is merged too! I already tested this on Web and will test on other platforms and sent the evidence here shortly.

@PauloGasparSv PauloGasparSv changed the title fix: allow webp files on newdot [HOLD Web-E #36814] fix: allow webp files on newdot Mar 17, 2023
@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Mar 22, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web image image
Mobile Web - Chrome image image
Mobile Web - Safari image image
Desktop image image
iOS image image
Android image image

Files I used to test - Download and use to test in iOS and Android

Pics.zip

@PauloGasparSv
Copy link
Contributor

This is off hold and can be merged :D
Filling the reviewer checklist here!

@PauloGasparSv PauloGasparSv changed the title [HOLD Web-E #36814] fix: allow webp files on newdot fix: allow webp files on newdot Mar 22, 2023
@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Mar 22, 2023

I want make sure there isn't a way around not showing webp previews to include here, so testing that while reviewing here.
I think they should be showing a preview just like gif files do.

image


UPDATE:

That is happening because of another repo code. This check should render the ImageView but Str.isImage doesn't return true for webp.

I'll update that in the expensify-common repo here!

@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Mar 22, 2023

That is happening because of another repo code. This check should render the ImageView but Str.isImage doesn't return true for webp.

I'll update that in the expensify-common repo here!

@allroundexperts would you mind if I put this on HOLD again until the Expensify-Common P.R. Expensify/expensify-common#512 is merged?

Then we can pull from main again and update the version of Expensify-Common in package-json (like here) making this P.R. able to show previews for webp files : )

@allroundexperts
Copy link
Contributor Author

That is happening because of another repo code. This check should render the ImageView but Str.isImage doesn't return true for webp.
I'll update that in the expensify-common repo here!

@allroundexperts would you mind if I put this on HOLD again until the Expensify-Common P.R. Expensify/expensify-common#512 is merged?

Then we can pull from main again and update the version of Expensify-Common in package-json (like here) making this P.R. able to show previews for webp files : )

Sure thing @PauloGasparSv. Why would I mind? 😆

@PauloGasparSv PauloGasparSv changed the title fix: allow webp files on newdot [HOLD Expensify-Common #512] fix: allow webp files on newdot Mar 22, 2023
@PauloGasparSv PauloGasparSv changed the title [HOLD Expensify-Common #512] fix: allow webp files on newdot fix: allow webp files on newdot Mar 23, 2023
@PauloGasparSv
Copy link
Contributor

The Expensify-Common P.R. Expensify/expensify-common#512 was merged!

@allroundexperts can you please update the Expensify-Common version in package.json to the latest commit (similar to here)?

- "expensify-common": "git+ssh://git@github.com/Expensify/expensify-common.git#ce6258b87396d3c471c9b012b9a518e2ee6283c7",
+ "expensify-common": "git+ssh://git@github.com/Expensify/expensify-common.git#9cf047b9741d3c02820d515dccb9e0a45b6595f5",

@allroundexperts
Copy link
Contributor Author

The Expensify-Common P.R. Expensify/expensify-common#512 was merged!

@allroundexperts can you please update the Expensify-Common version in package.json to the latest commit (similar to here)?

- "expensify-common": "git+ssh://git@github.com/Expensify/expensify-common.git#ce6258b87396d3c471c9b012b9a518e2ee6283c7",
+ "expensify-common": "git+ssh://git@github.com/Expensify/expensify-common.git#9cf047b9741d3c02820d515dccb9e0a45b6595f5",

Sure thing!

@allroundexperts
Copy link
Contributor Author

@PauloGasparSv Added latest expensify-common library!

Copy link
Contributor

@PauloGasparSv PauloGasparSv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

All yours @Santhosh-Sellavel

Files I used to test are in a Zip in the bottom of this comment if anyone needs it for testing iOS and Android

@Santhosh-Sellavel
Copy link
Collaborator

Will get it today!

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Mar 24, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Webp_web.mov
Mobile Web - Chrome
Screen_Recording_20230325_031807_Chrome.mp4
Mobile Web - Safari
mWeb_webp.mp4
Desktop
Webp_Desktop.mov
iOS
ios-webp.mp4
Android
Android_native_webp.mp4

@Santhosh-Sellavel
Copy link
Collaborator

@PauloGasparSv I see a few console warnings while adding attachments, this should be related to change but just for logging that we found adding this here, let me know your thoughts.

Check between 40th to 60th second in the below video for logs

Android_native_webp.mp4

@Santhosh-Sellavel
Copy link
Collaborator

Tested it out completely, LGTM mostly. But I ran into a weird case on iOS check the below video. While importing the pics you added for testing on the simulator Actual JPG, GIF, and Webp as JPG are treated as Images and got imported to Photos and webp is treated as doc got copied to files.

GIF & Actual JPEG from photos get uploaded successfully. But the webp as JPG is not getting picked via Photos.

Actual Webp & Webp as JPG can be uploaded successfully when picked via Files

ios-webp.mp4

Let me know if need to do something about this @PauloGasparSv

But the webp as JPG is not getting picked via Photos.

Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Mostly just few doubts!

@PauloGasparSv
Copy link
Contributor

@PauloGasparSv I see a few console warnings while adding attachments, this should be related to change but just for logging that we found adding this here, let me know your thoughts.

Thks @Santhosh-Sellavel, re-testing this to check that console error/warning!

Tested it out completely, LGTM mostly. But I ran into a weird case on iOS check the below video. While importing the pics you added for testing on the simulator Actual JPG, GIF, and Webp as JPG are treated as Images and got imported to Photos and webp is treated as doc got copied to files.

I think that's ok :D

@PauloGasparSv
Copy link
Contributor

Re-tested Web and couldn't see any warnings.

I'll test iOS again and merge this if no warnings show up : )

@PauloGasparSv
Copy link
Contributor

All right, couldn't replicate that warning so I'm going to merge this @Santhosh-Sellavel!

@PauloGasparSv PauloGasparSv merged commit 61234ac into Expensify:main Mar 27, 2023
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.2.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Santhosh-Sellavel
Copy link
Collaborator

Thanks @PauloGasparSv!

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.90-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants