fix/15625: Workspace name is not present in header on connect bank account page #16102

tienifr · 2023-03-19T06:21:49Z

Details

This PR will add the workspace name in the subtitle of the Connect bank account pages

Fixed Issues

$ #15625
PROPOSAL: #15625 (comment)

Tests

Open the app
Open any workspace
Open connect bank account
Verify that the workspace name is displayed on manual step page, start over page, error page, enable page (see the below screenshot for more detail)

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Open the app
Open any workspace
Open connect bank account
Verify that the workspace name is displayed on manual step page, start over page, error page, enable page (see the below screenshot for more detail)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Manual Step Page

Start Over Page

Error Page

Enable Page

Mobile Web - Chrome

Manual Step Page

Start Over Page

Error Page

Enable Page

Mobile Web - Safari

Manual Step Page

Start Over Page

Error Page

Enable Page

Desktop

Manual Step Page

Start Over Page

Error Page

Enable Page

iOS

Manual Step Page

Start Over Page

Error Page

Enable Page

Android

Manual Step Page

Start Over Page

Error Page

Enable Page

MelvinBot · 2023-03-22T01:39:38Z

@mountiny @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr

Nicely done on this PR @tienifr.

Just a couple of comments on the prop types.

mollfpr · 2023-03-22T15:37:20Z

src/pages/ReimbursementAccount/BankAccountStep.js

@@ -44,6 +44,9 @@ const propTypes = {
        /** Is the user account validated? */
        validated: PropTypes.bool,
    }),
+
+    /* The workspace name */
+    policyName: PropTypes.string.isRequired,


I don't think we need policyName to be required. The page still accessible without providing policyID to the route params.

@mollfpr I just removed required and add the default policyName in all places. Could you help to review again?

mollfpr · 2023-03-22T15:37:44Z

src/pages/ReimbursementAccount/ContinueBankAccountSetup.js

@@ -37,6 +36,9 @@ const propTypes = {
        name: PropTypes.string,
    }).isRequired,

+    /* The workspace name */
+    policyName: PropTypes.string.isRequired,


Same as the above.

mollfpr · 2023-03-22T15:37:58Z

src/pages/ReimbursementAccount/EnableStep.js

@@ -31,6 +32,9 @@ const propTypes = {
    /* Onyx Props */
    user: userPropTypes.isRequired,

+    /* The workspace name */
+    policyName: PropTypes.string.isRequired,


Same as the above.

mollfpr · 2023-03-22T17:40:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Bank Account New	Bank Account Start Over	Bank Account Enable	Bank Account Error

Mobile Web - Chrome

Bank Account New	Bank Account Start Over	Bank Account Enable	Bank Account Error

Mobile Web - Safari

Bank Account New	Bank Account Start Over	Bank Account Enable	Bank Account Error

Desktop

Bank Account New	Bank Account Start Over	Bank Account Enable	Bank Account Error

iOS

Bank Account New	Bank Account Start Over	Bank Account Enable	Bank Account Error

Android

Bank Account New	Bank Account Start Over	Bank Account Enable	Bank Account Error

mollfpr

Well done @tienifr and thanks for raising the PR quickly 👍

@mountiny Tests well and all yours.

tienifr · 2023-03-23T08:40:24Z

@mountiny Can you take a look at this PR and provide feedback?

mountiny · 2023-03-23T09:24:00Z

Yes, had to restart the PR reviewer checklist job.

mountiny

Thank you @tienifr and @mollfpr

OSBotify · 2023-03-23T09:29:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-24T19:06:17Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2023-03-25T13:41:20Z

@tienifr How to trigger that error page?

mountiny · 2023-03-26T11:24:52Z

@tienifr can you help with that?

@kavimuru even if you cant access it, I believe its same to assume this works for the error page if it works for the other pages too

kavimuru · 2023-03-26T12:10:01Z

@mountiny Yes it works in other pages.

tienifr · 2023-03-27T04:18:02Z

@kavimuru Sorry for my lateness. I see that there are 2 ways to access the error page

The field session.email has a value that ends with @expensify.sms

Field throttedDate in the reimbursementAccount field in ONYX has value

cc @mountiny @mollfpr

OSBotify · 2023-03-27T10:32:59Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: add subtitle into connect bank account screen

143757c

mountiny assigned tienifr Mar 21, 2023

tienifr marked this pull request as ready for review March 22, 2023 01:39

tienifr requested a review from a team as a code owner March 22, 2023 01:39

melvin-bot bot requested review from mollfpr and mountiny and removed request for a team March 22, 2023 01:39

tienifr mentioned this pull request Mar 22, 2023

[HOLD for payment 2023-04-03] [$1000] Workspace name is not present in header on connect bank account page #15625

Closed

6 tasks

mollfpr suggested changes Mar 22, 2023

View reviewed changes

fix: remove required and add default props for policy name

d7572a7

This comment was marked as duplicate.

Sign in to view

mollfpr approved these changes Mar 22, 2023

View reviewed changes

mountiny approved these changes Mar 23, 2023

View reviewed changes

mountiny merged commit fb90cd8 into Expensify:main Mar 23, 2023

OSBotify mentioned this pull request Mar 24, 2023

Deploy Checklist: New Expensify 2023-03-24 #16489

Closed

44 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix/15625: Workspace name is not present in header on connect bank account page #16102

fix/15625: Workspace name is not present in header on connect bank account page #16102

tienifr commented Mar 19, 2023 •

edited

Loading

MelvinBot commented Mar 22, 2023

mollfpr left a comment

mollfpr Mar 22, 2023

tienifr Mar 22, 2023 •

edited

Loading

mollfpr Mar 22, 2023

mollfpr Mar 22, 2023

mollfpr commented Mar 22, 2023

This comment was marked as duplicate.

mollfpr left a comment

tienifr commented Mar 23, 2023

mountiny commented Mar 23, 2023

mountiny left a comment

OSBotify commented Mar 23, 2023

OSBotify commented Mar 24, 2023

kavimuru commented Mar 25, 2023

mountiny commented Mar 26, 2023

kavimuru commented Mar 26, 2023

tienifr commented Mar 27, 2023

OSBotify commented Mar 27, 2023

fix/15625: Workspace name is not present in header on connect bank account page #16102

fix/15625: Workspace name is not present in header on connect bank account page #16102

Conversation

tienifr commented Mar 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 22, 2023

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr Mar 22, 2023

Choose a reason for hiding this comment

tienifr Mar 22, 2023 • edited Loading

Choose a reason for hiding this comment

mollfpr Mar 22, 2023

Choose a reason for hiding this comment

mollfpr Mar 22, 2023

Choose a reason for hiding this comment

mollfpr commented Mar 22, 2023

Reviewer Checklist

Screenshots/Videos

This comment was marked as duplicate.

mollfpr left a comment

Choose a reason for hiding this comment

tienifr commented Mar 23, 2023

mountiny commented Mar 23, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 23, 2023

OSBotify commented Mar 24, 2023

kavimuru commented Mar 25, 2023

mountiny commented Mar 26, 2023

kavimuru commented Mar 26, 2023

tienifr commented Mar 27, 2023

OSBotify commented Mar 27, 2023

tienifr commented Mar 19, 2023 •

edited

Loading

tienifr Mar 22, 2023 •

edited

Loading