Use a popup theme to style the picker on Android #16103

redstar504 · 2023-03-19T18:34:32Z

cc @shawnborton for style approval

Details

This PR introduces a popup theme for styling the picker background on Android. After some recent findings, I believe we should reopen the styling discussion.

In the issue thread, we agreed on using a theme that more closely matches the modals. As part of that discussion @shawnborton mentioned using a border. After further testing, I have identified a minor problem related to borders on a popup theme. When scrolling, the items overlap the border. Unfortunately this is not fixable through styling, but would require modifying the Picker source directly and adding ViewGroup.clipToPadding(true) which is not feasible.

This problem can be identified in the following video:

Border overlap issue

These examples are from a demo app where I could quickly iterate changes, which is why the items are not ones used in our app. This demonstration of the overlap issue uses a 6dp border:

em_border_overlap.mp4

There are a couple ways we could approach this. Since the modals in the app themselves do not use a border, I think we could get away without them. I think it looks great with just the font, card background color, and border radius, and it also solves the issue:

Popup theme without border

Another idea would be to use a thinner border which would make the overlap less obvious. Here are a couple examples of how it would look with narrower border widths:

Popup theme (2dp border)

Popup theme (4dp border)

Since having no border solves the issue and looks really good, I have included that version in this PR. If @shawnborton decides we should include the border despite the overlap issue, I can quickly add a commit for that.

Fixed Issues

$ #15460
PROPOSAL: #15460 (comment)

Tests

Picker Test

Launch the Android native app
Log in and navigate to a screen containing a picker
Open the picker and confirm that the picker has a green background
Confirm the picker has a border radius
Confirm the items are displayed with a white text color, in the Expensify Neue font.
Suggested: Run the app on a physical device to confirm the same functionality.

Example pickers used for testing:

Workspace > General Settings > Default currency
Workspace > Reimburse Expenses > Track Distance Unit
Workspace > Personal Details > Home Address > Country

DatePicker Test

Launch the Android native app
Log in and navigate to a screen containing a DatePicker
Open the datepicker and confirm the style matches the Android native screenshots in the PR.
Suggested: Run the app on a physical device to confirm the same functionality.

Date picker used for testing:

Workspace > Connect Bank Account > Connect Manually > Step 2 > Incorporation Date

Alert Test

Launch the Android native app
Log in and navigate to a screen that triggers an alert
Trigger the alert and confirm the style matches the Android native screenshots in the PR.
Suggested: Run the app on a physical device to confirm the same functionality.

Alerts used for testing:

Profile > Upload Profile Image > Deny Camera Access
Workspace > Upload Workspace Image > Deny Camera Access
Report > Download Attachment > Success
Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.2023-03-19.11.30.39.AM.webm

Mobile Web - Chrome

em_app_test_android_chrome.mp4

Mobile Web - Safari

border-ios-safari.mp4

Desktop

em_test_mac_desktop.mov

iOS

em_test_ios_native.mov

Android

Picker

DatePicker

Alert

MelvinBot · 2023-03-19T18:34:40Z

@chiragsalian @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane

@redstar504 Let's update the background color for DatePicker and Alerts as well.

shawnborton · 2023-03-20T18:06:00Z

I think it looks pretty good without the border, so that works for me.

redstar504 · 2023-03-20T18:36:08Z

I have added a commit with additional themes for the alert and date dialogs.

Here are a some screenshots to demonstrate how they look on both the emulator and a device.

Picker theme

Date theme

Alert theme

cc @shawnborton for style review

shawnborton · 2023-03-20T18:38:28Z

Do we have control over the color used to highlight the day, as well as "Cancel" below? If so, let's use green.

redstar504 · 2023-03-20T18:55:49Z

@shawnborton Does this work?

Screenshot

shawnborton · 2023-03-20T19:00:27Z

Looks great, thanks!

redstar504 · 2023-03-20T19:11:25Z

Commit for the recommended accent color is pushed.

sobitneupane

Screenshots/Videos

Android

Workspace > General Settings > Default currency

Workspace > Reimburse Expenses > Track Distance Unit

Settings > Personal Details > Home Address > Country

Add BankAccount > Company Information (step2) > State

Add BankAccount > Company Information (step2) > Company Type

DatePicker

Alert

Web

- Datepicker

Dropdown

Mobile Web - Chrome

Datepicker

Dropdown

Mobile Web - Safari

Datepicker

Dropdown

Desktop

Datepicker

Dropdown

iOS

- Datepicker

Dropdown

android/app/src/main/res/drawable/alert_background.xml

android/app/src/main/res/drawable/datepicker_background.xml

android/app/src/main/res/drawable/picker_background.xml

android/app/src/main/res/values/dimen.xml

sobitneupane

@redstar504 Please do include DatePicker and Alert in Test Steps as well..

situchan · 2023-03-21T10:10:27Z

One more case:

redstar504 · 2023-03-21T14:20:38Z

@sobitneupane Requested changes completed.

@situchan That case has already been accounted for.

situchan · 2023-03-21T14:24:34Z

@redstar504 great! I meant to add in test steps 🙂

redstar504 · 2023-03-21T14:28:49Z

@situchan Oh, yeah I have added those as well.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

OSBotify · 2023-03-22T16:40:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mvtglobally · 2023-03-24T18:51:08Z

@redstar504 @jsamr we need to QA this?

OSBotify · 2023-03-24T19:06:47Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.2.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-27T10:33:29Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Use a popupTheme to style Picker on Android

7a60bdb

redstar504 requested a review from a team as a code owner March 19, 2023 18:34

melvin-bot bot requested review from chiragsalian and sobitneupane and removed request for a team March 19, 2023 18:34

sobitneupane reviewed Mar 20, 2023

View reviewed changes

Add date and alert dialog themes

940e19f

Add accent color to dialog themes

c281ef3

sobitneupane reviewed Mar 21, 2023

View reviewed changes

Add newlines to EOFs

3a6bec0

sobitneupane approved these changes Mar 21, 2023

View reviewed changes

chiragsalian approved these changes Mar 22, 2023

View reviewed changes

chiragsalian merged commit 7393910 into Expensify:main Mar 22, 2023

OSBotify mentioned this pull request Mar 24, 2023

Deploy Checklist: New Expensify 2023-03-24 #16489

Closed

44 tasks

MelvinBot mentioned this pull request Mar 27, 2023

[HOLD for payment 2023-04-20] [$1000] General settings - Default currency - Background is lighter than the main one #15460

Closed

6 tasks

redstar504 mentioned this pull request Apr 6, 2023

Prevent ripple from overflowing Android picker #17063

Merged

55 tasks

situchan mentioned this pull request Dec 15, 2023

[HOLD for payment 2023-12-28][$500][Theme Switching] 🐛 Android - Track distance - The inscription in the pop-up window is hardly visible in light mode #33136

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use a popup theme to style the picker on Android #16103

Use a popup theme to style the picker on Android #16103

redstar504 commented Mar 19, 2023 •

edited

Loading

MelvinBot commented Mar 19, 2023

sobitneupane left a comment

shawnborton commented Mar 20, 2023

redstar504 commented Mar 20, 2023

shawnborton commented Mar 20, 2023

redstar504 commented Mar 20, 2023

shawnborton commented Mar 20, 2023

redstar504 commented Mar 20, 2023

sobitneupane left a comment

sobitneupane left a comment

situchan commented Mar 21, 2023

redstar504 commented Mar 21, 2023 •

edited

Loading

situchan commented Mar 21, 2023

redstar504 commented Mar 21, 2023

sobitneupane left a comment

OSBotify commented Mar 22, 2023

mvtglobally commented Mar 24, 2023

OSBotify commented Mar 24, 2023

OSBotify commented Mar 27, 2023

Use a popup theme to style the picker on Android #16103

Use a popup theme to style the picker on Android #16103

Conversation

redstar504 commented Mar 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Picker Test

DatePicker Test

Alert Test

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Picker

DatePicker

Alert

MelvinBot commented Mar 19, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

shawnborton commented Mar 20, 2023

redstar504 commented Mar 20, 2023

shawnborton commented Mar 20, 2023

redstar504 commented Mar 20, 2023

shawnborton commented Mar 20, 2023

redstar504 commented Mar 20, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane left a comment

Choose a reason for hiding this comment

situchan commented Mar 21, 2023

redstar504 commented Mar 21, 2023 • edited Loading

situchan commented Mar 21, 2023

redstar504 commented Mar 21, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

OSBotify commented Mar 22, 2023

mvtglobally commented Mar 24, 2023

OSBotify commented Mar 24, 2023

OSBotify commented Mar 27, 2023

redstar504 commented Mar 19, 2023 •

edited

Loading

redstar504 commented Mar 21, 2023 •

edited

Loading