Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass preferred locale to API on sign in #16326

Merged
merged 9 commits into from
Mar 24, 2023
Merged

Pass preferred locale to API on sign in #16326

merged 9 commits into from
Mar 24, 2023

Commits on Mar 20, 2023

  1. pass preferred locale to api on sign in

    @puneetlath
    puneetlath committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    9cd3d4d View commit details
    Browse the repository at this point in the history

  2. subscribe ValidateCodeForm to preferredLocale in onyx and pass when s… 

    …igning in
    @puneetlath
    puneetlath committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    beb1605 View commit details
    Browse the repository at this point in the history

  3. subscribe PasswordForm to preferredLocale in onyx and pass when signi… 

    …ng in
    @puneetlath
    puneetlath committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    db3a87d View commit details
    Browse the repository at this point in the history

  4. Only send the preferred locale to the api if its different than the d… 

    …efault
    @puneetlath
    puneetlath committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    13812f4 View commit details
    Browse the repository at this point in the history

  5. remove unncessary optimistic data

    @puneetlath
    puneetlath committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    30860b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. improve comment explanation

    @puneetlath
    puneetlath committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    3f8151c View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Only pass preferred locale when set

    @puneetlath
    puneetlath committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ed34ed6 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Always include preferredLocale from signin page

    @puneetlath
    puneetlath committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    5814fb8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into set-language-on-signin

    @puneetlath
    puneetlath committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ab35cfb View commit details
    Browse the repository at this point in the history