Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selected month while navigating to year list #16474

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/CalendarPicker/calendarPickerPropTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,28 @@ const propTypes = {
/** Default year to be set in the calendar picker. Used with navigation to set the correct year after going back to the view with calendar */
selectedYear: PropTypes.string,

/** Default month to be set in the calendar picker. Used to keep last selected month after going back to the view with calendar */
selectedMonth: PropTypes.number,

/** A function that is called when the date changed inside the calendar component */
onChanged: PropTypes.func,

/** A function called when the date is selected */
onSelected: PropTypes.func,

/** A function called when the year picker is opened */
onYearPickerOpen: PropTypes.func,
};

const defaultProps = {
value: new Date(),
minDate: moment().year(CONST.CALENDAR_PICKER.MIN_YEAR).toDate(),
maxDate: moment().year(CONST.CALENDAR_PICKER.MAX_YEAR).toDate(),
selectedYear: null,
selectedMonth: null,
onChanged: () => {},
onSelected: () => {},
onYearPickerOpen: () => {},
};

export {propTypes, defaultProps};
4 changes: 4 additions & 0 deletions src/components/CalendarPicker/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ class CalendarPicker extends React.PureComponent {
if (props.selectedYear) {
currentDateView = moment(currentDateView).set('year', props.selectedYear).toDate();
}
if (props.selectedMonth != null) {
currentDateView = moment(currentDateView).set('month', props.selectedMonth).toDate();
}
if (props.maxDate < currentDateView) {
currentDateView = props.maxDate;
} else if (props.minDate > currentDateView) {
Expand Down Expand Up @@ -68,6 +71,7 @@ class CalendarPicker extends React.PureComponent {
const maxYear = moment(this.props.maxDate).year();
const currentYear = this.state.currentDateView.getFullYear();
Navigation.navigate(ROUTES.getYearSelectionRoute(minYear, maxYear, currentYear, Navigation.getActiveRoute()));
this.props.onYearPickerOpen(this.state.currentDateView);
}

/**
Expand Down
13 changes: 13 additions & 0 deletions src/components/NewDatePicker/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@ class NewDatePicker extends React.Component {

this.state = {
isPickerVisible: false,
selectedMonth: null,
selectedDate: moment(props.value || props.defaultValue || undefined).toDate(),
};

this.setDate = this.setDate.bind(this);
this.showPicker = this.showPicker.bind(this);
this.hidePicker = this.hidePicker.bind(this);
this.setCurrentSelectedMonth = this.setCurrentSelectedMonth.bind(this);

this.opacity = new Animated.Value(0);

Expand Down Expand Up @@ -59,6 +61,15 @@ class NewDatePicker extends React.Component {
this.unsubscribeEscapeKey();
}

/**
* Updates selected month when year picker is opened.
* This is used to keep the last visible month in the calendar when going back from year picker screen.
* @param {Date} currentDateView
*/
setCurrentSelectedMonth(currentDateView) {
this.setState({selectedMonth: currentDateView.getMonth()});
}

/**
* Trigger the `onInputChange` handler when the user input has a complete date or is cleared
* @param {Date} selectedDate
Expand Down Expand Up @@ -149,7 +160,9 @@ class NewDatePicker extends React.Component {
maxDate={this.props.maxDate}
value={this.state.selectedDate}
onSelected={this.setDate}
selectedMonth={this.state.selectedMonth}
selectedYear={this.props.selectedYear}
onYearPickerOpen={this.setCurrentSelectedMonth}
/>
</Animated.View>
)
Expand Down