Make Compose box accessible before the chat loads #16705

getusha · 2023-03-29T19:42:22Z

Details

Fixed Issues

$ #14223
PROPOSAL: #14223 (comment)

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

Open any old chat or a chat that is still loading.
Type a message in the compose box.
Open EmojiPicker and insert an emoji
Send the message by clicking the send icon
Add any attachment and send, go to the compose box and click on the left "+" icon.
Confirm Sending, splitting, requesting money works as expected
Verify that the compose box is accessible and functioning properly as it would when the device is connected to the internet

QA Steps

Disconnect the device from the internet.
Open any old chat or a chat that is still loading.
Type a message in the compose box.
Open EmojiPicker and insert an emoji
Send the message by clicking the send icon
Add any attachment and send, go to the compose box and click on the left "+" icon.
Confirm Sending, splitting, requesting money works as expected
Verify that the compose box is accessible and functioning properly as it would when the device is connected to the internet

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-03-31.at.7.12.24.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-03-31.at.7.19.03.AM.mov

Mobile Web - Safari

Screen.Recording.2023-03-31.at.7.25.49.AM.mov

Desktop

Screen.Recording.2023-03-31.at.8.21.33.AM.mov

iOS

Screen-Recording-2023-03-31-at-9.1.mp4

Android

Screen-Recording-2023-03-31-at-8.1.mp4

MelvinBot · 2023-03-29T19:42:30Z

@techievivek @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane · 2023-03-30T09:31:34Z

@getusha Can you please add testing steps to cover other scenarios like adding emoji, performing IOU operations, sending attachments, etc while the report is still loading.

getusha · 2023-03-30T10:39:41Z

@sobitneupane updated, let me know if i need to add more.

sobitneupane

Screenshots/Videos

Web

test.mov

Mobile Web - Chrome

Screen.Recording.2023-03-30.at.16.16.56.mov

Mobile Web - Safari

Screen.Recording.2023-03-30.at.16.15.02.mov

Desktop

Untitled.mov

iOS

Screen.Recording.2023-03-30.at.16.04.44.mov

Android

Screen.Recording.2023-03-30.at.16.10.55.mov

sobitneupane · 2023-03-30T10:56:18Z

@sobitneupane updated, let me know if i need to add more.

Thanks @getusha
Can you also update the screen recordings covering the latest test steps.

getusha · 2023-03-30T12:27:20Z

Screenshots/Videos

Web

Screen.Recording.2023-03-30.at.4.00.08.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-03-30.at.4.13.48.AM.mov

Mobile Web - Safari

Screen.Recording.2023-03-30.at.4.24.44.AM.mov

Desktop

Screen.Recording.2023-03-30.at.4.29.20.AM.mov

iOS

Screen.Recording.2023-03-30.at.4.50.24.AM.1.mov

Android

Screen.Recording.2023-03-30.at.5.16.23.AM.mov

getusha · 2023-03-30T12:29:34Z

@sobitneupane Just updated the screen recordings.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

techievivek · 2023-03-31T11:12:22Z

@getusha There doesn't seem to be any video where we are switching from offline -> online or vice-versa, can you update the PR with video including those cases? Thanks

techievivek

The changes looks good to me, please add some videos transitioning from offline->online and vice-versa. Thanks

getusha · 2023-03-31T11:50:11Z

@techievivek are you suggesting switching from offline to online to show if the actions/message were successful?

getusha · 2023-03-31T11:52:32Z

Switching from online to offline to perform the actions while the chat loading is quite difficult since it will load the chat quickly and no longer showing the Skeleton view.

situchan · 2023-03-31T12:05:01Z

Switching from online to offline to perform the actions while the chat loading is quite difficult since it will load the chat quickly and no longer showing the Skeleton view.

This is easy to reproduce. Especially login with expensifail account which is high traffic on android with slow network

techievivek · 2023-03-31T12:19:14Z

@getusha

Switching from online to offline to perform the actions while the chat loading
Can you not throttle your network connection?

getusha · 2023-03-31T12:35:41Z

@situchan @techievivek thank you!
I will record the video and update performing the actions offline and making it online.
It seems like the backend is down, will update and let you know once it's back. 🙇

getusha · 2023-03-31T16:34:58Z

Screenshots/Videos

Web

Screen.Recording.2023-03-31.at.7.12.24.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-03-31.at.7.19.03.AM.mov

Mobile Web - Safari

Screen.Recording.2023-03-31.at.7.25.49.AM.mov

Desktop

Screen.Recording.2023-03-31.at.8.21.33.AM.mov

iOS

Screen-Recording-2023-03-31-at-9.1.mp4

Android

Screen-Recording-2023-03-31-at-8.1.mp4

getusha · 2023-03-31T16:37:03Z

@techievivek just updated with the recordings.
can we get this today? thank you!

techievivek

Looks good to me, thanks for the additional screen recordings.

OSBotify · 2023-03-31T23:51:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-03T19:27:54Z

🚀 Deployed to staging by https://github.com/techievivek in version: 1.2.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

johnmlee101 · 2023-04-04T16:02:30Z

Possible Regression: #16908

OSBotify · 2023-04-05T02:28:41Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.94-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

make compose box accessible before the chat loads

c28e0ea

getusha requested a review from a team as a code owner March 29, 2023 19:42

melvin-bot bot requested review from sobitneupane and techievivek and removed request for a team March 29, 2023 19:42

getusha mentioned this pull request Mar 29, 2023

[HOLD for payment 2023-04-12] [$4000] [Feature Request] Compose box should be accessible when opening a old chat #14223

Closed

6 tasks

sobitneupane reviewed Mar 30, 2023

View reviewed changes

sobitneupane approved these changes Mar 31, 2023

View reviewed changes

techievivek reviewed Mar 31, 2023

View reviewed changes

techievivek approved these changes Mar 31, 2023

View reviewed changes

techievivek merged commit 265f8bf into Expensify:main Mar 31, 2023

OSBotify mentioned this pull request Apr 3, 2023

Deploy Checklist: New Expensify 2023-04-03 #16880

Closed

21 tasks

situchan mentioned this pull request Apr 4, 2023

[HOLD for payment 2023-04-13] [HOLD for payment 2023-04-12] Composer hidden while showing skeleton after login #16908

Closed

6 tasks

kbecciv mentioned this pull request Apr 4, 2023

Chat - Unable to open emoji picker while offline #16913

Closed

6 tasks

mananjadhav mentioned this pull request Apr 4, 2023

show compose box before report is ready after logout #16922

Merged

55 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Compose box accessible before the chat loads #16705

Make Compose box accessible before the chat loads #16705

getusha commented Mar 29, 2023 •

edited

Loading

MelvinBot commented Mar 29, 2023

sobitneupane commented Mar 30, 2023

getusha commented Mar 30, 2023

sobitneupane left a comment

sobitneupane commented Mar 30, 2023

getusha commented Mar 30, 2023

getusha commented Mar 30, 2023

sobitneupane left a comment

techievivek commented Mar 31, 2023

techievivek left a comment

getusha commented Mar 31, 2023

getusha commented Mar 31, 2023

situchan commented Mar 31, 2023

techievivek commented Mar 31, 2023

getusha commented Mar 31, 2023

getusha commented Mar 31, 2023

getusha commented Mar 31, 2023

techievivek left a comment

OSBotify commented Mar 31, 2023

OSBotify commented Apr 3, 2023

johnmlee101 commented Apr 4, 2023

OSBotify commented Apr 5, 2023

Make Compose box accessible before the chat loads #16705

Make Compose box accessible before the chat loads #16705

Conversation

getusha commented Mar 29, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 29, 2023

sobitneupane commented Mar 30, 2023

getusha commented Mar 30, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane commented Mar 30, 2023

getusha commented Mar 30, 2023

Screenshots/Videos

getusha commented Mar 30, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

techievivek commented Mar 31, 2023

techievivek left a comment

Choose a reason for hiding this comment

getusha commented Mar 31, 2023

getusha commented Mar 31, 2023

situchan commented Mar 31, 2023

techievivek commented Mar 31, 2023

getusha commented Mar 31, 2023

getusha commented Mar 31, 2023

Screenshots/Videos

getusha commented Mar 31, 2023

techievivek left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 31, 2023

OSBotify commented Apr 3, 2023

johnmlee101 commented Apr 4, 2023

OSBotify commented Apr 5, 2023

getusha commented Mar 29, 2023 •

edited

Loading