-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] Add route for expensify lounge page #17393
Conversation
@mollfpr @AndrewGable One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
No C+ needed, just copy and route changes |
Reviewer Checklist
Screenshots/VideosWebN/A - Help site changes Mobile Web - ChromeN/A - Help site changes Mobile Web - SafariN/A - Help site changes DesktopN/A - Help site changes iOSN/A - Help site changes AndroidN/A - Help site changes |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.1-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀
|
Details
We added a file but forgot to add the route 🤦 This just adds a link to the file in the LHN. @maddylewis also made some copy and formatting changes to make it prettier!
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/272589
PROPOSAL: n/a
Tests
cd docs
bundle install
bundle exec jekyll serve
5. Click the Expensify Lounge article and make sure it opens this page
Offline tests
n/a
QA Steps
This is production QA, I will set a reminder for myself to test this.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android