Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #17694 to staging 🍒 #17728

Merged
merged 3 commits into from
Apr 20, 2023
Merged

🍒 Cherry pick PR #17694 to staging 🍒 #17728

merged 3 commits into from
Apr 20, 2023

Conversation

OSBotify
Copy link
Contributor

🍒 Cherry pick #17694 to staging 🍒

OSBotify and others added 2 commits April 20, 2023 17:30
@OSBotify
Merge pull request #17727 from Expensify/version-BUILD-E0826DEF-31B2-…
8d09d48 
…4EB2-B5E9-5DA7FCB0F3F3

Update version to 1.3.2-4 on main

(cherry picked from commit 1233024)
@mountiny @OSBotify
Merge pull request #17694 from Expensify/jasper-showArchivedRoomsNoPa…
1fa5b0e 
…rticipants

[NO QA] Show archived rooms without participants in the LHN

(cherry picked from commit 96575d4)
@OSBotify OSBotify requested a review from a team as a code owner April 20, 2023 17:30
@melvin-bot melvin-bot bot removed the request for review from a team April 20, 2023 17:30
@OSBotify
Copy link
Contributor Author

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

@mountiny mountiny requested a review from jasperhuangg April 20, 2023 17:38
@jasperhuangg jasperhuangg merged commit c31fbf8 into staging Apr 20, 2023
@jasperhuangg jasperhuangg deleted the OSBotify-cherry-pick-staging-17694 branch April 20, 2023 17:39
@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 1.3.2-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.2-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperhuangg jasperhuangg jasperhuangg approved these changes

Assignees

@mountiny mountiny

Labels
automerge Engineering Hourly KSv2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OSBotify @jasperhuangg @mountiny