Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #17988 to staging 🍒 #17990

Merged
merged 2 commits into from
Apr 25, 2023
Merged

🍒 Cherry pick PR #17988 to staging 🍒 #17990

merged 2 commits into from
Apr 25, 2023

Conversation

OSBotify
Copy link
Contributor

🍒 Cherry pick #17988 to staging 🍒

OSBotify and others added 2 commits April 25, 2023 20:54
@OSBotify
Merge pull request #17989 from Expensify/version-BUILD-00045E0B-6E7D-…
95c05bd 
…43D5-8EF2-ECAE15E63905

Update version to 1.3.5-6 on main

(cherry picked from commit c3a8ad9)
@OSBotify
Merge pull request #17988 from Expensify/jasper-fixUndefinedPersonalD…
439545d 
…etailsAccess

Fix undefined personal details access causing crash when calling getOptions

(cherry picked from commit 295f30e)
@OSBotify OSBotify requested a review from a team as a code owner April 25, 2023 20:54
@melvin-bot melvin-bot bot removed the request for review from a team April 25, 2023 20:54
@OSBotify OSBotify merged commit 6c4bca4 into staging Apr 25, 2023
@OSBotify OSBotify deleted the OSBotify-cherry-pick-staging-17988 branch April 25, 2023 20:54
@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.3.5-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.5-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OSBotify