Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IOU/Expense reportID for IOU actions #18856

Closed
wants to merge 7 commits into from

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented May 12, 2023

Add the IOU reportAction to the IOU/Expense report instead of the parent chatReport.

We are gonna start creating IOU reportActions directly in the IOU/Expense report and as part of the switch, we are temporarily skipping test so that Auth integration tests pass. The plan to make the switch is:

  1. Merge https://github.com/Expensify/Web-Expensify/pull/37375 and CP to prod
  2. Web-E Integrations tests in this https://github.com/Expensify/Auth/pull/7863 should pass
  3. Merge the https://github.com/Expensify/Auth/pull/7863
  4. Deploy the Auth PR
  5. Merge https://github.com/Expensify/Web-Expensify/pull/37337 that re-enables tests using the correct reportID
  6. CP the https://github.com/Expensify/Web-Expensify/pull/37337 PR to prod
  7. Merge Use IOU/Expense reportID for IOU actions #18856, CPing it to staging to minimize the amount of time IOUs are broken
  8. Run the bulkCQ from https://github.com/Expensify/Expensify/issues/282420 to change the reportID of all previous IOU actions

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/281893

Web Tests

Will be tested with the App PR

Mobile Tests

N/A

Automated Auth Tests

Updated tests

Query Timings/Plans

N/A

@luacmartins luacmartins self-assigned this May 12, 2023
@luacmartins luacmartins marked this pull request as ready for review May 12, 2023 18:52
@luacmartins luacmartins requested a review from a team as a code owner May 12, 2023 18:52
@melvin-bot melvin-bot bot requested review from marcochavezf and s77rt and removed request for a team May 12, 2023 18:53
@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

@s77rt @marcochavezf One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@luacmartins
Copy link
Contributor Author

Closing this in favor of #18604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant