fix: show correct copy to clipboard option for linked emails #19599

allroundexperts · 2023-05-25T11:14:36Z

Details

This PR fixes the copy to clipboard context menu message for linked emails.

Fixed Issues

$ #18912
PROPOSAL: #18912 (comment)

Tests

Open New Dot
Send an email linked to a URL message (e.g. [test@gmail.com](https://google.com) )
Right click on the message and verify that Copy URL to clipboard option appears instead of Copy Email to clipboard.
Send an URL linked to a email message (eg. [gmail.com](test@google.com))
Right click on the message and verify that Copy Email to clipboard option appears instead of Copy Url to clipboard.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open ND
Send an email linked to a URL (e.g. [test@gmail.com](https://google.com) )
Right click on the message and verify that Copy URL to clipboard option appears instead of Copy Email to clipboard.
Send an URL linked to a email message (eg. [gmail.com](test@google.com))
Right click on the message and verify that Copy Email to clipboard option appears instead of Copy Url to clipboard.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-05-25.at.3.47.21.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-25.at.3.58.54.PM.mov

Mobile Web - Safari

Screen.Recording.2023-05-25.at.3.57.18.PM.mov

Desktop

Screen.Recording.2023-05-25.at.3.53.37.PM.mov

iOS

Screen.Recording.2023-05-25.at.3.59.22.PM.mov

Android

Screen.Recording.2023-05-25.at.4.00.18.PM.mov

melvin-bot · 2023-05-25T11:14:42Z

@jasperhuangg @fedirjh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh

Changes looks good an test well . Left a minor suggestion

fedirjh · 2023-05-26T07:38:39Z

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.js

@@ -50,7 +50,9 @@ const BaseAnchorForCommentsOnly = (props) => {
            inline
            onSecondaryInteraction={(event) => {
                ReportActionContextMenu.showContextMenu(
-                    Str.isValidEmailMarkdown(props.displayName) ? ContextMenuActions.CONTEXT_MENU_TYPES.EMAIL : ContextMenuActions.CONTEXT_MENU_TYPES.LINK,
+                    props.href.indexOf('mailto:') === 0 && Str.isValidEmailMarkdown(props.displayName)


@allroundexperts shouldn’t we make text linked to emails to be copy email instead of copy link . Same we did for url links in this pr , I think we should consider the email links as well . What are your thoughts @jasperhuangg ?

[mail](test@gmail.com) // display copy email for this markdown as the link is a mail link ?

I think this is a small change and we can handle it in this PR. I'll wait for @jasperhuangg go ahead before adding it.

cc @jasperhuangg what’s your thoughts on #19599 (comment) ?

I agree, thanks for catching this!

@fedirjh Handled.

fedirjh · 2023-05-29T17:08:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Web.mov

Mobile Web - Chrome

Chrome.mov

Mobile Web - Safari

mWeb.Safari.mov

Desktop

Desktop.mov

iOS

IOS.mov

Android

Android.mov

fedirjh

LGTM and tests well

@allroundexperts Can we update the tests to include emails linked to text ?

allroundexperts · 2023-05-29T18:13:45Z

LGTM and tests well

@allroundexperts Can we update the tests to include emails linked to text ?

@fedirjh Updated.

fedirjh · 2023-05-29T18:17:43Z

cc @jasperhuangg All yours

OSBotify · 2023-05-30T04:14:59Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.20-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-31T16:34:24Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.20-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: show correct copy to clipboard option for linked emails

8dcaa23

allroundexperts requested a review from a team as a code owner May 25, 2023 11:14

melvin-bot bot requested review from fedirjh and jasperhuangg and removed request for a team May 25, 2023 11:14

allroundexperts mentioned this pull request May 25, 2023

[$1000] Misleading right-click on email linked to URL #18912

Closed

6 tasks

fedirjh reviewed May 26, 2023

View reviewed changes

fix: show context menu with email option based on message href

2b1e825

allroundexperts force-pushed the fix-18912 branch from cce6b31 to 2b1e825 Compare May 29, 2023 09:10

fedirjh approved these changes May 29, 2023

View reviewed changes

jasperhuangg approved these changes May 30, 2023

View reviewed changes

jasperhuangg merged commit c324885 into Expensify:main May 30, 2023

OSBotify mentioned this pull request May 30, 2023

Deploy Checklist: New Expensify 2023-05-29 #19785

Closed

44 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: show correct copy to clipboard option for linked emails #19599

fix: show correct copy to clipboard option for linked emails #19599

allroundexperts commented May 25, 2023 •

edited

Loading

melvin-bot bot commented May 25, 2023

fedirjh left a comment

fedirjh May 26, 2023

allroundexperts May 26, 2023

fedirjh May 28, 2023

jasperhuangg May 29, 2023

allroundexperts May 29, 2023

fedirjh commented May 29, 2023

fedirjh left a comment

allroundexperts commented May 29, 2023

fedirjh commented May 29, 2023

OSBotify commented May 30, 2023

OSBotify commented May 31, 2023

fix: show correct copy to clipboard option for linked emails #19599

fix: show correct copy to clipboard option for linked emails #19599

Conversation

allroundexperts commented May 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 25, 2023

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh May 26, 2023

Choose a reason for hiding this comment

allroundexperts May 26, 2023

Choose a reason for hiding this comment

fedirjh May 28, 2023

Choose a reason for hiding this comment

jasperhuangg May 29, 2023

Choose a reason for hiding this comment

allroundexperts May 29, 2023

Choose a reason for hiding this comment

fedirjh commented May 29, 2023

Reviewer Checklist

Screenshots/Videos

fedirjh left a comment

Choose a reason for hiding this comment

allroundexperts commented May 29, 2023

fedirjh commented May 29, 2023

OSBotify commented May 30, 2023

OSBotify commented May 31, 2023

allroundexperts commented May 25, 2023 •

edited

Loading