Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #16696] Rewrite BaseTextInput to function component #20186

Merged
merged 32 commits into from
Jul 3, 2023
Merged

[Fix #16696] Rewrite BaseTextInput to function component #20186

Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
7804df2
initial rewrite of BaseTextInput to FC
hannojg Jun 5, 2023
880c4c0
fix focus/label not working
hannojg Jun 5, 2023
36eb6eb
remove comment
hannojg Jun 6, 2023
bd6cef7
fix text input focus
hannojg Jun 6, 2023
519b192
fix focus
hannojg Jun 6, 2023
c26fdb9
fix usage of useCallback
hannojg Jun 7, 2023
7a3f3f3
remove todo
hannojg Jun 12, 2023
4fa3821
Merge branch 'main' of github.com:margelo/expensify-app-fork into cho…
hannojg Jun 12, 2023
3886aaf
use named import directly
hannojg Jun 12, 2023
0e43599
use function directly
hannojg Jun 12, 2023
21ded8c
only autoFocus on mount
hannojg Jun 12, 2023
68ee867
use stylesheet flatten
hannojg Jun 12, 2023
86dea8c
Update src/components/TextInput/BaseTextInput.js
hannojg Jun 12, 2023
71fb82c
Update src/components/TextInput/BaseTextInput.js
hannojg Jun 12, 2023
528d63e
Update src/components/TextInput/BaseTextInput.js
hannojg Jun 12, 2023
43c1125
fix useEffect
hannojg Jun 12, 2023
ba629db
useRef for stable values
hannojg Jun 12, 2023
0a756fc
use defaultValue as well
hannojg Jun 12, 2023
7d1cb48
removed unnecessary condition
hannojg Jun 13, 2023
553111e
beautify code order
hannojg Jun 13, 2023
d0ba803
Merge branch 'main' of github.com:margelo/expensify-app-fork into cho…
hannojg Jun 17, 2023
511c5b6
fix default value
hannojg Jun 17, 2023
682ad7e
fix stories
hannojg Jun 17, 2023
1d4ee14
Merge branch 'main' of github.com:margelo/expensify-app-fork into cho…
hannojg Jun 20, 2023
dc5a7f0
fix update label
hannojg Jun 20, 2023
05af49e
add max width
hannojg Jun 20, 2023
7c52921
prettier
hannojg Jun 20, 2023
25ca03b
make ref usage more explanatory
hannojg Jun 21, 2023
b11715b
Merge branch 'main' of github.com:margelo/expensify-app-fork into cho…
hannojg Jul 2, 2023
8db7706
Repeat: https://github.com/Expensify/App/commit/f71a1f7c8bda15eab014f…
hannojg Jul 2, 2023
74dc4d0
Repeat: https://github.com/Expensify/App/commit/a63eee4b177d4f57754ba…
hannojg Jul 2, 2023
3b6900c
Update src/components/TextInput/BaseTextInput.js
hannojg Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading