Add tooltips and nav to bill details #20746

esh-g · 2023-06-14T12:19:11Z

Details

Fixed Issues

$ #20052
PROPOSAL: #20052 (comment)

Tests

Go to a group chat
Click on split bill in the '+' icon
Enter any amount and complete the split
Open the split bill detail by clicking on the preview
Verify that tooltips are visible for each participant.
Click on any participant
Verify that the details page of the participant is visible.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to a group chat
Click on split bill in the '+' icon
Enter any amount and complete the split
Open the split bill detail by clicking on the preview
Make sure that tooltips are visible for each participant.
Click on any participant
Verify that the details page of the participant is visible.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-14.at.3.14.33.PM-2.mov

Mobile Web - Chrome

androind-chrome.mp4

Mobile Web - Safari

Screen.Recording.2023-06-14.at.4.38.44.PM.mov

Desktop

Screen.Recording.2023-06-14.at.4.03.40.PM-1.mov

iOS

Screen.Recording.2023-06-14.at.4.27.22.PM.mov

Android

Screen.Recording.2023-06-14.at.4.55.43.PM.mov

melvin-bot · 2023-06-14T12:19:16Z

@cristipaval @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

esh-g · 2023-06-14T19:59:02Z

@eVoloshchak @cristipaval Please do let me know if you would like to keep the navigation to detail page as well 😇

eVoloshchak · 2023-06-15T13:10:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-15.at.19.02.50.mov

Mobile Web - Chrome

screen-20230615-190631.mp4

Mobile Web - Safari

Screen.Recording.2023-06-15.at.19.07.42.mov

Desktop

Screen.Recording.2023-06-15.at.19.06.51.mov

iOS

Screen.Recording.2023-06-15.at.19.08.37.mov

Android

screen-20230615-190514.mp4

eVoloshchak

@esh-g, everything looks good to me, one small correction, it should navigate to profile page instead of details page

To be consistent with ReportParticipantsPage we can use ROUTES.getReportParticipantRoute

esh-g · 2023-06-15T13:52:41Z

@eVoloshchak Actually for that we would have to pass a reportID to it for which report we want to get the participant, but since we are using this component for things like request money, send money, etc as well, that report will not always be present. Moreover it requires accountID which I think is different from option.login. We are already using the details page to display the user details when the mention of a user is clicked. But still if you would like me to have the reportPartticipantsPage, do let me know!

eVoloshchak · 2023-06-15T13:56:49Z

It's inconsistent with the details page you get when you press on a header. It opens the profile page, while we open details page, but the pages look the same, only the title is different

Screen.Recording.2023-06-15.at.16.54.29.mov

esh-g · 2023-06-15T14:01:41Z

@eVoloshchak Okay, I'll add the reportParticipantPage. Here's just a head's up that we will not be able to navigate to the reportParticipantPage while sending/requesting money. Or would you want to direct the user to the details page while sending/requesting?

Screen.Recording.2023-06-15.at.7.29.14.PM.mov

esh-g · 2023-06-15T14:14:34Z

@eVoloshchak I think I found a solution that fixes both problems. We can use ROUTES.getProfileRoute() which is not dependent upon any report and is exactly the same! Let me know if this looks good.

Screen.Recording.2023-06-15.at.7.40.55.PM.mov

esh-g · 2023-06-15T15:26:13Z

@eVoloshchak Should I push the commit to replace details with profile page?

eVoloshchak · 2023-06-15T15:28:00Z

I think I found a solution that fixes both problems. We can use ROUTES.getProfileRoute() which is not dependent upon any report and is exactly the same! Let me know if this looks good.

Awesome, looks good. Yeah, push the commit

esh-g · 2023-06-15T15:31:06Z

@eVoloshchak Successfully pushed the commit 🚀

esh-g · 2023-06-15T15:44:00Z

@eVoloshchak Are there any further concerns?

src/components/MoneyRequestConfirmationList.js

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

eVoloshchak

Looks good to me
cc: @cristipaval

OSBotify · 2023-06-15T16:35:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-16T18:51:13Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

esh-g · 2023-06-16T19:16:01Z

@eVoloshchak @cristipaval
There is a bug on staging

Screen.Recording.2023-06-17.at.12.45.02.AM.mov

esh-g · 2023-06-16T19:28:55Z

@eVoloshchak @cristipaval
I think this happened due to the recent changes in accountID and login. This PR relies on ReportUtils.getAccountIDForLogin function which was not modified in this PR. So I would say this was not a regression of this PR. Rather, it was a regression of the PR that introduced this function because the MultipleAvatars tooltips also relies on this method and they are broken.

Screen.Recording.2023-06-17.at.12.55.56.AM.mov

esh-g · 2023-06-16T19:44:32Z

Commented on the offending PR here: #20276 (comment)

esh-g · 2023-06-16T20:17:43Z

This will get fixed automatically when #20934 is fixed.

OSBotify · 2023-06-21T02:18:43Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sobitneupane · 2023-08-21T06:52:41Z

This case (new participant with no user details) was not considered in this PR causing the regression. It was resolved by this PR.

Add tooltips and nav to bill details

685169c

esh-g requested a review from a team as a code owner June 14, 2023 12:19

melvin-bot bot requested review from cristipaval and eVoloshchak and removed request for a team June 14, 2023 12:19

esh-g mentioned this pull request Jun 14, 2023

[HOLD for payment 2023-06-28] [$1000] Web - Details - Tooltip not present on split bill details side panel #20052

Closed

6 tasks

eVoloshchak suggested changes Jun 15, 2023

View reviewed changes

esh-g requested a review from eVoloshchak June 15, 2023 13:56

DetailsPage -> ProfilePage

511c200

eVoloshchak suggested changes Jun 15, 2023

View reviewed changes

src/components/MoneyRequestConfirmationList.js Outdated Show resolved Hide resolved

Ammend comment detail -> profile

b100ee4

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

eVoloshchak approved these changes Jun 15, 2023

View reviewed changes

cristipaval approved these changes Jun 15, 2023

View reviewed changes

cristipaval merged commit ab3886b into Expensify:main Jun 15, 2023

OSBotify mentioned this pull request Jun 16, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

esh-g mentioned this pull request Jun 16, 2023

Cloudpresser/user details tooltip #20276

Merged

71 tasks

allroundexperts mentioned this pull request Jun 29, 2023

[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] [$1000] Search - Group chat displays blank in Search results #21127

Closed

6 tasks

sobitneupane mentioned this pull request Aug 21, 2023

[HOLD for checklist][$1000] Web - 'Hmm... it's not here' page is displayed on visiting profile of new user during request money #22691

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tooltips and nav to bill details #20746

Add tooltips and nav to bill details #20746

esh-g commented Jun 14, 2023

melvin-bot bot commented Jun 14, 2023

esh-g commented Jun 14, 2023 •

edited

Loading

eVoloshchak commented Jun 15, 2023 •

edited

Loading

eVoloshchak left a comment

esh-g commented Jun 15, 2023

eVoloshchak commented Jun 15, 2023

esh-g commented Jun 15, 2023 •

edited

Loading

esh-g commented Jun 15, 2023

esh-g commented Jun 15, 2023

eVoloshchak commented Jun 15, 2023

esh-g commented Jun 15, 2023

esh-g commented Jun 15, 2023

eVoloshchak left a comment

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

esh-g commented Jun 16, 2023 •

edited

Loading

esh-g commented Jun 16, 2023

esh-g commented Jun 16, 2023

esh-g commented Jun 16, 2023

OSBotify commented Jun 21, 2023

sobitneupane commented Aug 21, 2023

Add tooltips and nav to bill details #20746

Add tooltips and nav to bill details #20746

Conversation

esh-g commented Jun 14, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 14, 2023

esh-g commented Jun 14, 2023 • edited Loading

eVoloshchak commented Jun 15, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

esh-g commented Jun 15, 2023

eVoloshchak commented Jun 15, 2023

esh-g commented Jun 15, 2023 • edited Loading

esh-g commented Jun 15, 2023

esh-g commented Jun 15, 2023

eVoloshchak commented Jun 15, 2023

esh-g commented Jun 15, 2023

esh-g commented Jun 15, 2023

eVoloshchak left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

esh-g commented Jun 16, 2023 • edited Loading

esh-g commented Jun 16, 2023

esh-g commented Jun 16, 2023

esh-g commented Jun 16, 2023

OSBotify commented Jun 21, 2023

sobitneupane commented Aug 21, 2023

esh-g commented Jun 14, 2023 •

edited

Loading

eVoloshchak commented Jun 15, 2023 •

edited

Loading

esh-g commented Jun 15, 2023 •

edited

Loading

esh-g commented Jun 16, 2023 •

edited

Loading