2FA Input field not focused on mobile #20891

WikusKriek · 2023-06-16T08:52:28Z

Details

2FA did not focus on mobile, created a new resetFocus handler that sets intput, this will focus hte magic code input.

Fixed Issues

$ #19711
PROPOSAL: #19711 (comment)

Tests

You need to have two factor auth enabled on your account to test this issue, if two factor authentication is not enabled go to settings/security/Two-factor authentication to enable it.
Sign out of your account.
Input email for account from the precondition
Click "Continue"
Input magic code
Click "Continue"
Two-factor authentication input should be focused.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Test Steps

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

MacOS.Chrome.2023-06-16.at.12.39.08.mov

Mobile Web - Chrome

Android.Chrome.2023-06-16.at.12.13.21.mov

Mobile Web - Safari

IOS.safari.2023-06-16.at.12.24.29.mov

Desktop

MacOS.Desktop.2023-06-16.at.12.42.48.mov

iOS

IOS.Native.2023-06-16.at.12.21.53.mov

Android

Android.2023-06-16.at.12.08.50.mov

melvin-bot · 2023-06-16T11:04:19Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-06-16T11:14:35Z

src/components/MagicCodeInput.js

@@ -111,6 +111,11 @@ function MagicCodeInput(props) {
            setFocusedIndex(0);
            inputRefs.current[0].focus();
        },
+        resetFocus() {
+            setInput('');
+            setFocusedIndex(0);


Instead of below 2 lines we can directly call focus() to avoid duplicate code

@abdulrahuman5196 It will look something like this then. I am not able to call one handler through the other in useImperativeHandle. Or in the same component without extracting to an outside function like blur.

@WikusKriek This seems to be fine IMO if we are unable to call within imperative functions, compared to having duplicate code. We can name it as focusMagicCodeInput similar to blur

Made the changes.

abdulrahuman5196 · 2023-06-16T14:29:39Z

src/components/MagicCodeInput.js

@@ -111,6 +111,11 @@ function MagicCodeInput(props) {
            setFocusedIndex(0);
            inputRefs.current[0].focus();
        },
+        resetFocus() {
+            setInput('');
+            setFocusedIndex(0);


@WikusKriek This seems to be fine IMO if we are unable to call within imperative functions, compared to having duplicate code. We can name it as focusMagicCodeInput similar to blur

abdulrahuman5196 · 2023-06-17T09:09:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Untitled.47.mp4

Mobile Web - Chrome

Untitled.46.mp4

Mobile Web - Safari

Untitled.48.mp4

Desktop

Untitled.50.mp4

iOS

Untitled.49.mp4

Android

Untitled.51.mp4

abdulrahuman5196 · 2023-06-17T09:23:35Z

Note: this PR isn't expected to fix issue in mWeb safari since focusing itself is broken in multiple place on mweb safari and its tackled as part of this #10414

abdulrahuman5196

The changes looks good and works well. Reviewers checklist is also complete.

All yours. @luacmartins

🎀👀🎀
C+ Reviewed

abdulrahuman5196 · 2023-06-20T12:34:35Z

@luacmartins This PR is pending on your approval. Kindly check on this.

luacmartins · 2023-06-20T15:25:22Z

@abdulrahuman5196 thanks for the ping. I completely missed this one!

OSBotify · 2023-06-20T15:28:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

WikusKriek · 2023-06-20T15:39:54Z

@abdulrahuman5196 thanks for the ping. I completely missed this one!

@luacmartins the PR was still merged within 3 days, excluding weekends? According to the bot in this comment it was not.

abdulrahuman5196 · 2023-06-20T15:51:06Z

@WikusKriek Melvin's comment was wrong actually. I pinged in the issue itself - #19711 (comment)

OSBotify · 2023-06-21T02:26:40Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-22T16:54:18Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.30-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: 2FA Input field not focused on mobile

2eef682

WikusKriek mentioned this pull request Jun 16, 2023

[HOLD for payment 2023-06-29] [$2000] Web - Login - 2FA Input field not focused when proceed from magic code page #19711

Closed

6 tasks

WikusKriek marked this pull request as ready for review June 16, 2023 11:04

WikusKriek requested a review from a team as a code owner June 16, 2023 11:04

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team June 16, 2023 11:04

abdulrahuman5196 suggested changes Jun 16, 2023

View reviewed changes

feat: focusMagicCodeInput function

7f8907f

WikusKriek requested a review from abdulrahuman5196 June 16, 2023 15:19

abdulrahuman5196 approved these changes Jun 17, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins June 17, 2023 09:38

luacmartins approved these changes Jun 20, 2023

View reviewed changes

luacmartins merged commit 93042af into Expensify:main Jun 20, 2023

OSBotify mentioned this pull request Jun 21, 2023

Deploy Checklist: New Expensify 2023-06-21 #21172

Closed

67 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2FA Input field not focused on mobile #20891

2FA Input field not focused on mobile #20891

WikusKriek commented Jun 16, 2023 •

edited

Loading

melvin-bot bot commented Jun 16, 2023

abdulrahuman5196 Jun 16, 2023

WikusKriek Jun 16, 2023 •

edited

Loading

abdulrahuman5196 Jun 16, 2023

WikusKriek Jun 16, 2023

abdulrahuman5196 Jun 16, 2023

abdulrahuman5196 commented Jun 17, 2023 •

edited

Loading

abdulrahuman5196 commented Jun 17, 2023

abdulrahuman5196 left a comment

abdulrahuman5196 commented Jun 20, 2023 •

edited

Loading

luacmartins commented Jun 20, 2023

OSBotify commented Jun 20, 2023

WikusKriek commented Jun 20, 2023

abdulrahuman5196 commented Jun 20, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 22, 2023

2FA Input field not focused on mobile #20891

2FA Input field not focused on mobile #20891

Conversation

WikusKriek commented Jun 16, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 16, 2023

abdulrahuman5196 Jun 16, 2023

Choose a reason for hiding this comment

WikusKriek Jun 16, 2023 • edited Loading

Choose a reason for hiding this comment

abdulrahuman5196 Jun 16, 2023

Choose a reason for hiding this comment

WikusKriek Jun 16, 2023

Choose a reason for hiding this comment

abdulrahuman5196 Jun 16, 2023

Choose a reason for hiding this comment

abdulrahuman5196 commented Jun 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 commented Jun 17, 2023

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Jun 20, 2023 • edited Loading

luacmartins commented Jun 20, 2023

OSBotify commented Jun 20, 2023

WikusKriek commented Jun 20, 2023

abdulrahuman5196 commented Jun 20, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 22, 2023

WikusKriek commented Jun 16, 2023 •

edited

Loading

WikusKriek Jun 16, 2023 •

edited

Loading

abdulrahuman5196 commented Jun 17, 2023 •

edited

Loading

abdulrahuman5196 commented Jun 20, 2023 •

edited

Loading