Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Rename master to main in E.cash #2092

Merged
merged 3 commits into from
Apr 15, 2021
Merged

[No QA] Rename master to main in E.cash #2092

merged 3 commits into from
Apr 15, 2021

Conversation

roryabraham
Copy link
Contributor

cc @rafecolton because we'll want to merge this right after you rename master to main in E.cash to prevent broken deploys.

Details

Renames the master branch to main in all our E.cash documentation and CI/CD Github Workflows.

Fixed Issues

Fixes (partial) https://github.com/Expensify/Expensify/issues/158454

Tests

Marked as No QA because we'll know if it doesn't work because deploys will break.

  1. Rename master branch to main in Expensify.cash repo
  2. Merge this PR
  3. Monitor, make sure deploys are happening normally.

Tested On

n/a - Test on github

@roryabraham roryabraham self-assigned this Mar 25, 2021
@roryabraham roryabraham requested a review from a team as a code owner March 25, 2021 22:48
@botify botify requested review from nickmurray47 and removed request for a team March 25, 2021 22:48
nickmurray47
nickmurray47 previously approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

johnmlee101
johnmlee101 previously approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

AndrewGable
AndrewGable previously approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@AndrewGable AndrewGable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge when off hold.

@rafecolton
Copy link
Member

cc @justinpersaud since it looks like you are assigned to the rename issue (https://github.com/Expensify/Expensify/issues/158705)

@roryabraham
Copy link
Contributor Author

Had to make some minor updates after merging master. Hoping to get this done today

@roryabraham roryabraham merged commit 431b60d into main Apr 15, 2021
@roryabraham roryabraham deleted the Rory-UpdateMasterToMain branch April 15, 2021 17:48
@roryabraham roryabraham changed the title [HOLD] [No QA] Rename master to main in E.cash [No QA] Rename master to main in E.cash Apr 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@OSBotify OSBotify mentioned this pull request Apr 15, 2021
Closed
66 tasks
@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmlee101 johnmlee101 johnmlee101 approved these changes

@AndrewGable AndrewGable Awaiting requested review from AndrewGable

@nickmurray47 nickmurray47 Awaiting requested review from nickmurray47

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@roryabraham @rafecolton @OSBotify @AndrewGable @johnmlee101 @nickmurray47