fix offline deleted heading link style and link padding #20996

Nikhil-Vats · 2023-06-18T17:57:50Z

Details

Fixes the following issues -

Deleted heading links in offline mode look like underline and not strikethrough.
Header links had extra padding on top.
Internal links didn't have cursor pointer (a regression that was found during previous PR).

Fixed Issues

$ #18658
$ #17488
$ #18658 (comment)

Tests

For testing #17488 (padding above header links) -

Open the app in Chrome/safari on your desktop.
Open a chat.
Send any link as header text. eg: # google.com
Verify that there is no extra padding above links and that links are only clickable (with the cursor as a pointer) when the cursor is over the text not above it.

You can also follow the same steps on the desktop app on MacOS to verify that it is working successfully there as well.

For testing #16526 (cursor shown in empty space for links that span multiple lines) -

Post a long hyperlink as a comment.
e.g link : Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer ornare dignissim nunc, eleifend molestie dui tempus non. Proin semper eu metus sit amet feugiat. Sed turpis augue, pellentesque sed accumsan ornare, malesuada in ligula. Aliquam porta condimentum varius. Morbi id lorem felis.
Hover over the hyperlink after posting the comment.
On web and desktop platforms pointer cursor should be shown only when the mouse cursor is over the hyperlink and not when it is over the empty space near the line endings.
Regular cursor should be shown while hovering over the empty area next to the hyperlink.
On other platforms, the comment should be shown exactly as it was rendered earlier.
All other comment types should render exactly the same as before.
Same behaviour is applicable for links posted as a reply to a comment via email.

For testing #20669 (cursor is not pointer for internal links) -

Send a message with any internal link like - staging.new.expensify.com/settings/shareCode.
Hover over the link and verify that the cursor is pointer for internal links.

Verify that no errors appear in the JS console

Offline tests

Issue #18658 must be tested in offline mode. Follow the steps below -

Open the app in Chrome on your desktop.
Go to a chat and add a heading comment. eg: # Example
Go offline by switching off the connection.
Delete the message.
Verify that the message is shown with a strikethrough style (line over the message) and not underlined.

Note -

Repeat the steps above for the following messages (feel free to add more) -
Messages are separated by a new empty line.

# text header

# header with link.com

# header with emoji 😇

# 😇😇

> # header inside quote with [link](google.com)

`# try header in code`

\```
multiline code (remove \ before three backticks above and below)
😅
link.com
\```

😋😆😇😇

[normal link](google.com)

Also repeat the steps for different attachments - images, PDFs, files without preview like CSVs, docs. Upload them in online mode, go offline and delete them.
a. After deleting attachments like images, PDFs, GIFs which have preview, their opacity should decrease and user should not be able to open them.
b. For attachments without previews like CSV, docs, etc. A strikethrough should be shown similar to text comments.
Add any attachments in offline mode. App should keep showing "Uploading attachment...". Delete the attachment. App should show a strikethrough over the text.

You can test this behaviour on a mobile browser, desktop browser, MacOS desktop app, iOS app, android app, etc using the same steps.

QA Steps

Follow the same steps listed in the sections above. Expand this to see the same steps.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

chrome.mov

Mobile Web - Chrome

mWeb.chrome.mov

Mobile Web - Safari

mWeb.ios.mov

Desktop

18658_desktop.mov

iOS

18658_ios.mov

Android

android.mov

melvin-bot · 2023-06-18T17:57:55Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Nikhil-Vats · 2023-06-18T18:04:41Z

@cristipaval @mollfpr @twisterdotcom PR is up. Ready for review.

mollfpr · 2023-06-20T15:00:11Z

Will test this PR tomorrow morning 🙏

mollfpr · 2023-06-21T12:08:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

20996.Web.1.mp4

20996.Web.2.mp4

20996.Web.3.mp4

20996.Web.4.mp4

Mobile Web - Chrome

20996.mWeb.Chrome.webm

Mobile Web - Safari

20996.mWeb-Safari.1.mp4

20996.mWeb-Safari.2.mp4

Desktop

20996.Desktop.1.mov

20996.Desktop.2.mov

20996.Desktop.3.mov

iOS

20996.iOS.1.mp4

20996.iOS.2.mp4

Android

20996.Android.mp4

mollfpr · 2023-06-21T12:33:05Z

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.js

@@ -68,7 +70,7 @@ function BaseAnchorForCommentsOnly(props) {
            <Tooltip text={props.href}>
                <Text
                    ref={(el) => (linkRef = el)}
-                    style={StyleSheet.flatten([props.style, defaultTextStyle])}
+                    style={StyleSheet.flatten([props.style, defaultTextStyle, styles.cursorPointer])}


@Nikhil-Vats I got a warning on the native app regarding the cursor style.

@mollfpr fixed!

mollfpr

LGTM 👍

Nikhil-Vats · 2023-06-21T18:46:59Z

Hey @cristipaval you were not added as a reviewer here, so can you add yourself?

OSBotify · 2023-06-21T19:46:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-22T17:21:20Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.31-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins · 2023-06-23T19:53:36Z

This PR seems to be failing QA. I'm not gonna block the deploy on this since it's a cosmetic change that doesn't impact app functionality. @amyevans @cristipaval could you please check if this is indeed failing?

OSBotify · 2023-06-23T21:06:13Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-23T21:25:58Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

amyevans · 2023-06-26T14:04:37Z

Not sure why it was marked as failing QA, it passed for me on staging in my testing:

Nikhil-Vats · 2023-06-26T19:31:09Z

I have also tested and the issues mentioned in the comment are not applicable.
#21393 is not caused by this PR (the functionality was tested during this PR and we can see in test proofs). Also, the PR for that issue shows the root cause and it was not changed in this PR.
#18658 is the issue that this PR is fixing

fix offline deleted heading link style

e20cc46

Nikhil-Vats requested a review from a team as a code owner June 18, 2023 17:57

melvin-bot bot requested review from 0xmiros and removed request for a team June 18, 2023 17:57

amyevans mentioned this pull request Jun 20, 2023

[HOLD for payment 2023-06-30] [Hold 18658][$1000] When only link is added in header text, app adds extra padding above link which has cursor as pointer #17488

Closed

6 tasks

amyevans requested a review from mollfpr June 20, 2023 14:00

mollfpr reviewed Jun 21, 2023

View reviewed changes

fix warning in native devices

b243707

mollfpr approved these changes Jun 21, 2023

View reviewed changes

melvin-bot bot requested a review from amyevans June 21, 2023 18:35

cristipaval self-requested a review June 21, 2023 18:47

amyevans approved these changes Jun 21, 2023

View reviewed changes

cristipaval approved these changes Jun 21, 2023

View reviewed changes

cristipaval merged commit c008dce into Expensify:main Jun 21, 2023

OSBotify mentioned this pull request Jun 22, 2023

Deploy Checklist: New Expensify 2023-06-22 #21330

Closed

39 tasks

lanitochka17 mentioned this pull request Jun 23, 2023

Chat - Reply to a comment via email doesn’t shows up #21430

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 23, 2023

[HOLD for payment 2023-06-30] [$1000] Chat - Deleted messages with heading style not strike-through in offline #18658

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix offline deleted heading link style and link padding #20996

fix offline deleted heading link style and link padding #20996

Nikhil-Vats commented Jun 18, 2023 •

edited

Loading

melvin-bot bot commented Jun 18, 2023

Nikhil-Vats commented Jun 18, 2023

mollfpr commented Jun 20, 2023

mollfpr commented Jun 21, 2023 •

edited

Loading

mollfpr Jun 21, 2023

Nikhil-Vats Jun 21, 2023

mollfpr left a comment

Nikhil-Vats commented Jun 21, 2023 •

edited

Loading

OSBotify commented Jun 21, 2023

OSBotify commented Jun 22, 2023

luacmartins commented Jun 23, 2023

OSBotify commented Jun 23, 2023

OSBotify commented Jun 23, 2023

amyevans commented Jun 26, 2023

Nikhil-Vats commented Jun 26, 2023

fix offline deleted heading link style and link padding #20996

fix offline deleted heading link style and link padding #20996

Conversation

Nikhil-Vats commented Jun 18, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 18, 2023

Nikhil-Vats commented Jun 18, 2023

mollfpr commented Jun 20, 2023

mollfpr commented Jun 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr Jun 21, 2023

Choose a reason for hiding this comment

Nikhil-Vats Jun 21, 2023

Choose a reason for hiding this comment

mollfpr left a comment

Choose a reason for hiding this comment

Nikhil-Vats commented Jun 21, 2023 • edited Loading

OSBotify commented Jun 21, 2023

OSBotify commented Jun 22, 2023

luacmartins commented Jun 23, 2023

OSBotify commented Jun 23, 2023

OSBotify commented Jun 23, 2023

amyevans commented Jun 26, 2023

Nikhil-Vats commented Jun 26, 2023

Nikhil-Vats commented Jun 18, 2023 •

edited

Loading

mollfpr commented Jun 21, 2023 •

edited

Loading

Nikhil-Vats commented Jun 21, 2023 •

edited

Loading