Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mobile Web Scrolling in OptionsList #2101

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Fix Mobile Web Scrolling in OptionsList #2101

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ba7d50
temporary fix (should opt for something less janky)
jasperhuangg Mar 26, 2021
e8ebae6
Found better solution
jasperhuangg Mar 26, 2021
670e2a1
Revert "Found better solution"
jasperhuangg Mar 26, 2021
076c5a0
Update comment
jasperhuangg Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/OptionsList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,10 @@ class OptionsList extends Component {

render() {
return (
<View style={[styles.flex1]}>

// need to set a height (0 works in this case) so that the view will scroll on mobile
// NOTE: the view will still fill its container since it has flex: 1 on it
<View style={[styles.flex1, {height: 0}]}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up, inline styles are not permitted this should probably be moved to sizing.js.

Why does this work exactly? 🤔

{this.props.headerMessage ? (
<View style={[styles.ph5, styles.pb5]}>
<Text style={[styles.textLabel, styles.colorMuted]}>
Expand Down