-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clicking title of url preview don't open site #21717
fix: clicking title of url preview don't open site #21717
Conversation
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-06-29.at.4.29.06.PM.movMobile Web - ChromeScreen.Recording.2023-06-29.at.3.03.13.AM.movMobile Web - SafariScreen.Recording.2023-06-29.at.3.10.31.AM.movDesktopScreen.Recording.2023-06-29.at.4.29.06.PM.moviOSScreen.Recording.2023-06-29.at.3.08.35.AM.movAndroidScreen.Recording.2023-06-29.at.2.39.28.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one clarifying question!
* @param {String} color | ||
* @returns {Object} | ||
*/ | ||
function getTextColorStyle(color) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this vs just using color={colors.blueLinkPreview}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thesahindia pointed it out in the previous comment #21717 (comment)
You will need to pass the color in style prop because we don't have the color prop in
TextLink
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for clarifying!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.35-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀
|
@@ -103,13 +105,13 @@ function LinkPreviewer(props) { | |||
)} | |||
</View> | |||
{!_.isEmpty(title) && ( | |||
<Text | |||
<TextLink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We replaced the Text
component to TextLink
to make it clickable, but we didn't check the clickable area for the pv2
padding and full width area. This caused a regression here.
Details
Fixed Issues
$ #21190
PROPOSAL: #21190 (comment)
Tests
google.com
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mobile-chrome.webm
Mobile Web - Safari
mobile-safari.mp4
Desktop
desktop.mov
iOS
ios.mp4
Android
android.webm