Fix: Deleting workspace in connect bank account provides update currency error #21819

Pujan92 · 2023-06-28T16:04:21Z

Details

Used FullPageNotFoundView when the policy is not available for the workspace bank account setup flow.

Fixed Issues

$ #21604
PROPOSAL: #21604 (comment)

Tests

On device A, Goto Settings -> Workspaces -> Select any workspace -> Bank Account
From device B, delete the workspace
Verify the NotFound page will be shown for the device A

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

On device A, Goto Settings -> Workspaces -> Select any workspace -> Bank Account
From device B, delete the workspace
Verify the NotFound page will be shown for the device A

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-28.at.9.03.22.PM.mp4

Mobile Web - Chrome

q.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.-.2023-06-28.at.21.29.03.mp4

Desktop

Screen.Recording.2023-06-28.at.9.33.14.PM.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-06-28.at.21.26.15.mp4

Android

qw.webm

melvin-bot · 2023-06-28T16:04:26Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2023-06-28T16:05:22Z

@fedirjh I used FullPageNotFoundView because we need to provide custom navigation for the back button as the user should be taken to the Workspaces list page instead of that workspace settings.

fedirjh · 2023-06-29T09:16:56Z

src/pages/ReimbursementAccount/ReimbursementAccountPage.js

+                <ScreenWrapper>
+                    <FullPageNotFoundView
+                        shouldShow
+                        onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)}
+                        shouldShowLink
+                    />
+                </ScreenWrapper>


NAB: we can update the NotFoundPage component to accept onBackButtonPress prop.

won't it more become like FullPageNotFoundView with an only diff of ScreenWrapper?

fedirjh · 2023-06-29T14:22:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-29.at.2.33.42.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-06-29.at.1.48.21.PM.mov

Mobile Web - Safari

Screen.Recording.2023-06-29.at.2.27.10.PM.mov

Desktop

Screen.Recording.2023-06-29.at.2.35.59.PM.mov

iOS

Screen.Recording.2023-06-29.at.2.25.36.PM.mov

Android

Screen.Recording.2023-06-29.at.1.46.45.PM.mov

fedirjh · 2023-06-29T14:24:52Z

@Pujan92 Could you please update the QA step to be more detailed, for example:

Open account an two different devices
Delete workspace from device 2
Verify not found view is displayed on device 1

Pujan92 · 2023-06-29T14:30:23Z

@Pujan92 Could you please update the QA step to be more detailed, for example:

Open account an two different devices

Delete workspace from device 2

Verify not found view is displayed on device 1

Updated.

fedirjh

LGTM and tests well.

🎀 👀 🎀 C+ reviewed

grgia

Code looks good, thank you

OSBotify · 2023-06-29T15:51:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-29T20:37:27Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-03T14:35:18Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-07-03T15:17:53Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

situchan · 2023-08-09T14:36:18Z

src/pages/ReimbursementAccount/ReimbursementAccountPage.js

+                <ScreenWrapper>
+                    <FullPageNotFoundView
+                        shouldShow
+                        onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)}


Coming from #23167:
This caused infinite loop when this page is opened from deeplink.
Navigation.goBack(ROUTES.SETTINGS_WORKSPACES) is the correct approach.

updated workspace bank account setup notfound flow

ad15b20

Pujan92 requested a review from a team as a code owner June 28, 2023 16:04

melvin-bot bot requested review from fedirjh and removed request for a team June 28, 2023 16:04

Pujan92 mentioned this pull request Jun 28, 2023

[HOLD for payment 2023-07-10] [$1000] Deleting workspace in connect bank account provides update currency error #21604

Closed

6 tasks

ScreenWrapper added

df7d7bd

fedirjh reviewed Jun 29, 2023

View reviewed changes

fedirjh approved these changes Jun 29, 2023

View reviewed changes

melvin-bot bot requested a review from grgia June 29, 2023 15:33

grgia approved these changes Jun 29, 2023

View reviewed changes

grgia merged commit c0d4366 into Expensify:main Jun 29, 2023

OSBotify mentioned this pull request Jun 29, 2023

Deploy Checklist: New Expensify 2023-06-29 #21911

Closed

51 tasks

situchan reviewed Aug 9, 2023

View reviewed changes

situchan mentioned this pull request Aug 9, 2023

[HOLD for payment 2023-08-10] [$1000] Web - infinite loop on click of back button when go to connect bank account page of deleted policy #23167

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Deleting workspace in connect bank account provides update currency error #21819

Fix: Deleting workspace in connect bank account provides update currency error #21819

Pujan92 commented Jun 28, 2023 •

edited

Loading

melvin-bot bot commented Jun 28, 2023

Pujan92 commented Jun 28, 2023

fedirjh Jun 29, 2023

Pujan92 Jun 29, 2023

fedirjh commented Jun 29, 2023 •

edited

Loading

fedirjh commented Jun 29, 2023

Pujan92 commented Jun 29, 2023

fedirjh left a comment

grgia left a comment

OSBotify commented Jun 29, 2023

OSBotify commented Jun 29, 2023

OSBotify commented Jul 3, 2023

OSBotify commented Jul 3, 2023

situchan Aug 9, 2023

Fix: Deleting workspace in connect bank account provides update currency error #21819

Fix: Deleting workspace in connect bank account provides update currency error #21819

Conversation

Pujan92 commented Jun 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 28, 2023

Pujan92 commented Jun 28, 2023

fedirjh Jun 29, 2023

Choose a reason for hiding this comment

Pujan92 Jun 29, 2023

Choose a reason for hiding this comment

fedirjh commented Jun 29, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh commented Jun 29, 2023

Pujan92 commented Jun 29, 2023

fedirjh left a comment

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 29, 2023

OSBotify commented Jun 29, 2023

OSBotify commented Jul 3, 2023

OSBotify commented Jul 3, 2023

situchan Aug 9, 2023

Choose a reason for hiding this comment

Pujan92 commented Jun 28, 2023 •

edited

Loading

fedirjh commented Jun 29, 2023 •

edited

Loading