-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and restyle set password form #2211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
AndrewGable and
madmax330
and removed request for
a team
April 2, 2021 03:30
jasperhuangg
changed the title
[HOLD Expensify.cash 2210] Rename and restyle set password form
Rename and restyle set password form
Apr 20, 2021
@marcaaron Just marked this as ready for review, thanks! |
marcaaron
requested changes
Apr 21, 2021
marcaaron
requested changes
Apr 23, 2021
marcaaron
requested changes
Apr 26, 2021
marcaaron
approved these changes
Apr 27, 2021
66 tasks
🚀 Deployed to staging in version: 1.0.31-3🚀
|
We were able to reproduce this while executing QA for this PR #2497. Apart from this it was a pass, checking it off. |
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I wasn't able to get git to recognize that the file was renamed, so the diff will show that the
SetPasswordPage
was deleted and that theSetPasswordForm
is a new file.Details
I renamed the
SetPasswordPage
intoSetPasswordForm
(seeing that it only contains the elements relevant to the form now), and changed it to use the same layout/styles as theLoginForm
.I also changed
SignInPageLayout
to useSafeAreaView
seeing that all the forms who use it need to be wrapped bySafeAreaView
.Fixed Issues
Fixes Expensify/Expensify#157816
Tests
QA Steps
npx uri-scheme open expensify-cash://setpassword/asdf --[ios/android]
once you have the simulator runningTested On
Screenshots
Web
Mobile Web
iOS
Android