Do not show optimistic user to invite if he is already included in th… #22131

yakubbaev · 2023-07-03T19:06:41Z

Details

Enhance hasUnselectedUserToInvite with shouldIncludeUserToInvite that checks whether userToInvite is already included in the list.

Fixed Issues

$ #20930
PROPOSAL: #20930 (comment)

Tests

Precondition:
Account (user A) has been chatting with a phone number user (user B)

Open app
Go to settings
Create or open work space
Click on invite members button
Click on the search Input to bring it into focus
Enter phone number of the user B
Verify that only one option with that phone number is displayed

Offline tests

N/A

QA Steps

Same as tests section above

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

mac-web.mov

Mobile Web - Chrome

Screen.Recording.2023-07-07.at.07.52.35.mov

Mobile Web - Safari

ios-web.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

android.mov

…e options

github-actions · 2023-07-03T19:06:56Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

yakubbaev · 2023-07-03T19:08:28Z

I have read the CLA Document and I hereby sign the CLA

melvin-bot · 2023-07-03T22:02:16Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Gonals

Seems like you have some Lint errors.

You also need to check all the fields in the checklist, even if they are not relevant to this PR

mollfpr · 2023-07-05T16:28:44Z

@yakubbaev Could you check all the author checklists? The PR should test on all platforms, so please complete the recordings on all platforms too.

Also, please don't feel you need to comment on the reviewer checklist.

Another note is that you need to link the issue correctly and follow the PR template, so the bot will pull the correct reviewer, the C+ first.

Do this

$ #20930
PROPOSAL: #20930 (comment)

Don't do this

#20930
#20930 (comment)

yakubbaev · 2023-07-06T14:51:09Z

As I mentioned in the original issue, I went on vacation on Monday and came back today. I'm going to finish off all the tasks this week.

Done:

Fixed linter issues
Fixed linked issue
Delete reviewers checklist that I added

Plan:

Run on remaining platforms and attach screenshots/video
Check the remaining fields on the checklist

Thank you guys for the follow-up, this is my first PR and I'll do my best not to repeat these mistakes in the future.

yakubbaev · 2023-07-07T03:06:55Z

Done:

Run on remaining platforms and attach screenshots/video
Check the remaining fields on the checklist

mollfpr · 2023-07-08T13:07:31Z

Screen.Recording.2023-07-08.at.19.58.40.mp4

@yakubbaev The user listed after searching for the phone number must be corrected. Like in the video, it should be listed user with the display name Luthfi.

yakubbaev · 2023-07-08T13:30:14Z

Home Search	Member Invite Search

It seems to be consistent with the search on Home Screen.
Should we address this and possibly other occurrences in a separate issue? @mollfpr

mollfpr · 2023-07-08T14:09:43Z

For the search page, it's a different issue. We don't share the same functionality in the getSections of the workspace invite page. So we should fix the workspace invite page in this PR, because it's related to your changes.

yakubbaev · 2023-07-10T08:05:39Z

Got it. Thanks for elaboration @mollfpr!

Updated PR - now I'm hiding userToInvite instead of personalDetails when duplicated.

src/pages/workspace/WorkspaceInvitePage.js

mollfpr · 2023-07-11T07:14:18Z

@yakubbaev Could you resolve the conflict too? Thanks!

Conflicts: src/pages/workspace/WorkspaceInvitePage.js

yakubbaev · 2023-07-11T07:29:01Z

@mollfpr conflicts are resolved. Thanks for guiding!

mollfpr · 2023-07-11T07:50:18Z

After selecting the user with the phone number, another option added.

Screen.Recording.2023-07-11.at.14.47.55.mov

mollfpr · 2023-07-11T07:55:06Z

src/pages/workspace/WorkspaceInvitePage.js

+        const hideUserToInvite =
+            this.state.userToInvite &&
+            _.find(personalDetailsWithoutSelected, ({login}) => {
+                const phone = `${this.state.userToInvite.login}${CONST.SMS.DOMAIN}`;


Do you mean only to prevent this on phone numbers? Could we use OptionsListUtils.addSMSDomainIfPhoneNumber instead?

To fix duplicate when selecting user with phone number I switched to personalDetails instead of personalDetailsWithoutSelected.

Initially this was an issue with phone numbers only.

Reused OptionsListUtils.addSMSDomainIfPhoneNumber.

Thanks!

… duplicate userToInvite

mollfpr · 2023-07-12T08:46:47Z

The test looks good, but I doubt whether the solution is fixing the root cause.

There's a userToInvite state, which is an option for optimistically generated account.

When there's already personal detail in the account, the userToInvite should be null on updateOptionsWithSearchTerm and toggleOption method.

App/src/pages/workspace/WorkspaceInvitePage.js

Line 174 in d6b2d07

    
           const {personalDetails, userToInvite} = OptionsListUtils.getMemberInviteOptions(this.props.personalDetails, this.props.betas, searchTerm, this.getExcludedUsers());

It's already worked with searching an email that in the personalDetails, but why it's creating optimistic data on the phone number?

I believe the root cause is in the OptionsListUtils.getOptions method, which returns optimistic data on the phone number instead of null.

mollfpr · 2023-07-12T08:56:33Z

App/src/libs/OptionsListUtils.js

Line 775 in d6b2d07

    
           const noOptionsMatchExactly = !_.find(personalDetailsOptions.concat(recentReportOptions), (option) => option.login === searchValue.toLowerCase());

This is the culprit. We check the searchValue against the personal detail login without adding the domain, so it will never match the user with the phone number login.

yakubbaev · 2023-07-12T09:48:58Z

@mollfpr that's right! Reverted fixing consequences and added fix to the generation site.

mollfpr · 2023-07-12T09:55:08Z

@yakubbaev No worries! You still deserve it; We never get to fix the root cause without your RCA 😁

src/pages/workspace/WorkspaceInvitePage.js

mollfpr · 2023-07-12T13:39:35Z

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

22131.Web.mp4

Mobile Web - Chrome

22131.mWeb-Chrome.mp4

Mobile Web - Safari

22131.mWeb-Safari.mp4

Desktop

22131.Desktop.mp4

iOS

22131.iOS.mp4

Android

22131.Android.mp4

mollfpr

LGTM and tests well 👍

@yakubbaev Let's update the test case step with precondition that the account has chatting with an phone number user. Also, at the end of the step we should verify that the issue is not reproducible.

yakubbaev · 2023-07-12T17:53:03Z

@mollfpr updated tests section with a precondition and verify steps 👍

Gonals · 2023-07-13T11:10:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2023-07-13T11:17:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-14T15:02:05Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:39:50Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:41:02Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-17T22:05:42Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-19T18:02:47Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Do not show optimistic user to invite if he is already included in th…

0f0e7b7

…e options

yakubbaev marked this pull request as ready for review July 3, 2023 22:01

yakubbaev requested a review from a team as a code owner July 3, 2023 22:01

melvin-bot bot requested review from MonilBhavsar and removed request for a team July 3, 2023 22:02

MonilBhavsar requested review from Gonals and mollfpr July 4, 2023 06:07

Gonals approved these changes Jul 4, 2023

View reviewed changes

Gonals requested changes Jul 4, 2023

View reviewed changes

Run prettier

a49524b

yakubbaev requested a review from Gonals July 7, 2023 03:07

yakubbaev added 2 commits July 8, 2023 19:11

Move var closer to where it is used

b225015

Hide userToInvite instead of personalDetails when duplicate

ffc9164

mollfpr reviewed Jul 10, 2023

View reviewed changes

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

Hide userToInvite if it is already included in personalDetails

3b68263

yakubbaev requested a review from mollfpr July 11, 2023 07:12

Merge branch 'main' into 20930

36f34e7

Conflicts: src/pages/workspace/WorkspaceInvitePage.js

mollfpr reviewed Jul 11, 2023

View reviewed changes

yakubbaev added 2 commits July 11, 2023 13:37

Compare against not only selected but all personalDetails when hiding…

fc37550

… duplicate userToInvite

Reuse OptionsListUtils.addSMSDomainIfPhoneNumber

743b826

yakubbaev requested a review from mollfpr July 11, 2023 08:43

Extract userToInvitePhone const

bf18c68

yakubbaev added 2 commits July 12, 2023 14:46

Revert fixing consequences of duplicate userToInvite

0916fff

Do not generate duplicate userToInvite if it is already in userDetails

29b5ed0

mollfpr reviewed Jul 12, 2023

View reviewed changes

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

Revert moving const declaration

e8b34fa

yakubbaev requested a review from mollfpr July 12, 2023 11:22

mollfpr approved these changes Jul 12, 2023

View reviewed changes

Gonals approved these changes Jul 13, 2023

View reviewed changes

Gonals merged commit 9e5d4ee into Expensify:main Jul 13, 2023

OSBotify mentioned this pull request Jul 14, 2023

Deploy Checklist: New Expensify 2023-07-14 #22896

Closed

45 tasks

melvin-bot bot mentioned this pull request Jul 17, 2023

[HOLD for payment 2023-07-24] [$1000] IOS - Showing two different avatars for the same Phone Number #20930

Closed

6 tasks

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not show optimistic user to invite if he is already included in th… #22131

Do not show optimistic user to invite if he is already included in th… #22131

yakubbaev commented Jul 3, 2023 •

edited

Loading

github-actions bot commented Jul 3, 2023 •

edited

Loading

yakubbaev commented Jul 3, 2023

melvin-bot bot commented Jul 3, 2023

Gonals left a comment

mollfpr commented Jul 5, 2023

yakubbaev commented Jul 6, 2023 •

edited

Loading

yakubbaev commented Jul 7, 2023 •

edited

Loading

mollfpr commented Jul 8, 2023

yakubbaev commented Jul 8, 2023 •

edited

Loading

mollfpr commented Jul 8, 2023 •

edited

Loading

yakubbaev commented Jul 10, 2023

mollfpr commented Jul 11, 2023

yakubbaev commented Jul 11, 2023

mollfpr commented Jul 11, 2023

mollfpr Jul 11, 2023

yakubbaev Jul 11, 2023

mollfpr commented Jul 12, 2023

mollfpr commented Jul 12, 2023

yakubbaev commented Jul 12, 2023

mollfpr commented Jul 12, 2023

mollfpr commented Jul 12, 2023 •

edited

Loading

mollfpr left a comment

yakubbaev commented Jul 12, 2023

Gonals commented Jul 13, 2023 •

edited

Loading

OSBotify commented Jul 13, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

Do not show optimistic user to invite if he is already included in th… #22131

Do not show optimistic user to invite if he is already included in th… #22131

Conversation

yakubbaev commented Jul 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Jul 3, 2023 • edited Loading

yakubbaev commented Jul 3, 2023

melvin-bot bot commented Jul 3, 2023

Gonals left a comment

Choose a reason for hiding this comment

mollfpr commented Jul 5, 2023

yakubbaev commented Jul 6, 2023 • edited Loading

yakubbaev commented Jul 7, 2023 • edited Loading

mollfpr commented Jul 8, 2023

yakubbaev commented Jul 8, 2023 • edited Loading

mollfpr commented Jul 8, 2023 • edited Loading

yakubbaev commented Jul 10, 2023

mollfpr commented Jul 11, 2023

yakubbaev commented Jul 11, 2023

mollfpr commented Jul 11, 2023

mollfpr Jul 11, 2023

Choose a reason for hiding this comment

yakubbaev Jul 11, 2023

Choose a reason for hiding this comment

mollfpr commented Jul 12, 2023

mollfpr commented Jul 12, 2023

yakubbaev commented Jul 12, 2023

mollfpr commented Jul 12, 2023

mollfpr commented Jul 12, 2023 • edited Loading

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

yakubbaev commented Jul 12, 2023

Gonals commented Jul 13, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jul 13, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

yakubbaev commented Jul 3, 2023 •

edited

Loading

github-actions bot commented Jul 3, 2023 •

edited

Loading

yakubbaev commented Jul 6, 2023 •

edited

Loading

yakubbaev commented Jul 7, 2023 •

edited

Loading

yakubbaev commented Jul 8, 2023 •

edited

Loading

mollfpr commented Jul 8, 2023 •

edited

Loading

mollfpr commented Jul 12, 2023 •

edited

Loading

Gonals commented Jul 13, 2023 •

edited

Loading