-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added transition handling between the side drawer and chats #2221
Added transition handling between the side drawer and chats #2221
Commits on Apr 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3e91a32 - Browse repository at this point
Copy the full SHA 3e91a32View commit details -
refactor: ReportScreen added drawer state
This should be moved to HOC though
Configuration menu - View commit details
-
Copy full SHA for 455a707 - Browse repository at this point
Copy the full SHA 455a707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53b65f9 - Browse repository at this point
Copy the full SHA 53b65f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3395593 - Browse repository at this point
Copy the full SHA 3395593View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c30b06 - Browse repository at this point
Copy the full SHA 0c30b06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8252997 - Browse repository at this point
Copy the full SHA 8252997View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dd170b - Browse repository at this point
Copy the full SHA 0dd170bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a6df1b - Browse repository at this point
Copy the full SHA 8a6df1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d89162 - Browse repository at this point
Copy the full SHA 8d89162View commit details
Commits on Apr 3, 2021
-
refactor: ReportActionCompose remove drawer check
This check is no longer needed 1. It didn't work accurately 2. The compose component is unmounted when the drawer is expanded
Configuration menu - View commit details
-
Copy full SHA for 283e6c0 - Browse repository at this point
Copy the full SHA 283e6c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cf35fd - Browse repository at this point
Copy the full SHA 4cf35fdView commit details
Commits on Apr 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7fa89be - Browse repository at this point
Copy the full SHA 7fa89beView commit details -
refactor: ReportScreen use reportID from route params
`reportID` comes with a delay when the prop comes from onyx The user first selects a route in the drawer The route immediately hides the drawer and reviews the report screen `reportID` have not yet updated and the old report is visible for a moment Switching to route params changes the `reportID` the moment the user selects one of the sidebar chat links
Configuration menu - View commit details
-
Copy full SHA for 96ff600 - Browse repository at this point
Copy the full SHA 96ff600View commit details -
refactor: ReportScreen expand the drawer on back navigation
Don't trigger a navigation event as this causes a few unintended re-renders We don't need to trigger a navigation when can review the drawer from any chat screen we're currently on
Configuration menu - View commit details
-
Copy full SHA for b2177a6 - Browse repository at this point
Copy the full SHA b2177a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f4a7ea - Browse repository at this point
Copy the full SHA 2f4a7eaView commit details -
refactor: ReportView optimizations
Keep the view mounted when the report doesn't change Unmount the input when the drawer covers the view Set autoFocus only for bigger screens as example
Configuration menu - View commit details
-
Copy full SHA for 073249e - Browse repository at this point
Copy the full SHA 073249eView commit details -
refactor: ReportActionsView remove unnecessary logic around report sw…
…itching This is now handled by re-mounting Remove action sorting performed on each render - apply only when actions change
Configuration menu - View commit details
-
Copy full SHA for f3fea9b - Browse repository at this point
Copy the full SHA f3fea9bView commit details -
refactor: ReportActionsView remove
needsLayoutCalculation
This prop no longer exists The calculation seems to be handled differently and this is leftover
Configuration menu - View commit details
-
Copy full SHA for 5d2f079 - Browse repository at this point
Copy the full SHA 5d2f079View commit details -
refactor: ReportActionCompose remove
withWindowDimensions
- unusedThis is no longer needed - functionality extracted outside
Configuration menu - View commit details
-
Copy full SHA for 199fb11 - Browse repository at this point
Copy the full SHA 199fb11View commit details -
feat: ReportScreen loading view layout transitions
Nicer transition on iOS. I can't see any difference on Android
Configuration menu - View commit details
-
Copy full SHA for 7003ad8 - Browse repository at this point
Copy the full SHA 7003ad8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3396074 - Browse repository at this point
Copy the full SHA 3396074View commit details -
refactor: ReportScreen restore reportID as number
There are many prop type warnings when this is string.
Configuration menu - View commit details
-
Copy full SHA for fc371c0 - Browse repository at this point
Copy the full SHA fc371c0View commit details
Commits on Apr 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b3414b6 - Browse repository at this point
Copy the full SHA b3414b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce7b33 - Browse repository at this point
Copy the full SHA 5ce7b33View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3df62a - Browse repository at this point
Copy the full SHA a3df62aView commit details -
Revert "feat: ReportActionCompose allow autoFocus to be configurable …
…from parents" This reverts commit 2f4a7ea
Configuration menu - View commit details
-
Copy full SHA for 809d041 - Browse repository at this point
Copy the full SHA 809d041View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d50195 - Browse repository at this point
Copy the full SHA 0d50195View commit details -
Configuration menu - View commit details
-
Copy full SHA for a03f8ba - Browse repository at this point
Copy the full SHA a03f8baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8184e0f - Browse repository at this point
Copy the full SHA 8184e0fView commit details -
drop: Remove layout animations
Additional weight on th PR - These can be proposed as a follow up improvement
Configuration menu - View commit details
-
Copy full SHA for a3f92f5 - Browse repository at this point
Copy the full SHA a3f92f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a96fa8 - Browse repository at this point
Copy the full SHA 0a96fa8View commit details -
refactor: ReportActionsView remove
reset
method - no longer neededInvolved logic is already covered on mount and on unmount
Configuration menu - View commit details
-
Copy full SHA for 3b4a2c3 - Browse repository at this point
Copy the full SHA 3b4a2c3View commit details -
refactor: ReportScreen move
fetchActions
call back to ReportActions……View ReportActionsView is already handling all the required fetching so it's better to just encapsulate that logic in a single place While the Report Screen can just setup a small transition
Configuration menu - View commit details
-
Copy full SHA for f0d7bb5 - Browse repository at this point
Copy the full SHA f0d7bb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c08d14e - Browse repository at this point
Copy the full SHA c08d14eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7847ffa - Browse repository at this point
Copy the full SHA 7847ffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9ed45b - Browse repository at this point
Copy the full SHA a9ed45bView commit details
Commits on Apr 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c5dacac - Browse repository at this point
Copy the full SHA c5dacacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4646f1c - Browse repository at this point
Copy the full SHA 4646f1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74eb008 - Browse repository at this point
Copy the full SHA 74eb008View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7072ed6 - Browse repository at this point
Copy the full SHA 7072ed6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9234aa8 - Browse repository at this point
Copy the full SHA 9234aa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f762e41 - Browse repository at this point
Copy the full SHA f762e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 328f1ba - Browse repository at this point
Copy the full SHA 328f1baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e5b599 - Browse repository at this point
Copy the full SHA 3e5b599View commit details -
refactor: ReportActionCompose move logic related to disabling the inp…
…ut here This will: - remove focus / hide the keyboard when we go back to the LHN - prevent focusing on the input while it's covered by the LHN - enable the field when LHN is collapsed (or permanent)
Configuration menu - View commit details
-
Copy full SHA for a89877c - Browse repository at this point
Copy the full SHA a89877cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2944644 - Browse repository at this point
Copy the full SHA 2944644View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64c048f - Browse repository at this point
Copy the full SHA 64c048fView commit details -
Configuration menu - View commit details
-
Copy full SHA for db7b937 - Browse repository at this point
Copy the full SHA db7b937View commit details