Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added transition handling between the side drawer and chats #2221

Merged
merged 48 commits into from
Apr 8, 2021

Commits on Apr 2, 2021

  1. Configuration menu
    Copy the full SHA
    3e91a32 View commit details
    Browse the repository at this point in the history
  2. refactor: ReportScreen added drawer state

    This should be moved to HOC though
    kidroca committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    455a707 View commit details
    Browse the repository at this point in the history
  3. feat: Loading components

    kidroca committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    53b65f9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3395593 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0c30b06 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8252997 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0dd170b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8a6df1b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8d89162 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2021

  1. refactor: ReportActionCompose remove drawer check

    This check is no longer needed
    1. It didn't work accurately
    2. The compose component is unmounted when the drawer is expanded
    kidroca committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    283e6c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4cf35fd View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Configuration menu
    Copy the full SHA
    7fa89be View commit details
    Browse the repository at this point in the history
  2. refactor: ReportScreen use reportID from route params

    `reportID` comes with a delay when the prop comes from onyx
    The user first selects a route in the drawer
    The route immediately hides the drawer and reviews the report screen
    `reportID` have not yet updated and the old report is visible for a moment
    
    Switching to route params changes the `reportID` the moment the user selects
    one of the sidebar chat links
    kidroca committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    96ff600 View commit details
    Browse the repository at this point in the history
  3. refactor: ReportScreen expand the drawer on back navigation

    Don't trigger a navigation event as this causes a few unintended re-renders
    
    We don't need to trigger a navigation when can review the drawer from any
    chat screen we're currently on
    kidroca committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    b2177a6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f4a7ea View commit details
    Browse the repository at this point in the history
  5. refactor: ReportView optimizations

    Keep the view mounted when the report doesn't change
    Unmount the input when the drawer covers the view
    Set autoFocus only for bigger screens as example
    kidroca committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    073249e View commit details
    Browse the repository at this point in the history
  6. refactor: ReportActionsView remove unnecessary logic around report sw…

    …itching
    
    This is now handled by re-mounting
    Remove action sorting performed on each render - apply only when actions change
    kidroca committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    f3fea9b View commit details
    Browse the repository at this point in the history
  7. refactor: ReportActionsView remove needsLayoutCalculation

    This prop no longer exists
    The calculation seems to be handled differently and this is leftover
    kidroca committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    5d2f079 View commit details
    Browse the repository at this point in the history
  8. refactor: ReportActionCompose remove withWindowDimensions - unused

    This is no longer needed - functionality extracted outside
    kidroca committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    199fb11 View commit details
    Browse the repository at this point in the history
  9. feat: ReportScreen loading view layout transitions

    Nicer transition on iOS. I can't see any difference on Android
    kidroca committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    7003ad8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3396074 View commit details
    Browse the repository at this point in the history
  11. refactor: ReportScreen restore reportID as number

    There are many prop type warnings when this is string.
    kidroca committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    fc371c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Configuration menu
    Copy the full SHA
    b3414b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ce7b33 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a3df62a View commit details
    Browse the repository at this point in the history
  4. Revert "feat: ReportActionCompose allow autoFocus to be configurable …

    …from parents"
    
    This reverts commit 2f4a7ea
    kidroca committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    809d041 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0d50195 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a03f8ba View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8184e0f View commit details
    Browse the repository at this point in the history
  8. drop: Remove layout animations

    Additional weight on th PR - These can be proposed as a follow up improvement
    kidroca committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    a3f92f5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0a96fa8 View commit details
    Browse the repository at this point in the history
  10. refactor: ReportActionsView remove reset method - no longer needed

    Involved logic is already covered on mount and on unmount
    kidroca committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    3b4a2c3 View commit details
    Browse the repository at this point in the history
  11. refactor: ReportScreen move fetchActions call back to ReportActions…

    …View
    
    ReportActionsView is already handling all the required fetching so it's better
    to just encapsulate that logic in a single place
    
    While the Report Screen can just setup a small transition
    kidroca committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    f0d7bb5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c08d14e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7847ffa View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a9ed45b View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Configuration menu
    Copy the full SHA
    c5dacac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4646f1c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    74eb008 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7072ed6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9234aa8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f762e41 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    328f1ba View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3e5b599 View commit details
    Browse the repository at this point in the history
  9. refactor: ReportActionCompose move logic related to disabling the inp…

    …ut here
    
    This will:
    - remove focus / hide the keyboard when we go back to the LHN
    - prevent focusing on the input while it's covered by the LHN
    - enable the field when LHN is collapsed (or permanent)
    kidroca committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    a89877c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2944644 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    64c048f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    db7b937 View commit details
    Browse the repository at this point in the history