Migrate Composer `index.android.js` to function component #22542

perunt · 2023-07-10T08:28:55Z

Details

Fixed Issues

$ #16127
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

This PR updated the composer related to text input on Android. So make sense to test it fully

Test Case 1: Input Functionality

Input random characters in the text box and verify that the entered characters are correctly displayed.
Try to input various types of text, such as emojis, special characters, numbers, and a mixture of these.
Check for proper functionality in both normal and capitalized modes.

Test Case 2: Multiline Input Functionality

Try to input a multiline text in the text box.
Verify that the text formatting (like new lines, spaces, etc.) is correctly retained and displayed.
Check the scrolling functionality for multiline inputs.

Test Case 3: Focus Functionality
-Switch between the text box and the emoji picker multiple times, and verify that the focus is correctly switched each time.
-Verify that the text box regains focus when coming back from the emoji picker.

Test Case 4: Style Functionality

Try to input a text that should trigger style changes (like shrinking or expanding).
Verify that the style changes are correctly displayed.
Check if these changes are retained when switching between different interfaces (like going to the emoji picker and coming back).

Test Case 5: Message Sending Functionality

After inputting a message, hit the send button and verify that the message is sent.
Verify that the text box is cleared after the message is sent.
Check if the sent message is correctly displayed in the chat history.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

telegram-cloud-document-2-5285093468320839938.mp4

melvin-bot · 2023-07-10T10:03:09Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-07-11T16:48:12Z

src/components/Composer/index.android.js

+    const maximumNumberOfLines = useMemo(() => {
+        if (isComposerFullSize) return 1000000;
+        return maxLines;


Hard coding is off, lets leave it as undefined

Santhosh-Sellavel · 2023-07-11T16:55:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android

Screen_Recording_20230711_222114_New.Expensify.mp4

Santhosh-Sellavel · 2023-07-11T16:57:18Z

@perunt Add QA Steps Alone

Santhosh-Sellavel

Waiting for QA Steps

perunt · 2023-07-12T08:02:55Z

@Santhosh-Sellavel I've put down some QA steps. If you notice anything missing, give me a shout. This is an Android Composer update, so it's worth checking out thoroughly, I might not have covered everything.

Santhosh-Sellavel · 2023-07-12T14:37:30Z

It's much more detailed, thanks!

Santhosh-Sellavel

LGTM, thanks!

OSBotify · 2023-07-13T11:06:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Santhosh-Sellavel · 2023-07-13T18:02:54Z

@Gonals Assign me the issue to track payment, thanks!

OSBotify · 2023-07-14T15:02:17Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:40:02Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:41:14Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-17T22:05:54Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-19T18:02:59Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

perunt added 5 commits July 10, 2023 10:25

migrate

079d0f1

add current to the ref

2b43d31

eslint

32f210f

destructure

db3779c

prettier

f410877

perunt marked this pull request as ready for review July 10, 2023 10:03

perunt requested a review from a team as a code owner July 10, 2023 10:03

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team July 10, 2023 10:03

Santhosh-Sellavel reviewed Jul 11, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Jul 12, 2023

View reviewed changes

melvin-bot bot requested a review from Gonals July 12, 2023 14:37

Gonals approved these changes Jul 13, 2023

View reviewed changes

Gonals merged commit 854b8bf into Expensify:main Jul 13, 2023

OSBotify mentioned this pull request Jul 14, 2023

Deploy Checklist: New Expensify 2023-07-14 #22896

Closed

45 tasks

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

mountiny mentioned this pull request Jul 18, 2023

[HOLD for payment 2023-08-24] [$1000] IOS - Chat - Focus is lost if user inserts emoji in edit mode using emoji picker #18001

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Composer `index.android.js` to function component #22542

Migrate Composer `index.android.js` to function component #22542

perunt commented Jul 10, 2023 •

edited

Loading

melvin-bot bot commented Jul 10, 2023

Santhosh-Sellavel Jul 11, 2023

Santhosh-Sellavel Jul 11, 2023

Santhosh-Sellavel commented Jul 11, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 11, 2023

Santhosh-Sellavel left a comment

perunt commented Jul 12, 2023

Santhosh-Sellavel commented Jul 12, 2023

Santhosh-Sellavel left a comment

OSBotify commented Jul 13, 2023

Santhosh-Sellavel commented Jul 13, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

Migrate Composer index.android.js to function component #22542

Migrate Composer index.android.js to function component #22542

Conversation

perunt commented Jul 10, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 10, 2023

Santhosh-Sellavel Jul 11, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Jul 11, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel commented Jul 11, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented Jul 11, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

perunt commented Jul 12, 2023

Santhosh-Sellavel commented Jul 12, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 13, 2023

Santhosh-Sellavel commented Jul 13, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

Migrate Composer `index.android.js` to function component #22542

Migrate Composer `index.android.js` to function component #22542

perunt commented Jul 10, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 11, 2023 •

edited

Loading