Add generic payment method message #22551

jjcoffee · 2023-07-10T13:10:45Z

Details

There was previously no default case for generating the payment message when settling IOUs. Here I've added a generic case ("paid using {paymentMethod}") so that we handle any future payment methods that get added without needing to constantly add new cases. If the payment method requires a custom string (like "elsewhere" does), this can easily be added as a special case.

Fixed Issues

$ #21535
PROPOSAL: #21535 (comment)

Tests

Ideally you have access to Gold wallet to test, but if not you can add a little hack to force all payment to initially (optimistically) go through as if they're a gold wallet payment. To do this, change paymentMethodType here to CONST.IOU.PAYMENT_TYPE.EXPENSIFY. Note that if using the hack, the message in the final testing step will only display briefly before the request completes and the "real" payment method will show (e.g. paid $xx.xx elsewhere)

Request money from user B
Log in as User B and open the IOU report
On the IOU report click the button to pay
Verify that the payment message shows paid $xx.xx using Expensify

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

iou-gold-wallet-chrome-desktop-2023-07-10_12.47.47.mp4

Mobile Web - Chrome

android-chrome.mp4

Mobile Web - Safari

iou-gold-wallet-ios-safari-2023-07-10_15.00.05.mp4

Desktop

iou-gold-wallet-macos-desktop-2023-07-10_14.56.13.mp4

iOS

iou-gold-wallet-ios-native-2023-07-10_15.07.18.mp4

Android

android-native.mp4

melvin-bot · 2023-07-10T13:10:51Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ReportUtils.js

rushatgabhane · 2023-07-13T03:31:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2023-07-13.at.09.17.10.mov

Desktop

iOS

Screen.Recording.2023-07-13.at.09.22.19.mov

Android

rushatgabhane

@Julesssss LGTM

Julesssss

Changes look good. I tried testing PayPal but got blocked by a separate bug.

OSBotify · 2023-07-13T11:09:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny · 2023-07-13T15:10:56Z

src/libs/ReportUtils.js

-        case CONST.IOU.PAYMENT_TYPE.PAYPAL_ME:
-            paymentMethodMessage = ' using PayPal.me';
-            break;


@jjcoffee I think when this is used to pay reimbursement in expense report, the message will say using ACH as that is the payment type const. We dont want that

I could not see this during testing, I am not sure where exactly this flow goes through

OSBotify · 2023-07-14T15:02:08Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-07-14T16:38:19Z

@Julesssss @mountiny We dont have gold wallet in QA. can we test with Silver one or you want to run this internally?

mountiny · 2023-07-14T19:24:18Z

I think you can check this one off

OSBotify · 2023-07-17T19:39:53Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:41:05Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-17T22:05:45Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-19T18:02:50Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add generic payment method message

d79ec52

jjcoffee requested a review from a team as a code owner July 10, 2023 13:10

melvin-bot bot requested review from rushatgabhane and removed request for a team July 10, 2023 13:10

Prettier

52ee317

Julesssss assigned jjcoffee Jul 10, 2023

Julesssss reviewed Jul 10, 2023

View reviewed changes

src/libs/ReportUtils.js Show resolved Hide resolved

rushatgabhane approved these changes Jul 13, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss July 13, 2023 04:01

Julesssss approved these changes Jul 13, 2023

View reviewed changes

Julesssss merged commit 3b9c8c9 into Expensify:main Jul 13, 2023

mountiny reviewed Jul 13, 2023

View reviewed changes

OSBotify mentioned this pull request Jul 14, 2023

Deploy Checklist: New Expensify 2023-07-14 #22896

Closed

45 tasks

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

jjcoffee deleted the fix-21535 branch March 27, 2024 10:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add generic payment method message #22551

Add generic payment method message #22551

jjcoffee commented Jul 10, 2023 •

edited

Loading

melvin-bot bot commented Jul 10, 2023

rushatgabhane commented Jul 13, 2023 •

edited

Loading

rushatgabhane left a comment

Julesssss left a comment

OSBotify commented Jul 13, 2023

mountiny Jul 13, 2023

mountiny Jul 14, 2023

OSBotify commented Jul 14, 2023

mvtglobally commented Jul 14, 2023

mountiny commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

Add generic payment method message #22551

Add generic payment method message #22551

Conversation

jjcoffee commented Jul 10, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 10, 2023

rushatgabhane commented Jul 13, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 13, 2023

mountiny Jul 13, 2023

Choose a reason for hiding this comment

mountiny Jul 14, 2023

Choose a reason for hiding this comment

OSBotify commented Jul 14, 2023

mvtglobally commented Jul 14, 2023

mountiny commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

jjcoffee commented Jul 10, 2023 •

edited

Loading

rushatgabhane commented Jul 13, 2023 •

edited

Loading