[New Feature] - Teachers Unite sign-up flows #23063

dhairyasenjaliya · 2023-07-18T09:14:00Z

Details

New Feature

Fixed Issues

$ #22857
PROPOSAL: #22857 (comment)

Tests

Click on FAB
Click on Save the World
There should be 2 options (I know a teacher and I am a teacher)
Click on "I know a teacher"
Provide information for the user you're referring and confirm.
Make sure you're redirected to a public room with a whisper message indicating you referred them.
Log into as the referred teacher and make sure you can see the public room.
Click on "I am a teacher" and sign providing the principal's information.
Verify a policy expense chat has been created.
Log into the principal's account and verify a policy expense chat has been created as well.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Click on FAB
Click on Save the World
There should be 2 options (I know a teacher and I am a teacher)
Both flows should work and can able to submit a request

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Desktop.knowsTeacher.mov

Desktop.ImAteacher.mov

Mobile Web - Chrome

mWeb.ImATeacher.mov

mWeb.KnowATeacher.mov

Mobile Web - Safari

mWeb.ImATeacher.mov

mWeb.KnowATeacher.mov

Desktop

https://github.com/Expensify/App/assets/47522946/8ecf0f14-0f20-4331-9d3c-58c840126c58

Desktop.ImAteacher.mov

iOS

https://github.com/Expensify/App/assets/47522946/a6150b4c-1b42-4500-b357-3ca49823eb5b

iOS.Im.teacher.mp4

Android

android.knowATeacher.mov

android.imTeacher.mov

…into teachersUniteFlow

dhairyasenjaliya · 2023-07-24T10:46:11Z

hey @shawnborton Im adding scale animation on this new feature (PR) but will be needing the below things

Exact Lottie animation file as .json (Although I did try to convert SVG to JSON with animation but not sure which one we need to implement and I'm not able to set height/width direct to SVG as we have on other animation)
Red Color hex that is to be used as the background color of scale animation

https://user-images.githubusercontent.com/6829422/255213745-91490edc-07cc-42f5-b960-2a17a8e21348.svg

need to regenerate these assets the same as we used on the app (SVG with same height/width)

https://user-images.githubusercontent.com/6829422/255213729-effcc834-952f-4476-b187-15d31007ada5.svg

shawnborton · 2023-07-24T12:21:23Z

Here is the email address svg: empty-state__emailaddress.svg.zip

Will work on getting the animation over to you, too.

shawnborton · 2023-07-24T16:17:20Z

Lottie file is here: https://www.dropbox.com/s/hwhqhwas6c4yc1f/expensify-savetheworld-042523-kjs-1.json?dl=0

dhairyasenjaliya · 2023-07-24T16:21:19Z

alright, thnx will add both and also I do need that red color hex to be used here @shawnborton :)

shawnborton · 2023-07-24T16:24:42Z

The color is #400000; and it should be called orange.800 to match our other color naming conventions. It's the darkest shade of our brand orange.

…into teachersUniteFlow

youssef-lr · 2023-08-29T14:16:02Z

Yes please.

src/CONST.ts

youssef-lr · 2023-08-29T16:46:36Z

@dhairyasenjaliya suggested the changes

dhairyasenjaliya · 2023-08-29T16:48:29Z

Will add changes now

parasharrajat · 2023-08-29T16:53:26Z

Running checklist...

youssef-lr · 2023-08-29T17:58:29Z

@parasharrajat you might wanna use these values if you'd like to test on staging:

    PUBLIC_ROOM_ID: '795574440662771',
    POLICY_ID: 'B795B6319125BDF2',

As the new values haven't been deployed yet.

youssef-lr · 2023-08-29T18:51:19Z

@dhairyasenjaliya any update on the checklist please?

dhairyasenjaliya · 2023-08-29T18:52:59Z

yup performing soon will get it done

youssef-lr

LGTM and tested well!

youssef-lr · 2023-08-30T00:38:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2023-08-30T00:48:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-30T01:52:37Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pecanoro · 2023-08-30T14:22:26Z

I got this deploy blocker which does not feel like a deploy blocker and the expected flow. I think the QA steps could be more specific and descriptive and that's why it made our QA team to get confused. @youssef-lr @dhairyasenjaliya Can someone confirm?

dhairyasenjaliya · 2023-08-30T14:26:42Z

@pecanoro not an bug it's expected user need to have non public domain to continue safe to close that issue

OSBotify · 2023-08-31T01:02:12Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:45:37Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:52:57Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T22:49:49Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2023-09-15T04:27:03Z

src/pages/TeachersUnite/IntroSchoolPrincipalPage.js

+        (values) => {
+            const errors = {};
+
+            if (_.isEmpty(values.firstName)) {


We should use proper isLegalName validation for this otherwise random values can be used. #26275

shubham1206agra · 2023-12-18T06:28:15Z

You forgot to properly link new contact page, which led to #31895.

Added Save the world route

59af4db

dhairyasenjaliya changed the title ~~[New Feature] - Teachers Unite~~ [New Feature] - Teachers Unite sign-up flows Jul 18, 2023

dhairyasenjaliya added 18 commits July 18, 2023 15:34

Improve Save the world route & add translate

bdbba2f

Added I know a teacher route with form validation

e482d3c

Crash fix

0cba0ea

Added new route for intro principal

b077a12

Eslint fix

2eb7e7c

Added Validation

18273b7

remove unused import

65cc038

Added I am a teacher page

4910173

Remove un-used import

28039d6

Added some translation

8c44614

Add heart icon from emojiCategory

a78b3c5

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

d02e26d

…into teachersUniteFlow

minor improvement

fb4eb11

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

63788c9

…into teachersUniteFlow

change comment

830837f

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

d29b8f6

…into teachersUniteFlow

remove extra style

808e54c

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

27c6006

…into teachersUniteFlow

dhairyasenjaliya added 5 commits July 26, 2023 14:26

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

07195f7

…into teachersUniteFlow

Added Email Icon

676ba3c

Added Lottie animation for Save the world

bc0cd90

Added brand orange.800 color for saveTheWorld animation

abdb587

Lint fixes

a8f46e6

youssef-lr reviewed Aug 29, 2023

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

youssef-lr reviewed Aug 29, 2023

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

Added actual id's

3ba6d89

youssef-lr approved these changes Aug 29, 2023

View reviewed changes

youssef-lr merged commit 16c611e into Expensify:main Aug 30, 2023
14 checks passed

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

madmax330 mentioned this pull request Aug 30, 2023

[HOLD for payment 2023-09-12] [$500] FAB - Symbols are allowed in legal name #26275

Closed

6 tasks

lanitochka17 mentioned this pull request Aug 30, 2023

Save the world - Tapping "I am a teacher" user is prompted to update the email address #26291

Closed

6 tasks

youssef-lr added the InternalQA This pull request required internal QA label Aug 30, 2023

luacmartins assigned youssef-lr Aug 30, 2023

OSBotify mentioned this pull request Aug 31, 2023

Deploy Checklist: New Expensify 2023-08-31 #26359

Closed

69 tasks

parasharrajat reviewed Sep 15, 2023

View reviewed changes

shubham1206agra mentioned this pull request Dec 18, 2023

[HOLD for payment 2023-12-12] [$500] Save the World - Navigation problem on teachers contact page after a reload #31895

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New Feature] - Teachers Unite sign-up flows #23063

[New Feature] - Teachers Unite sign-up flows #23063

dhairyasenjaliya commented Jul 18, 2023 •

edited by youssef-lr

Loading

dhairyasenjaliya commented Jul 24, 2023

shawnborton commented Jul 24, 2023

shawnborton commented Jul 24, 2023

dhairyasenjaliya commented Jul 24, 2023

shawnborton commented Jul 24, 2023

youssef-lr commented Aug 29, 2023

youssef-lr commented Aug 29, 2023

dhairyasenjaliya commented Aug 29, 2023

parasharrajat commented Aug 29, 2023

youssef-lr commented Aug 29, 2023

youssef-lr commented Aug 29, 2023

dhairyasenjaliya commented Aug 29, 2023

youssef-lr left a comment

youssef-lr commented Aug 30, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 30, 2023

pecanoro commented Aug 30, 2023

dhairyasenjaliya commented Aug 30, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

parasharrajat Sep 15, 2023

shubham1206agra commented Dec 18, 2023

[New Feature] - Teachers Unite sign-up flows #23063

[New Feature] - Teachers Unite sign-up flows #23063

Conversation

dhairyasenjaliya commented Jul 18, 2023 • edited by youssef-lr Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

dhairyasenjaliya commented Jul 24, 2023

shawnborton commented Jul 24, 2023

shawnborton commented Jul 24, 2023

dhairyasenjaliya commented Jul 24, 2023

shawnborton commented Jul 24, 2023

youssef-lr commented Aug 29, 2023

youssef-lr commented Aug 29, 2023

dhairyasenjaliya commented Aug 29, 2023

parasharrajat commented Aug 29, 2023

youssef-lr commented Aug 29, 2023

youssef-lr commented Aug 29, 2023

dhairyasenjaliya commented Aug 29, 2023

youssef-lr left a comment

Choose a reason for hiding this comment

youssef-lr commented Aug 30, 2023

Reviewer Checklist

Screenshots/Videos

OSBotify commented Aug 30, 2023

OSBotify commented Aug 30, 2023

pecanoro commented Aug 30, 2023

dhairyasenjaliya commented Aug 30, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

parasharrajat Sep 15, 2023

Choose a reason for hiding this comment

shubham1206agra commented Dec 18, 2023

dhairyasenjaliya commented Jul 18, 2023 •

edited by youssef-lr

Loading