display the not found page when attachment is deleted. #23143

ahmedGaber93 · 2023-07-18T23:34:34Z

Details

Fixed Issues

$ #22261
PROPOSAL: #22261 (comment), #23143 (comment), #22261 (comment)

Tests

1- Open the app and login with user A and user B from different browsers.
2- Start chat between user A and user B.
3- From user A send an attachment in the chat.
4- From user B open the attachment in preview, and copy the URL.
5- From user A delete the attachment and Verify the user B attachment preview is dissmised.
6- Open the URL and Verify that the app displays 'Hmm its not here' page and doesn't crash.

Verify that no errors appear in the JS console

Offline tests

N/A.

QA Steps

Same as Tests step.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-05.at.10.20.34.PM.mov

Screen.Recording.2023-07-19.at.12.03.13.AM.mov

Screen.Recording.2023-07-25.at.5.16.12.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-05.at.9.53.00.PM.mov

Screen.Recording.2023-07-19.at.1.07.42.AM.mov

Screen.Recording.2023-07-25.at.5.15.01.PM.mov

Mobile Web - Safari

Screen.Recording.2023-08-05.at.9.47.52.PM.mov

Screen.Recording.2023-07-19.at.12.28.49.AM.mov

Screen.Recording.2023-07-25.at.5.10.46.PM.mov

Desktop

Screen.Recording.2023-08-05.at.2.10.35.AM.mov

Screen.Recording.2023-07-21.at.10.40.41.PM.mov

Screen.Recording.2023-07-25.at.5.05.53.PM.mov

iOS

Screen.Recording.2023-08-04.at.7.23.05.PM.mov

Screen.Recording.2023-07-21.at.10.20.33.PM.mov

Screen.Recording.2023-07-25.at.3.41.34.PM.mov

Android

Screen.Recording.2023-08-05.at.6.30.43.PM.mov

Screen.Recording.2023-07-21.at.10.35.54.PM.mov

Screen.Recording.2023-07-25.at.4.48.56.PM.mov

melvin-bot · 2023-07-18T23:34:38Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/AttachmentCarousel/index.js

src/components/AttachmentModal.js

mananjadhav · 2023-07-19T17:41:12Z

src/components/AttachmentModal.js

@@ -310,7 +325,7 @@ function AttachmentModal(props) {
                <HeaderWithBackButton
                    title={props.headerTitle || props.translate('common.attachment')}
                    shouldShowBorderBottom
-                    shouldShowDownloadButton={props.allowDownload}
+                    shouldShowDownloadButton={props.allowDownload && shouldShowDownloadButton}


I am wondering if this can be just replaced with state, and props.allowDownload can be used in the useCallback?

I think using props.allowDownload in useCallback dependencies will trigger change definition for method setDownloadButtonVisibility not shouldShowDownloadButton value.

but we can use it in useEffect.

const [shouldShowDownloadButton, setShouldShowDownloadButton] = React.useState(props.allowDownload); useEffect(() => { if (shouldShowDownloadButton === props.allowDownload) { return; } setShouldShowDownloadButton(props.allowDownload); }, [props.allowDownload]);

what do you think? @mananjadhav

I think we can ignore this change.

mananjadhav · 2023-07-19T17:41:38Z

@ahmedGaber93 I've raised comment on the method name and about the prop usage.

…nVisibility

ahmedGaber93 · 2023-07-20T11:52:05Z

@mananjadhav I've pushed a commit that change the method name, and I replied about "the prop usage" and waiting your decision.

mananjadhav · 2023-07-21T03:59:23Z

@ahmedGaber93 Two quick things:

Not all of your platforms show the Blocking View page. Can you please update those?
I was a bit stuck on my iOS testing because it crashes the app when I open this particular chat. I don't think it is related to our change, but blocks me from testing. cc - @marcochavezf.

ios-link-crash.mov

mananjadhav · 2023-07-21T05:16:18Z

@ahmedGaber93 Also for a valid attachment I can see the blocking view page on mobile web and apps.

ios-error-page.mov

ahmedGaber93 · 2023-07-21T15:45:28Z

@mananjadhav

Also for a valid attachment I can see the blocking view page on mobile web and apps.

I test it in main branch and I found deeplink attachment also not work in main branch and the app crashed, so it seems not related to this fix.

i think we may need to open new issue for it "attachment deep link not work in native"

the issue is when we try getting the current page in AttachmentCarousel we get it by matching attachment source.

App/src/components/AttachmentCarousel/index.js

Line 192 in 041d640

const page = _.findIndex(attachments, (a) => a.source === this.props.source);

the attachment source is different between native (with domain) and web (without domain), and when we use deeplink we pass web link which not work in native (see the explanation below)

the function tryResolveUrlFromApiRoot is the function that setting and return the source when message image clicked here

App/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js

Line 40 in 0a001ec

    
           const source = tryResolveUrlFromApiRoot(isAttachment ? htmlAttribs[CONST.ATTACHMENT_SOURCE_ATTRIBUTE] : htmlAttribs.src);

this is the logs for prop.source

in web (work fine)
/chat-attachments/6623927148101768966/w_8f63b3dae38c31b1f511173d3badd7d8d3dfe5ba.png

in ios native when image message click (work fine)
https://www.expensify.com/chat-attachments/6623927148101768966/w_8f63b3dae38c31b1f511173d3badd7d8d3dfe5ba.png

in ios native deeplink (not work) <<<<<<<<<<<<
/chat-attachments/6623927148101768966/w_8f63b3dae38c31b1f511173d3badd7d8d3dfe5ba.png

after following the tryResolveUrlFromApiRoot code I found the different between native (with domain) and web (without domain) is here

App/src/CONFIG.js

Line 23 in 041d640

    
           const expensifyComWithProxy = getPlatform() === 'web' && useWebProxy ? '/' : expensifyURL;

expensifyComWithProxy in web return /
expensifyComWithProxy in native return https://www.expensify.com

the fix

my proposal is to apply tryResolveUrlFromApiRoot to prop.source here to confirm the a.source and this.props.source here are with domain

App/src/components/AttachmentCarousel/index.js

Line 192 in 041d640

const page = _.findIndex(attachments, (a) => a.source === this.props.source);

a.source already have tryResolveUrlFromApiRoot here

App/src/components/AttachmentCarousel/index.js

Line 169 in 041d640

source: tryResolveUrlFromApiRoot(expensifySource || attribs.src),

we need to add it to this.props.source

// const page = _.findIndex(attachments, (a) => a.source === this.props.source);
const source = tryResolveUrlFromApiRoot(this.props.source);
const page = _.findIndex(attachments, (a) => a.source === source);

result

Screen.Recording.2023-07-21.at.5.37.59.PM.mov

mananjadhav · 2023-07-21T19:43:35Z

@marcochavezf Should we create a new issue here? or double the bounty here and resolve it here?

mananjadhav · 2023-07-21T19:46:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-deleted-attachment.mov

web-deep-link-attachment.mov

Mobile Web - Chrome

mweb-chrome-deleted-attachment.mov

mweb-chrome-deep-link-attachment.mov

Mobile Web - Safari

mweb-safari-deleted-attachment.mov

mweb-safari-deep-link-attachment.mov

Desktop

desktop-deleted-attachment.mov

desktop-deep-link-attachment.mov

iOS

ios-deleted-attachment.mov

ios-deep-link-attachment.mov

Android

android-deleted-attachment.mov

android-deep-link-attachment.mov

mananjadhav · 2023-07-21T19:47:20Z

I've completed the checklist just in case we plan to create a separate issue, but considering it's broken and we have the likely fix, I think we should just resolve in this issue.

mananjadhav · 2023-07-24T16:34:34Z

@marcochavezf Quick bump on the previous comments.

marcochavezf · 2023-07-25T01:08:21Z

@mananjadhav @ahmedGaber93 let's resolve the deep link problem in this issue please

ahmedGaber93 · 2023-07-25T12:39:27Z

@mananjadhav are you accept this fix #23143 (comment)?

mananjadhav · 2023-07-25T13:00:10Z

@ahmedGaber93 Yes about adding the tryResolveUrlFromApiRoot call right?

ahmedGaber93 · 2023-07-25T13:08:11Z

yes, right.

ahmedGaber93 · 2023-07-25T15:44:15Z

@mananjadhav I've pushed the commit and update Tests step and videos.

mananjadhav · 2023-07-25T17:49:43Z

Thanks give me a day I'll go through this and do the QA.

mananjadhav · 2023-07-26T18:45:11Z

@marcochavezf I've updated the checklist with the new screenshots in the same #23143 (comment)

🎀 👀 🎀 C+ reviewed

marcochavezf · 2023-08-15T17:36:09Z

Hi @mananjadhav, let me know when the tests are done for a final review 👍🏽

mananjadhav · 2023-08-16T04:44:33Z

I had some struggle with my Android builds, but it got working yesterday. I'll be done for sure today. @marcochavezf I see you've requested changes, is there anything pending on the changes front? I don't see any comments pending.

marcochavezf · 2023-08-16T17:30:50Z

I see you've requested changes, is there anything pending on the changes front? I don't see any comments pending.

Nope, nothing pending, all the changes I requested were already addressed

mananjadhav · 2023-08-16T20:01:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-deleted-attachment.mov

Mobile Web - Chrome

mweb-chrome-deleted-attachment.mov

Mobile Web - Safari

mweb-safari-deleted-attachment.mov

Desktop

desktop-deleted-attachment.mov

iOS

ios-deleted-attachment.mov

Android

android-deleted-attachment.mov

mananjadhav · 2023-08-16T20:41:36Z

@marcochavezf I've updated the checklist with the new screencasts. @ahmedGaber93 Can you confirm if we keep continuously opening the deep links back to back does it result into any error?

ahmedGaber93 · 2023-08-16T20:47:30Z

Can you confirm if we keep continuously opening the deep links back to back does it result into any error?

@mananjadhav sorry, I did not understand clearly what you are asking.
Can you write specific steps to follow?

mananjadhav · 2023-08-16T20:54:18Z

@ahmedGaber93 Here's the test case.

Open any chat
Basically have two URLs one deleted and one valid attachment.
Copy the URLs.
Paste the deeplink and open the deleted URL.
It shows the attachment not found modal.
While the modal is open, open the valid attachment URL.
It shows the attachment in the modal.
Repeat step 4 to 7 while the modal is always open (say 4-5 times).

Ensure it opens the valid state in the modal every time.

ahmedGaber93 · 2023-08-16T21:20:45Z

@mananjadhav
I tested it well in native and it works fine.
this case is only on native android and iOS because we can't keep the modal open in web, link always open in new tab

This just a short video as GitHub file's size limitation

Screen.Recording.2023-08-16.at.11.11.58.PM.mov

ahmedGaber93 · 2023-08-17T17:44:17Z

pump @mananjadhav @marcochavezf

mananjadhav · 2023-08-17T17:46:44Z

Okay apologies, I should've corrected myself. I am done from my end. I've also tested the back to back screens, but one of my chat results into Maximum JS depth. It does on the main as well, wanted to check if you face the same.

@marcochavezf All yours.

🎀 👀 🎀 C+ Reviewed.

marcochavezf

Thanks guys, LGTM

OSBotify · 2023-08-17T18:58:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

ayazhussain79 · 2023-08-17T20:23:25Z

@marcochavezf "Hmm... it's not here" displayed when attempting to open an image using its URL

https://expensify.slack.com/archives/C049HHMV9SM/p1692302960249539

screen-recording-2023-08-18-at-10333-am_kVGRsPUb.mp4

mananjadhav · 2023-08-17T20:47:33Z

@ayazhussain79 Could you help us with the reproduction steps? Because I can't reproduce this. I had explicitly tested this case, attaching the video here again. @ahmedGaber93 Are you able to reproduce the above bug?

web-attachment-link-click.mov

ahmedGaber93 · 2023-08-17T20:56:32Z

@mananjadhav
yes it reproduced with me after pull last version, but this issue not related to our fix.
when we work on our fix the link is open in new tab and it still work fine (you can copy the link and open it in new tab), but the issue now is the link is opened in the same tab is not complete (link without params), i now searching about the PR that make the link open in the same tab and why the link is not open completely and remove the params

// not complete link open in the same tab when click the attachment link
http://localhost:8082/r/592589459564169/attachment

// the complete link should be
http://localhost:8082/r/592589459564169/attachment?source=/chat-attachments/2323255261707990908/w_27c02e267d4a31ceb507e27614174b78309fd003.png

ayazhussain79 · 2023-08-17T20:56:56Z

@mananjadhav Idk why i can still reproduce it:
Action Performed:

Open a chat.
Attach an image file and send it.
Open the sent image in the preview.
Copy the URL of the opened image and share it in the chat.
Click on the shared URL to open the image.

ahmedGaber93 · 2023-08-17T22:03:19Z

@mananjadhav
this PR #24483 in this file AnchorRenderer since 17 Hours ago is the responsible about open attachment link in the same tab with not complete URL (URL path without params)

App/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js

Lines 54 to 57 in a6fa52d

    
           if (internalNewExpensifyPath && hasSameOrigin) { 
        
               Navigation.navigate(internalNewExpensifyPath); 
        
               return; 
        
           }

mananjadhav · 2023-08-17T22:07:37Z

Thanks for finding the PR @ahmedGaber93. Can you comment it on the PR?

ahmedGaber93 · 2023-08-17T22:08:25Z

@mananjadhav yes, I will do.

ayazhussain79 · 2023-08-18T20:45:47Z

@mananjadhav @ahmedGaber93 when clicking on deleted image url "notFound.goBackHome" is not showing in correct way it should be "Go back to Home page"

is this issue caused by this PR? its was not displaying before

ahmedGaber93 · 2023-08-18T21:09:46Z

@ayazhussain79 it is not related to this PR, but it related to #25164

ayazhussain79 · 2023-08-18T21:12:37Z

@ahmedGaber93 Ok thank you

OSBotify · 2023-08-21T22:25:34Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:08:35Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

tienifr · 2023-08-30T09:07:01Z

src/components/AttachmentModal.js

@@ -342,9 +354,10 @@ function AttachmentModal(props) {
                        <AttachmentCarousel
                            report={props.report}
                            onNavigate={onNavigate}
-                            source={props.source}
+                            source={tryResolveUrlFromApiRoot(props.source)}


@ahmedGaber93 Can you please help explain why do we need to use tryResolveUrlFromApiRoot here? Thanks

@tienifr
We decide here #23143 (comment) to used it, and here #23143 (comment) to move it in this place.

display not found page when attachment is deleted.

1feeb80

ahmedGaber93 requested a review from a team as a code owner July 18, 2023 23:34

melvin-bot bot requested review from mananjadhav and removed request for a team July 18, 2023 23:34

ahmedGaber93 mentioned this pull request Jul 18, 2023

[$2000] Chat - Deleted image URL crashes the app on mac and windows (works fine on mobile) #22261

Closed

6 tasks

prettier

c9e86db

mananjadhav reviewed Jul 19, 2023

View reviewed changes

src/components/AttachmentCarousel/index.js Outdated Show resolved Hide resolved

mananjadhav reviewed Jul 19, 2023

View reviewed changes

src/components/AttachmentModal.js Outdated Show resolved Hide resolved

mananjadhav reviewed Jul 19, 2023

View reviewed changes

change toggleDownloadButtonVisibility method name to setDownloadButto…

1974052

…nVisibility

mananjadhav approved these changes Jul 20, 2023

View reviewed changes

melvin-bot bot requested a review from marcochavezf July 20, 2023 13:35

fix attachment deep link not work in native ios and android

8cf2cdb

marcochavezf approved these changes Aug 17, 2023

View reviewed changes

marcochavezf merged commit f45ddbe into Expensify:main Aug 17, 2023
12 checks passed

ahmedGaber93 mentioned this pull request Aug 17, 2023

Fix Link Navigation relative to current Environment #24483

Merged

59 tasks

situchan mentioned this pull request Aug 18, 2023

[22523] Fix path calculation #25479

Merged

59 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

tienifr reviewed Aug 30, 2023

View reviewed changes

StevenKKC mentioned this pull request Sep 6, 2023

[$1000] Preview load every time when receive any image #24517

Closed

6 tasks

display the not found page when attachment is deleted. #23143

display the not found page when attachment is deleted. #23143

Conversation

ahmedGaber93 commented Jul 18, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 18, 2023

mananjadhav Jul 19, 2023

Choose a reason for hiding this comment

ahmedGaber93 Jul 19, 2023

Choose a reason for hiding this comment

mananjadhav Jul 20, 2023

Choose a reason for hiding this comment

mananjadhav commented Jul 19, 2023

ahmedGaber93 commented Jul 20, 2023

mananjadhav commented Jul 21, 2023

mananjadhav commented Jul 21, 2023

ahmedGaber93 commented Jul 21, 2023 • edited Loading

the fix

mananjadhav commented Jul 21, 2023

mananjadhav commented Jul 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Jul 21, 2023

mananjadhav commented Jul 24, 2023

marcochavezf commented Jul 25, 2023

ahmedGaber93 commented Jul 25, 2023

mananjadhav commented Jul 25, 2023

ahmedGaber93 commented Jul 25, 2023

ahmedGaber93 commented Jul 25, 2023

mananjadhav commented Jul 25, 2023

mananjadhav commented Jul 26, 2023

marcochavezf commented Aug 15, 2023

mananjadhav commented Aug 16, 2023

marcochavezf commented Aug 16, 2023

mananjadhav commented Aug 16, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Aug 16, 2023

ahmedGaber93 commented Aug 16, 2023

mananjadhav commented Aug 16, 2023 • edited Loading

ahmedGaber93 commented Aug 16, 2023 • edited Loading

ahmedGaber93 commented Aug 17, 2023

mananjadhav commented Aug 17, 2023

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 17, 2023

ayazhussain79 commented Aug 17, 2023

mananjadhav commented Aug 17, 2023 • edited Loading

ahmedGaber93 commented Aug 17, 2023 • edited Loading

ayazhussain79 commented Aug 17, 2023

ahmedGaber93 commented Aug 17, 2023 • edited Loading

mananjadhav commented Aug 17, 2023

ahmedGaber93 commented Aug 17, 2023

ayazhussain79 commented Aug 18, 2023 • edited Loading

ahmedGaber93 commented Aug 18, 2023

ayazhussain79 commented Aug 18, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

tienifr Aug 30, 2023

Choose a reason for hiding this comment

ahmedGaber93 Aug 30, 2023

Choose a reason for hiding this comment

ahmedGaber93 commented Jul 18, 2023 •

edited

Loading

ahmedGaber93 commented Jul 21, 2023 •

edited

Loading

mananjadhav commented Jul 21, 2023 •

edited

Loading

mananjadhav commented Aug 16, 2023 •

edited

Loading

mananjadhav commented Aug 16, 2023 •

edited

Loading

ahmedGaber93 commented Aug 16, 2023 •

edited

Loading

mananjadhav commented Aug 17, 2023 •

edited

Loading

ahmedGaber93 commented Aug 17, 2023 •

edited

Loading

ahmedGaber93 commented Aug 17, 2023 •

edited

Loading

ayazhussain79 commented Aug 18, 2023 •

edited

Loading