Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make New indicator permanent until navigating away from chat #2338

Merged
merged 9 commits into from
Apr 14, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Apr 10, 2021

Details

Updated version of @Gonals PR over here -> #1977

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/157517

Tests / QA Steps (Taken from the above PR for now)

  1. Open a chat (chat 1) in the app. Send a message there. No new marker should show up.
  2. Receive a message in the chat. No new marker should show up
  3. Move to a different chat (chat 2) and receive a message in chat 1. Move back to chat 1. You should see the new marker above the message. It should not disappear on its own:

Screen Shot 2021-03-22 at 4 30 14 PM

4. After a few seconds, go back to chat 2 and then to chat 1 again. The marker should be gone. 5. If several messages come in while you are not in the chat, the marker should be above the oldest of them:

Screen Shot 2021-03-22 at 4 36 21 PM

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

2021-04-09_15-29-55

Mobile Web

2021-04-09_15-29-04

Desktop

2021-04-09_15-34-52

iOS

2021-04-09_15-41-25

Android

2021-04-12_17-21-18

@marcaaron marcaaron self-assigned this Apr 10, 2021
@marcaaron marcaaron mentioned this pull request Apr 10, 2021
5 tasks
@marcaaron marcaaron changed the title [WIP] Make New indicator permanent until navigating away from chat Make New indicator permanent until navigating away from chat Apr 13, 2021
@marcaaron marcaaron marked this pull request as ready for review April 13, 2021 03:30
@marcaaron marcaaron requested a review from a team as a code owner April 13, 2021 03:30
@MelvinBot MelvinBot requested review from bondydaa and removed request for a team April 13, 2021 03:31
@marcaaron marcaaron requested a review from roryabraham April 13, 2021 03:31
@marcaaron
Copy link
Contributor Author

@roryabraham adding you on this one since I think you'd be interested in the fix for the bug we were discussing.

roryabraham
roryabraham previously approved these changes Apr 13, 2021
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring out the Android bug!

src/components/UnreadActionIndicator.js Outdated Show resolved Hide resolved
@roryabraham
Copy link
Contributor

All yours @bondydaa

@bondydaa bondydaa merged commit 73a8f2c into master Apr 14, 2021
@bondydaa bondydaa deleted the marcaaron-fixNewIndicator branch April 14, 2021 00:40
@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants