Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix url parsing in chat messages #2355

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Fix url parsing in chat messages #2355

merged 3 commits into from
Apr 14, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Apr 12, 2021 •
edited
Loading

Please review @Beamanator

Fix has been deployed to the expensify-common with Expensify/expensify-common#361 & I have updated the dependency here to reflect that.

Fixed Issues

Fixes #1656

Tests / ### QA Steps

  • Log in to https://expensify.cash/
  • Start chatting with another user
  • Send a message in parenthesis with a hyperlink in markdown that has a / at end of URL eg ([google](https://google.com/))

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

image

@parasharrajat parasharrajat requested a review from a team as a code owner April 12, 2021 21:14
@MelvinBot MelvinBot requested review from madmax330 and removed request for a team April 12, 2021 21:14
@Beamanator Beamanator self-requested a review April 13, 2021 12:14
@Beamanator
Copy link
Contributor

@parasharrajat can you fix the merge conflicts?

Maybe related, maybe not - I wonder if there's an issue somewhere since there are 31,846 "changes" to package-lock.json

@parasharrajat
Copy link
Member Author

Sure

@parasharrajat
Copy link
Member Author

@Beamanator Updated. Thanks.

Beamanator
Beamanator reviewed Apr 13, 2021
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@Beamanator Beamanator self-requested a review April 14, 2021 09:35
Beamanator
Beamanator approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested with the new types of links and everything looks great :D

@Beamanator Beamanator merged commit d5bf141 into Expensify:master Apr 14, 2021
@OSBotify OSBotify mentioned this pull request Apr 14, 2021
Closed
66 tasks
@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the parasharrajat/urlfix branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@madmax330 madmax330 Awaiting requested review from madmax330

Assignees

@parasharrajat parasharrajat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown link eats end parenthesis
3 participants
@parasharrajat @Beamanator @OSBotify