-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Open modal when signing out only when user is offline #23790
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-07-28.at.6.11.32.PM.movMobile Web - ChromeMobile Web - SafariDesktopScreen.Recording.2023-07-28.at.6.18.41.PM.moviOSAndroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes makes sense and I tested them on the web and desktop.
@mountiny It says the PR author checklist is not filled. (53 out of 56). |
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Looks like you have added the reviewer checklist instead of the author one, going to update it so I can merge the PR. |
Reviewer Checklist
Screenshots/VideosWebweb-signout-offfline-modal.movMobile Web - Chromemweb-chrome-signout-modal.movMobile Web - Safarimweb-safari-signout-modal.movDesktopdesktop-signout-modal.moviOSios-signout-modal.movAndroidandroid-signout-modal.mov |
Ok, everything is passing now and @mananjadhav have also reviewed this on all the platforms. |
@mountiny Ready to be CPed. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Open modal when signing out only when user is offline (cherry picked from commit b5b730d)
🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.47-3 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀
|
🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.49-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀
|
Details
Fixing a regression from #22153
Fixed Issues
$ #23742
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-07-28.at.13.23.46.mp4
Mobile Web - Chrome
Simple change
Mobile Web - Safari
23790mWebSafar.mp4
Desktop
Simple change
iOS
Simple change
Android
Simple change