Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding payments line #2407

Merged
merged 3 commits into from
Apr 19, 2021
Merged

adding payments line #2407

merged 3 commits into from
Apr 19, 2021

Conversation

laurenreidexpensify
Copy link
Contributor

Adding an extra line of detail to direct any payment queries to the contributors@ email.

@laurenreidexpensify laurenreidexpensify self-assigned this Apr 15, 2021
@laurenreidexpensify laurenreidexpensify requested a review from a team as a code owner April 15, 2021 12:41
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team April 15, 2021 12:42
CONTRIBUTING.md Outdated
@@ -19,7 +19,7 @@ If you are hired for an Upwork job and have any job-specific questions, please a
If you've found a vulnerability, please email security@expensify.com with the subject `Vulnerability Report` instead of creating an issue.

## Payment for Contributions
We hire and pay external contributors via Upwork.com. If you'd like to be paid for contributing, please create an Upwork account and apply for a job in the [Upwork issue list](https://www.upwork.com/ab/jobs/search/?q=Expensify%20React%20Native&sort=recency&user_location_match=2). Payment for your contributions will be made no less than 7 days after the pull request is merged to allow for regression testing. We hire one contributor for each Upwork job. New Expensify.cash contributors are limited to working on one job at a time, however experienced contributors may work on numerous jobs simultaneously.
We hire and pay external contributors via Upwork.com. If you'd like to be paid for contributing, please create an Upwork account and apply for a job in the [Upwork issue list](https://www.upwork.com/ab/jobs/search/?q=Expensify%20React%20Native&sort=recency&user_location_match=2). Payment for your contributions will be made no less than 7 days after the pull request is merged to allow for regression testing. We hire one contributor for each Upwork job. New Expensify.cash contributors are limited to working on one job at a time, however experienced contributors may work on numerous jobs simultaneously. If you have not received payment after 8 days, please email contributors@expensify.com referencing the GH issue and your GH handle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should clarify: after 8 days of the PR being deployed to production

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated here dfea1c6

add ioni's feedback
added "after"
@laurenreidexpensify laurenreidexpensify merged commit a2e017e into main Apr 19, 2021
@laurenreidexpensify laurenreidexpensify deleted the laurenreidexpensify-patch-1 branch April 19, 2021 07:36
@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@michaelhaxhiu

This comment has been minimized.

Copy link
Contributor

@michaelhaxhiu michaelhaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbs up from me

@michaelhaxhiu
Copy link
Contributor

Why won't this PR let me change this to a ✅ ?

image

Is it because it was merged before I actioned the PR review? I played with this for like 30 minutes yesterday, and thought that leaving a comment would do the trick but it didn't. Just wanna make sure I understand.

@iwiznia
Copy link
Contributor

iwiznia commented Apr 20, 2021

Is it because it was merged before I actioned the PR review?

Yes

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants