fix: prevent elastic scrolling when emoji picker is opened #24324

s-alves10 · 2023-08-09T15:50:22Z

Details

Prevent the elastic scrolling when EmojiPicker is opened

Fixed Issues

$ #22939
PROPOSAL: #22939 (comment)

Tests

Open ND and log in with any account
Go to any chat and tap on emoji button in the composer
Enter any key in the search field
Scroll up and down
Verify that the height of the emoji picker doesn't change when scrolling

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Go to any chat and tap on emoji button in the composer
Enter any key in the search field
Scroll up and down
Verify that the height of the emoji picker doesn't change when scrolling

QA Steps

Open ND and log in with any account
Go to any chat and tap on emoji button in the composer
Enter any key in the search field
Scroll up and down
Verify that the height of the emoji picker doesn't change when scrolling

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

22939_mac_chrome.mp4

Mobile Web - Chrome

22939_android_chrome.mp4

Mobile Web - Safari

22939_ios_safari.mp4

Desktop

22939_mac_desktop.mp4

iOS

22939_ios_native.mp4

Android

22939_android_native.mp4

melvin-bot · 2023-08-09T15:55:55Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s-alves10 · 2023-08-10T07:45:47Z

@sobitneupane

Will you take a look this PR?

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-11.at.15.00.20.mov

Mobile Web - Chrome

Screen.Recording.2023-08-11.at.14.55.27.mov

Mobile Web - Safari

Screen.Recording.2023-08-11.at.14.57.45.mov

Desktop

Screen.Recording.2023-08-10.at.22.22.31.mov

iOS

Screen.Recording.2023-08-10.at.22.31.37.mov

Android

sobitneupane

@s-alves10 Looks like there is an issue in mWeb/Chrome, after I change the skintone, the emojipicker become horizontally scrollable.

vidma_recorder_edited_10082023_225349.mp4

s-alves10 · 2023-08-10T21:37:20Z

@sobitneupane

I wasn't able to reproduce the h-scroll issue.
Can you let me know your test environment? Specifically os version

s-alves10 · 2023-08-10T22:03:25Z

@amyevans

Will you take a look at the PR?

sobitneupane · 2023-08-11T07:49:30Z

@s-alves10

Can you let me know your test environment?

Testing on Android (real device)
Specs:
-> Browser : chrome
-> Android Version: 8.1.0

s-alves10 · 2023-08-11T07:53:04Z

@sobitneupane

This issue was introduced by this PR?

sobitneupane · 2023-08-11T07:54:20Z

This issue was introduced by this PR?

I believe so. After I revert the changes introduced by this PR, the issue is no longer reproducible.

s-alves10 · 2023-08-11T08:30:55Z

@sobitneupane

Can you try to test with a updated version?

sobitneupane · 2023-08-11T08:37:59Z

@s-alves10 Were you able to reproduce the issue?

s-alves10 · 2023-08-11T08:38:51Z

@sobitneupane

I wasn't. I updated the solution to apply overflow only onto Y axis

s-alves10 · 2023-08-11T09:01:04Z

@sobitneupane

This issue is still reproducible?

sobitneupane · 2023-08-11T09:08:02Z

I wasn't.

I am quite surprised you were not able to reproduce. I can reproduce the issue on Android emulator as well (API level 29).

#24324 (review) is still reproducible?

Haven't test it yet. Going to test it now.

sobitneupane · 2023-08-11T09:12:02Z

Thanks for the update @s-alves10. The issue is no longer reproducible. Can you please update the screenshots on PR body as well? So, that we can proceed to next step.

Screen.Recording.2023-08-11.at.14.55.27.mov

s-alves10 · 2023-08-11T09:45:15Z

@sobitneupane

All videos were updated

s-alves10 · 2023-08-11T11:39:36Z

@sobitneupane

All are ok for you now?

sobitneupane · 2023-08-11T11:46:02Z

Yup. All good from my side.

cc: @amyevans

amyevans

Minor copy edit to the comment but the code looks good!

src/components/EmojiPicker/EmojiPickerMenu/index.js

OSBotify · 2023-08-11T15:37:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-14T20:04:34Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.54-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-14T21:04:50Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.54-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-17T02:55:26Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.54-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sangar-1028 added 2 commits August 9, 2023 10:39

fix: prevent elastic scrolling when emoji picker is opened

22eb27f

fix: prettier

d68ea93

s-alves10 marked this pull request as ready for review August 9, 2023 15:55

s-alves10 requested a review from a team as a code owner August 9, 2023 15:55

melvin-bot bot requested review from sobitneupane and removed request for a team August 9, 2023 15:55

s-alves10 mentioned this pull request Aug 9, 2023

[HOLD for payment 2023-08-24] [$2000] mWeb - Chat - emoji picker presents glitches while scrolling with the keyboard open #22939

Closed

6 tasks

sobitneupane approved these changes Aug 10, 2023

View reviewed changes

melvin-bot bot requested a review from amyevans August 10, 2023 16:53

sobitneupane reviewed Aug 10, 2023

View reviewed changes

fix: apply overflow only to Y axis

3b27a59

amyevans reviewed Aug 11, 2023

View reviewed changes

src/components/EmojiPicker/EmojiPickerMenu/index.js Outdated Show resolved Hide resolved

fix: comments

4048872

amyevans approved these changes Aug 11, 2023

View reviewed changes

amyevans merged commit da2fbe1 into Expensify:main Aug 11, 2023
12 checks passed

OSBotify mentioned this pull request Aug 14, 2023

Deploy Checklist: New Expensify 2023-08-14 #24550

Closed

49 tasks

s-alves10 deleted the fix/issue-22939 branch November 22, 2023 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: prevent elastic scrolling when emoji picker is opened #24324

fix: prevent elastic scrolling when emoji picker is opened #24324

s-alves10 commented Aug 9, 2023 •

edited

Loading

melvin-bot bot commented Aug 9, 2023

s-alves10 commented Aug 10, 2023

sobitneupane left a comment •

edited

Loading

sobitneupane left a comment •

edited

Loading

s-alves10 commented Aug 10, 2023

s-alves10 commented Aug 10, 2023

sobitneupane commented Aug 11, 2023 •

edited

Loading

s-alves10 commented Aug 11, 2023

sobitneupane commented Aug 11, 2023

s-alves10 commented Aug 11, 2023

sobitneupane commented Aug 11, 2023

s-alves10 commented Aug 11, 2023 •

edited

Loading

s-alves10 commented Aug 11, 2023

sobitneupane commented Aug 11, 2023

sobitneupane commented Aug 11, 2023 •

edited

Loading

s-alves10 commented Aug 11, 2023

s-alves10 commented Aug 11, 2023

sobitneupane commented Aug 11, 2023

amyevans left a comment

OSBotify commented Aug 11, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 17, 2023

fix: prevent elastic scrolling when emoji picker is opened #24324

fix: prevent elastic scrolling when emoji picker is opened #24324

Conversation

s-alves10 commented Aug 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 9, 2023

s-alves10 commented Aug 10, 2023

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

s-alves10 commented Aug 10, 2023

s-alves10 commented Aug 10, 2023

sobitneupane commented Aug 11, 2023 • edited Loading

s-alves10 commented Aug 11, 2023

sobitneupane commented Aug 11, 2023

s-alves10 commented Aug 11, 2023

sobitneupane commented Aug 11, 2023

s-alves10 commented Aug 11, 2023 • edited Loading

s-alves10 commented Aug 11, 2023

sobitneupane commented Aug 11, 2023

sobitneupane commented Aug 11, 2023 • edited Loading

s-alves10 commented Aug 11, 2023

s-alves10 commented Aug 11, 2023

sobitneupane commented Aug 11, 2023

amyevans left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 11, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 17, 2023

s-alves10 commented Aug 9, 2023 •

edited

Loading

sobitneupane left a comment •

edited

Loading

sobitneupane left a comment •

edited

Loading

sobitneupane commented Aug 11, 2023 •

edited

Loading

s-alves10 commented Aug 11, 2023 •

edited

Loading

sobitneupane commented Aug 11, 2023 •

edited

Loading