Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display status emojis in the LHN (including the user's own status) #24414
Display status emojis in the LHN (including the user's own status) #24414
Changes from 32 commits
b7b890d
8e2e717
cdeb9c2
2550706
329ef93
276bfbf
112d340
33ca589
9942d91
1095ae4
0b640c7
8eb30c0
3719c5d
d875895
049fdf1
eb0e965
62274c7
127bebb
2303985
f86e1db
acd581c
17a9c88
ca3fcc1
924bf6e
0cbe2b3
5361750
8c1546a
416ce3d
2216ec6
9126f58
5088e86
a866499
4aea8a5
77dd8b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perunt could you elaborate where does
this.props.isCreateMenuOpen
come from? Or is it alwaysundefined
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, tbh I didn't dig where it comes from but now I can see that it was undefined
I see that it was removed (
isCreateMenuOpen
) without cleaning it inside the componentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks for the input.