-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to dismiss attachment modal via swipe #2442
Conversation
@@ -402,6 +402,8 @@ PODS: | |||
- React-Core | |||
- RNCAsyncStorage (1.12.1): | |||
- React-Core | |||
- RNCClipboard (1.5.1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this wasn't updated previously, doing a pod install
added these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🚀 [Deployed](https://github.com/Expensify/Expensify.cash
|
Android/iOS - Chat - Image does not zoom in when two fingers are used Expected ResultConfirm the image zooms in Actual ResultImage does not zoom in Action Performed
PlatformiOS ✔️ Notes/Images/Videos Bug5030887_20210420_162938_1_.mp4 |
@isagoico if this is happening on production then let's create a new issue for it, feel free to tag me in it and I'll have a look |
@marcaaron will you please review this?
Details
This PR adds the ability to swipe down and right to dismiss an attachment on mobile.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/154788
Tests
QA Steps
Same as above
Tested On