fix: show existing reports while loading #25159

dummy-1111 · 2023-08-17T00:54:56Z

Details

Show existing reports in LHN while loading all reports

Fixed Issues

$ #24596
PROPOSAL: #24596 (comment)

Tests

Log in ND with an account with many conversations
Copy link to any chat
Log out
Navigate to the copied link
Log in
Return to LHN right after the chat is loaded
Verify that the opened report appears while all chats are loading

Verify that no errors appear in the JS console

Offline tests

This can't be tested in offline mode

QA Steps

Log in ND with an account with many conversations
Copy link to any chat
Log out
Navigate to the copied link
Log in
Return to LHN right after the chat is loaded
Verify that the opened report appears while all chats are loading

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

24596_mac_chrome.mp4

Mobile Web - Chrome

24596_android_chrome.mp4

Mobile Web - Safari

24596_ios_safari.mp4

Desktop

24596_mac_desktop.mp4

iOS

24596_ios_native.mp4

Android

24596_android_native.mp4

melvin-bot · 2023-08-17T01:18:55Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2023-08-24T19:23:48Z

Sorry @s-alves10 that this process has not been very smooth, I have been caught in higher priority issues without being able to give this proper time

I tested your PR for

[HOLD for payment 2023-09-07] [$1000] Chat - Opened chat does not show up in LHN when LHN is loading #24596: Opened chat not appearing in LHN when all chats have not loaded yet
Chat - Chat disappears & shows skeleton when going offline (web) or backgrounding the app (native) #24573: Skeleton view showing in LHN when going offline/online

and seems to be fixing both.

Can you update with and resolve conflicts so we can give review this and continue? 🙏

dummy-1111 · 2023-08-24T21:47:57Z

@aldo-expensify

Conflicts were removed. Please check

aldo-expensify · 2023-08-24T21:52:49Z

@s-alves10 thanks!

@narefyev91 can you review and complete checklist 🙏 ?

aldo-expensify · 2023-08-24T21:56:04Z

src/pages/home/sidebar/SidebarLinksData.js

+    const reportIDsRef = useRef(null);
+    const isLoading = SessionUtils.didUserLogInDuringSession() && isLoadingReportData;
    const optionListItems = useMemo(() => {
        const reportIDs = SidebarUtils.getOrderedReportIDs(currentReportID, chatReports, betas, policies, priorityMode, allReportActions);
        if (deepEqual(reportIDsRef.current, reportIDs)) {
            return reportIDsRef.current;
        }
-        reportIDsRef.current = reportIDs;
-        return reportIDs;
-    }, [allReportActions, betas, chatReports, currentReportID, policies, priorityMode]);
-
-    const isLoading = SessionUtils.didUserLogInDuringSession() && isLoadingReportData;
+        if (isLoading && !reportIDsRef.current && !currentReportID) {
+            reportIDsRef.current = reportIDs;
+        }
+        if (!isLoading) {
+            reportIDsRef.current = reportIDs;
+        }
+        return reportIDsRef.current || [];
+    }, [allReportActions, betas, chatReports, currentReportID, policies, priorityMode, isLoading]);


@s-alves10 can you add some comments trying to say why we using this ref and notes on each of the cases you have there?

It is just not very easy to understand why we have this complexity

Comments added

aldo-expensify · 2023-08-24T22:07:51Z

Tested: still fixing the issues after conflicts resolved

Screen.Recording.2023-08-24.at.3.05.30.PM.mov

narefyev91 · 2023-08-25T12:25:38Z

src/components/LHNOptionsList/LHNOptionsList.js

@@ -26,10 +30,11 @@ const propTypes = {
 };

 const defaultProps = {
+    style: [styles.flex1],


you can just use style: {styles.flex1}

narefyev91 · 2023-08-25T13:14:37Z

@s-alves10 can you please sync you fork and branch with latest main

narefyev91 · 2023-08-25T13:21:43Z

Interesting that on latest main and changes from you branch - i get this one web - @s-alves10 can you check that code is still working?

web.mov

dummy-1111 · 2023-08-25T13:24:50Z

Interesting that on latest main and changes from you branch - i get this one web - @s-alves10 can you check that code is still working?

What's wrong with that? I think it's working fine

narefyev91 · 2023-08-25T13:25:44Z

Interesting that on latest main and changes from you branch - i get this one web - @s-alves10 can you check that code is still working?

What's wrong with that? I think it's working fine

Hmm should it not show current opened chat at the top? during loading?

dummy-1111 · 2023-08-25T22:55:00Z

@aldo-expensify

Please let me know the expected behavior. Did I misunderstand #23735?

aldo-expensify · 2023-08-28T18:22:31Z

Please let me know the expected behavior. Did I misunderstand #23735?

I think it is just not explicitly said, but I think the expected should be the same for mobile and desktop/web. I don't see why we should have different behaviour. The expected behaviour is:

Show the loaded report + skeleton until we have loaded all reports.

dummy-1111 · 2023-08-28T23:37:41Z

Show the loaded report + skeleton until we have loaded all reports.

@narefyev91 @aldo-expensify

Please take a look

aldo-expensify · 2023-08-29T01:11:25Z

@s-alves10 you got conflicts :(

aldo-expensify · 2023-08-29T01:12:49Z

src/pages/home/sidebar/SidebarLinksData.js


-    const isLoading = SessionUtils.didUserLogInDuringSession() && isLoadingReportData;
+        // We need to update existing reports only once while loading because they are updated several times during loading and causes this reguression: https://github.com/Expensify/App/issues/24596#issuecomment-1681679531


Suggested change

// We need to update existing reports only once while loading because they are updated several times during loading and causes this reguression: https://github.com/Expensify/App/issues/24596#issuecomment-1681679531

// We need to update existing reports only once while loading because they are updated several times during loading and causes this regression: https://github.com/Expensify/App/issues/24596#issuecomment-1681679531

aldo-expensify · 2023-08-29T01:13:41Z

src/pages/iou/WaypointEditor.js

+    /** Recent waypoints array */
+    recentWaypoints: PropTypes.arrayOf(PropTypes.object),
+


Bad conflicts resolution?

It was the source of lint error. I resolved the conflicts

@aldo-expensify @narefyev91

Will you take a look again?

narefyev91 · 2023-08-29T06:43:58Z

src/pages/home/sidebar/SidebarLinksData.js

+        if ((isLoading && !reportIDsRef.current) || (_.isEmpty(reportIDsRef.current) && currentReportID)) {
+            reportIDsRef.current = reportIDs;
+        }
+        if (!isLoading) {


i think you can move this to 78 line too like if (long condition || !isLoading)

narefyev91 · 2023-08-29T11:58:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM! Now we have fully consistency between all platforms
🎀 👀 🎀 C+ reviewed

aldo-expensify · 2023-08-29T17:34:57Z

Thanks!

OSBotify · 2023-08-29T17:39:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-30T01:53:27Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:03:09Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:46:34Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:53:45Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T22:50:46Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: show existing reports while loading

4da6777

dummy-1111 marked this pull request as ready for review August 17, 2023 01:18

dummy-1111 requested a review from a team as a code owner August 17, 2023 01:18

melvin-bot bot requested review from narefyev91 and removed request for a team August 17, 2023 01:18

dummy-1111 mentioned this pull request Aug 17, 2023

[HOLD for payment 2023-09-07] [$1000] Chat - Opened chat does not show up in LHN when LHN is loading #24596

Closed

6 tasks

fix: minor refactoring

f36ca39

dummy-1111 mentioned this pull request Aug 17, 2023

Chat - Chat disappears & shows skeleton when going offline (web) or backgrounding the app (native) #24573

Closed

6 tasks

sangar-1028 added 5 commits August 23, 2023 05:10

Merge branch 'main' into fix/issue-24596

d8a65a2

fix: LHN glitch

de433a4

Merge branch 'main' into fix/issue-24596

01dda2f

fix: remove unnecessary condition'

503af34

fix: initial value to null

b35a98f

sangar-1028 added 2 commits August 24, 2023 16:28

fix: conflicts

8058d02

fix: lint error

e8322ca

aldo-expensify reviewed Aug 24, 2023

View reviewed changes

fix: add comments

7ffa793

aldo-expensify mentioned this pull request Aug 25, 2023

fix: regression 23735 #24619

Closed

59 tasks

narefyev91 reviewed Aug 25, 2023

View reviewed changes

fix: default style of LHNOptionsList

bce3738

Merge branch 'main' into fix/issue-24596

e73cc36

tienifr mentioned this pull request Aug 25, 2023

Fix: Composer does not refocus when click the same chat #24360

Merged

57 tasks

sangar-1028 added 4 commits August 28, 2023 14:18

Merge branch 'main' into fix/issue-24596

261b811

fix: same behavior on all platforms

2734584

fix: lint error

7c0f96b

fix: lint error

52070c8

aldo-expensify reviewed Aug 29, 2023

View reviewed changes

sangar-1028 added 2 commits August 28, 2023 22:20

fix: conflicts

54bfb83

fix: update comments

2d85e65

narefyev91 reviewed Aug 29, 2023

View reviewed changes

narefyev91 approved these changes Aug 29, 2023

View reviewed changes

melvin-bot bot requested a review from aldo-expensify August 29, 2023 11:59

fix: simplify conditions

243844e

aldo-expensify approved these changes Aug 29, 2023

View reviewed changes

aldo-expensify merged commit ae90744 into Expensify:main Aug 29, 2023

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

OSBotify mentioned this pull request Aug 31, 2023

Deploy Checklist: New Expensify 2023-08-31 #26359

Closed

69 tasks

dummy-1111 deleted the fix/issue-24596 branch December 21, 2023 07:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: show existing reports while loading #25159

fix: show existing reports while loading #25159

dummy-1111 commented Aug 17, 2023 •

edited

Loading

melvin-bot bot commented Aug 17, 2023

aldo-expensify commented Aug 24, 2023

dummy-1111 commented Aug 24, 2023

aldo-expensify commented Aug 24, 2023

aldo-expensify Aug 24, 2023

dummy-1111 Aug 24, 2023

aldo-expensify commented Aug 24, 2023 •

edited

Loading

narefyev91 Aug 25, 2023

dummy-1111 Aug 25, 2023

narefyev91 commented Aug 25, 2023

narefyev91 commented Aug 25, 2023

dummy-1111 commented Aug 25, 2023

narefyev91 commented Aug 25, 2023 •

edited

Loading

dummy-1111 commented Aug 25, 2023

aldo-expensify commented Aug 28, 2023

dummy-1111 commented Aug 28, 2023

aldo-expensify commented Aug 29, 2023

aldo-expensify Aug 29, 2023

dummy-1111 Aug 29, 2023

aldo-expensify Aug 29, 2023

dummy-1111 Aug 29, 2023

dummy-1111 Aug 29, 2023

narefyev91 Aug 29, 2023

narefyev91 commented Aug 29, 2023

narefyev91 left a comment

aldo-expensify commented Aug 29, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023


		const isLoading = SessionUtils.didUserLogInDuringSession() && isLoadingReportData;
		// We need to update existing reports only once while loading because they are updated several times during loading and causes this reguression: https://github.com/Expensify/App/issues/24596#issuecomment-1681679531

		/** Recent waypoints array */
		recentWaypoints: PropTypes.arrayOf(PropTypes.object),

fix: show existing reports while loading #25159

fix: show existing reports while loading #25159

Conversation

dummy-1111 commented Aug 17, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 17, 2023

aldo-expensify commented Aug 24, 2023

dummy-1111 commented Aug 24, 2023

aldo-expensify commented Aug 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aldo-expensify commented Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

narefyev91 commented Aug 25, 2023

narefyev91 commented Aug 25, 2023

dummy-1111 commented Aug 25, 2023

narefyev91 commented Aug 25, 2023 • edited Loading

dummy-1111 commented Aug 25, 2023

aldo-expensify commented Aug 28, 2023

dummy-1111 commented Aug 28, 2023

aldo-expensify commented Aug 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

narefyev91 commented Aug 29, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

aldo-expensify commented Aug 29, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

dummy-1111 commented Aug 17, 2023 •

edited

Loading

aldo-expensify commented Aug 24, 2023 •

edited

Loading

narefyev91 commented Aug 25, 2023 •

edited

Loading