Add edit request button to the report action context menu #25429

mountiny · 2023-08-17T20:00:12Z

Details

In this PR, I am adding the Edit button to the popover menu in when user hovers, right clicks or long-presses on the money request action which they can edit. It will navigate them to the transaction thread report where they can edit the values.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/270697

Tests

As user A request $10 from user B
Go to the IOU report
Right click or long press the IOU preview
Verify you can see "Edit Request" button
Click it
Verify the transaction thread has open
On web or desktop, go back to the iou report
Hover over the iou action
Verify you can see the edit request button there
Log in as user B
Go to the IOU report with User A
Hover over the report action or right click it
Verify you dont see the option to edit the request

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Same as web

iOS

Android

melvin-bot · 2023-08-17T20:07:39Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2023-08-17T20:08:20Z

@rushatgabhane I am having some issues with running the native emulators today, could you please do a review and testing of this PR especially on the native side too. Thank you 🙇

rushatgabhane · 2023-08-18T02:32:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

WhatsApp.Video.2023-08-18.at.09.03.06.mp4

Mobile Web - Safari

Desktop

Screen.Recording.2023-08-18.at.09.12.14.mov

iOS

Android

rushatgabhane

LGTM! Tested after fixing conflict with latest main

melvin-bot · 2023-08-18T03:44:14Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-08-18T03:44:18Z

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #25453.

mountiny · 2023-08-18T12:09:12Z

Thanks @grgia this should be ready!

grgia · 2023-08-21T18:41:59Z

So sorry @mountiny, mind fixing conflicts? Will prioritize this

grgia · 2023-08-22T18:11:01Z

bump on conflicts

mountiny · 2023-08-24T01:13:13Z

@rushatgabhane any chance you could retest, there was a bit more merge conflicts, test alright on my side

rushatgabhane · 2023-08-24T02:24:39Z

sure!

grgia

Changes look good and tests well!

melvin-bot · 2023-08-25T13:15:36Z

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

grgia · 2023-08-25T13:16:19Z

oops merged too quick 😅

OSBotify · 2023-08-25T13:19:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-28T18:49:41Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bondydaa · 2023-08-29T16:18:03Z

looks like this might have caused a regression that is crashing the app here #26209 can someone that blocker over or give guidance if any of the proposals can be assigned out to a contributor?

bondydaa · 2023-08-29T16:29:20Z

ah looks like vit is on his way to bali, C+ reviewed some proposals so assigned it out to a contributor to fix.

OSBotify · 2023-08-30T01:18:44Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:57:09Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:57:27Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rushatgabhane · 2023-09-05T19:47:09Z

src/libs/ReportUtils.js

+        undefined,
+        CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
+        reportAction.reportActionID,
+        reportAction.reportID,


Hi, we caused a bug when creating an optimistic thread for a transaction report.

More details here - #26028 (comment)

burczu · 2023-10-10T12:24:24Z

src/libs/ReportUtils.js

+        participantAccountIDs,
+        getTransactionReportName(reportAction),
+        '',
+        lodashGet(getReport(reportAction.reportID), 'policyID', CONST.POLICY.OWNER_EMAIL_FAKE),


Hi! This line also introduced a bug: #26748 solved by this PR: #27285

Here are more details: #26748 (comment)

mountiny added 8 commits August 17, 2023 18:55

Refactor the money request editing permissions

97b00d2

Merge branch 'main' into vit-fix270697

12073e6

Editing from the popover menu

738b328

refactor the MoneyRequestAction thread creation

668b68e

destructure props in MoneyRequestAction

a4d6645

useLocalize

1075014

Get the correct reportID

529eadc

Prettier

b6a8b11

mountiny self-assigned this Aug 17, 2023

Remove unused code

8936a08

mountiny marked this pull request as ready for review August 17, 2023 20:07

mountiny requested a review from a team as a code owner August 17, 2023 20:07

melvin-bot bot requested review from rushatgabhane and removed request for a team August 17, 2023 20:07

rushatgabhane approved these changes Aug 18, 2023

View reviewed changes

melvin-bot bot requested a review from grgia August 18, 2023 03:44

melvin-bot bot mentioned this pull request Aug 18, 2023

[payment due 8-6-2023]Payment issue for E/App PR#25429 #25453

Closed

Merge main to resolve merge conflicts

8817451

mountiny added 2 commits August 24, 2023 01:37

Merge main

0b1cb95

Resolve merge conflicts correctly

4f0fac4

mountiny added 3 commits August 25, 2023 11:30

Merge branch 'main' into vit-fix270697

d734365

Address lint

2030d6f

Prettier

6c8292c

grgia approved these changes Aug 25, 2023

View reviewed changes

grgia merged commit 4362fe7 into main Aug 25, 2023
11 checks passed

grgia deleted the vit-fix270697 branch August 25, 2023 13:15

melvin-bot bot added the Emergency label Aug 25, 2023

grgia removed the Emergency label Aug 25, 2023

alitoshmatov mentioned this pull request Aug 27, 2023

[HOLD for payment 2023-09-06] [$500] Web - IOU - Opening The cash amount page for the first time display the main chat header briefly #26028

Closed

6 tasks

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

yuwenmemon mentioned this pull request Aug 28, 2023

[HOLD for payment 2023-09-07] [HOLD for payment 2023-09-06] Web - Request money details are missing if money requested in offline mode #26115

Closed

6 tasks

lanitochka17 mentioned this pull request Aug 28, 2023

IOU - “Hmm... it’s not here...” page is open if tap on Request Money #26137

Closed

6 tasks

hungvu193 mentioned this pull request Aug 29, 2023

[HOLD for payment 2023-09-07] [HOLD for payment 2023-09-06] [$1000] Request money: App Crashes when clicking UP key from keyboard after requesting money #26209

Closed

6 tasks

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

rushatgabhane reviewed Sep 5, 2023

View reviewed changes

burczu reviewed Oct 10, 2023

View reviewed changes

burczu mentioned this pull request Oct 10, 2023

[$500] Web - Requested Money (RHN) Details Unavailable for Editing in Offline Mode #26748

Closed

6 tasks

situchan mentioned this pull request Mar 3, 2024

fix: Set childReportID of the optimistic IOU report action #37232

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add edit request button to the report action context menu #25429

Add edit request button to the report action context menu #25429

mountiny commented Aug 17, 2023

melvin-bot bot commented Aug 17, 2023

mountiny commented Aug 17, 2023

rushatgabhane commented Aug 18, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

melvin-bot bot commented Aug 18, 2023

melvin-bot bot commented Aug 18, 2023

mountiny commented Aug 18, 2023

grgia commented Aug 21, 2023

grgia commented Aug 22, 2023

mountiny commented Aug 24, 2023

rushatgabhane commented Aug 24, 2023

grgia left a comment

melvin-bot bot commented Aug 25, 2023

grgia commented Aug 25, 2023

OSBotify commented Aug 25, 2023

OSBotify commented Aug 28, 2023

bondydaa commented Aug 29, 2023

bondydaa commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

rushatgabhane Sep 5, 2023

mountiny Sep 6, 2023

burczu Oct 10, 2023

Add edit request button to the report action context menu #25429

Add edit request button to the report action context menu #25429

Conversation

mountiny commented Aug 17, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 17, 2023

mountiny commented Aug 17, 2023

rushatgabhane commented Aug 18, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

melvin-bot bot commented Aug 18, 2023

melvin-bot bot commented Aug 18, 2023

mountiny commented Aug 18, 2023

grgia commented Aug 21, 2023

grgia commented Aug 22, 2023

mountiny commented Aug 24, 2023

rushatgabhane commented Aug 24, 2023

grgia left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 25, 2023

grgia commented Aug 25, 2023

OSBotify commented Aug 25, 2023

OSBotify commented Aug 28, 2023

bondydaa commented Aug 29, 2023

bondydaa commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

rushatgabhane Sep 5, 2023

Choose a reason for hiding this comment

mountiny Sep 6, 2023

Choose a reason for hiding this comment

burczu Oct 10, 2023

Choose a reason for hiding this comment

rushatgabhane commented Aug 18, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading