Fix scroll on native when going back to the login page #25590

joh42 · 2023-08-21T14:15:33Z

Details

If the input field is focused when you go back to the login page on native, you are not scrolled to the top of the page. This differs from mweb, where you are scrolled to the top.

Fixed Issues

$ #23718
PROPOSAL: #23718 (comment)

Tests

Test for all platforms

Go to the login page
Tap on the phone/email input field
Enter your phone number or email address
Click on the button labeled Continue
Verify that the magic code input is shown as usual

Tests only for iOS and Android

With focus

Go to the login page
Tap on the phone/email input field to open the keyboard
Scroll down a bit
Exit the app (either by clicking on a link or by clicking on the home button)
Reopen the app
Verify that you are scrolled back to the top of the login page

Without focus

Go to the login page
Make sure the phone/email input field is blurred (click outside the input field, the line under it should not be green)
Scroll down a bit
Exit the app (either by clicking on a link or by clicking on the home button)
Reopen the app
Verify that you are not scrolled back to the top of the login page

Verify that no errors appear in the JS console

Offline tests

Same as regular tests

QA Steps

Same as regular tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-13.at.18.35.49.mov

Mobile Web - Chrome

Screen.Recording.2023-08-13.at.16.03.42.mov

Mobile Web - Safari

Screen.Recording.2023-08-13.at.16.00.04.mov

Desktop

Screen.Recording.2023-08-13.at.18.34.05.mov

iOS

Screen.Recording.2023-08-13.at.15.53.54.mov

Screen.Recording.2023-08-13.at.15.54.35.mov

Screen.Recording.2023-08-13.at.15.55.08.mov

Android

Screen.Recording.2023-08-13.at.17.50.02.mov

Screen.Recording.2023-08-13.at.17.51.05.mov

Screen.Recording.2023-08-13.at.17.52.23.mov

melvin-bot · 2023-08-21T14:15:40Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joh42 · 2023-08-21T14:19:15Z

The new PR with all merge conflicts resolved is ready @mollfpr

mollfpr

Thanks @joh42

Just couples of NABs. I'll complete the records for all the platforms now.

src/pages/signin/SignInPageLayout/index.js

src/pages/signin/LoginForm/index.native.js

joh42 · 2023-08-21T15:38:03Z

Updated now @mollfpr

joh42 · 2023-08-21T16:12:11Z

@venture1981 not when I test the latest main?

Screen.Recording.2023-08-21.at.18.09.54.mov

mollfpr · 2023-08-21T16:19:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

25590.Web.mov

Mobile Web - Chrome

25590.mWeb.Chrome.mp4

Mobile Web - Safari

25590.mWeb.Safari.mp4

Desktop

25590.Desktop.mov

iOS

25590.iOS.mp4

Android

25590.Android.mp4

mollfpr

LGTM and tests well 👍

@joh42 Let's make the test clearer.

We can remove Tests to make sure login is not broken: or replace it to Test for all platforms, and Tests for fixes on native: to Tests only for iOS and Android.

melvin-bot · 2023-08-24T16:23:37Z

@francoisl Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-08-24T16:30:13Z

@francoisl Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable · 2023-08-24T16:31:39Z

@joh42 - Please fix conflicts.

joh42 · 2023-08-24T16:47:57Z

Conflicts resolved, testing to make sure everything still works as intended

luacmartins

LGTM

luacmartins · 2023-08-24T16:58:23Z

src/pages/signin/LoginForm/index.native.js

+    scrollPageToTop: undefined,
+};
+
+function LoginForm(props) {


NAB

Suggested change

function LoginForm(props) {

function LoginForm({scrollPageToTop}) {

The props are sent to the BaseLoginForm here: https://github.com/joh42/expensify-app/blob/2661fb84b0e3c4921aafa9fc3fe3e794be602d88/src/pages/signin/LoginForm/index.native.js#L38

But {scrollPageToTop, ...props} could work if that's preferred

luacmartins · 2023-08-24T17:00:19Z

@joh42 let me know when you're done testing

joh42 · 2023-08-24T17:09:56Z

👍 waiting for the Android version to build...

joh42 · 2023-08-24T18:13:11Z

Everything looks good @luacmartins

melvin-bot · 2023-08-24T18:31:54Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2023-08-24T18:36:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

joh42 · 2023-08-24T19:19:18Z

Thanks for the reviews!

OSBotify · 2023-08-28T18:50:23Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:19:26Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:57:54Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:58:12Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

joh42 added 17 commits August 13, 2023 14:14

split LoginForm into base and index.js files

6720f6d

added newline at file end

f08ae20

exposed scrollPageToTop in the SignInPageLayout

4b1de5c

started passing scrollPageToTop to the LoginForm

1f7fe9a

exposed the input focus state of the BaseLoginForm with isInputFocused

5350167

added native scrolling logic for the LoginForm

ba3e8d9

added PropTypes import

9faa879

fixed issues found by linter

5734483

fixed prettier diff

3548deb

another prettier fix

770c9aa

invisible prettier fix lol

1c36f19

Merge branch 'Expensify:main' into fix/23718-2

0371d6e

set default value of scrollPageToTop to undefined

6a861a0

updated scrollPageToTop default prop to undefined

710f596

resolved merge conflicts (signed)

9d9879e

resolved more merge conflicts

c2fc0b0

Merge branch 'Expensify:main' into fix/23718-2

a83d334

joh42 requested a review from a team as a code owner August 21, 2023 14:15

melvin-bot bot removed the request for review from a team August 21, 2023 14:15

melvin-bot bot requested a review from mollfpr August 21, 2023 14:15

mollfpr suggested changes Aug 21, 2023

View reviewed changes

src/pages/signin/SignInPageLayout/index.js Outdated Show resolved Hide resolved

src/pages/signin/LoginForm/index.native.js Outdated Show resolved Hide resolved

joh42 added 2 commits August 21, 2023 17:36

removed duplicate defaultProps

0dae6bc

removed redundant comment

215d6fa

joh42 requested a review from mollfpr August 21, 2023 15:38

mollfpr approved these changes Aug 21, 2023

View reviewed changes

melvin-bot bot requested review from francoisl and removed request for a team August 24, 2023 16:23

tjferriss requested review from a team and removed request for francoisl August 24, 2023 16:30

melvin-bot bot requested review from francoisl and removed request for a team August 24, 2023 16:30

AndrewGable requested review from AndrewGable and removed request for francoisl August 24, 2023 16:31

luacmartins self-requested a review August 24, 2023 16:39

Merge branch 'main' into fix/23718-2

2661fb8

AndrewGable approved these changes Aug 24, 2023

View reviewed changes

luacmartins approved these changes Aug 24, 2023

View reviewed changes

luacmartins merged commit 9a599aa into Expensify:main Aug 24, 2023
14 checks passed

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

melvin-bot bot mentioned this pull request Aug 30, 2023

[HOLD for payment 2023-09-06] [$1000] Android - Sign In - Get started below page is cut off if switch tab than come back to app & start typing #23718

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix scroll on native when going back to the login page #25590

Fix scroll on native when going back to the login page #25590

joh42 commented Aug 21, 2023 •

edited

Loading

melvin-bot bot commented Aug 21, 2023

joh42 commented Aug 21, 2023

mollfpr left a comment

joh42 commented Aug 21, 2023

joh42 commented Aug 21, 2023

mollfpr commented Aug 21, 2023 •

edited

Loading

mollfpr left a comment

melvin-bot bot commented Aug 24, 2023

melvin-bot bot commented Aug 24, 2023

AndrewGable commented Aug 24, 2023

joh42 commented Aug 24, 2023

luacmartins left a comment

luacmartins Aug 24, 2023

joh42 Aug 24, 2023

luacmartins commented Aug 24, 2023

joh42 commented Aug 24, 2023

joh42 commented Aug 24, 2023

melvin-bot bot commented Aug 24, 2023

OSBotify commented Aug 24, 2023

joh42 commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

	function LoginForm(props) {
	function LoginForm({scrollPageToTop}) {

Fix scroll on native when going back to the login page #25590

Fix scroll on native when going back to the login page #25590

Conversation

joh42 commented Aug 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Test for all platforms

Tests only for iOS and Android

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 21, 2023

joh42 commented Aug 21, 2023

mollfpr left a comment

Choose a reason for hiding this comment

joh42 commented Aug 21, 2023

joh42 commented Aug 21, 2023

mollfpr commented Aug 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 24, 2023

melvin-bot bot commented Aug 24, 2023

AndrewGable commented Aug 24, 2023

joh42 commented Aug 24, 2023

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins Aug 24, 2023

Choose a reason for hiding this comment

joh42 Aug 24, 2023

Choose a reason for hiding this comment

luacmartins commented Aug 24, 2023

joh42 commented Aug 24, 2023

joh42 commented Aug 24, 2023

melvin-bot bot commented Aug 24, 2023

OSBotify commented Aug 24, 2023

joh42 commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

joh42 commented Aug 21, 2023 •

edited

Loading

mollfpr commented Aug 21, 2023 •

edited

Loading