Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply localization to all hard coded text #2562

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Apply localization to all hard coded text #2562

merged 3 commits into from
Apr 26, 2021

Conversation

eVoloshchak
Copy link
Contributor

Details

Applied localization to the Expensify.cash app, all hard coded text is replaced with locale-aware components/ methods.

Fixed Issues

Fixes #2408

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Leaving out the screenshots because there are no visual changes

@eVoloshchak eVoloshchak requested a review from a team as a code owner April 23, 2021 19:28
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team April 23, 2021 19:28
@eVoloshchak
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Luke9389
Copy link
Contributor

Hi @eVoloshchak. I'll be reviewing your PR. It's got a lot of changes so please be patient 😄. Also, I see that there are some merge conflicts that we'll have to take care of before merging this PR. First I'm gonna go familiarize myself with the issue, and then I'll dig into the changes. Thanks!

@eVoloshchak
Copy link
Contributor Author

Hi @eVoloshchak. I'll be reviewing your PR. It's got a lot of changes so please be patient 😄. Also, I see that there are some merge conflicts that we'll have to take care of before merging this PR. First I'm gonna go familiarize myself with the issue, and then I'll dig into the changes. Thanks!

Hi. I'm working on resolving merge conflicts. Thanks!

@Luke9389
Copy link
Contributor

Luke9389 commented Apr 23, 2021 •
edited
Loading

OK, I'm gonna go ahead and start with the review. I've pasted all the files you listed into this comment, and I'll be checking them off to be sure they're all here in the diff.

Components

  • AttachmentPicker (native)
  • TextInputFocusable
  • BaseUpdateAppModal
  • AttachmentModal
  • ConfirmModal
  • HeaderWithCloseButton
  • IOUConfirmationList
  • OptionsSelector
  • RenderHTML
  • UnreadActionIndicator
  • VideoChatButtonAndMenu
  • WelcomeText

Pages

  • home
  • EmojiPickerMenu
  • ReportActionCompose
  • ReportActionContextMenu
  • ReportActionItemFragment
  • ReportActionsView
  • ReportTypingIndicator
  • SidebarScreen
  • iou
  • IOUParticipantsRequest
  • IOUParticipantsSplit
  • IOUAmountPage
  • IOUModal
  • settings
  • LoginField
  • ProfilePage
  • AddSecondaryLoginPage
  • InitialSettingsPage
  • PasswordPage
  • PaymentsPage
  • PreferencesPage
  • signin
  • LoginFormNarrow
  • LoginFormWide
  • SignInPageLayoutNarrow
  • SignInPageLayoutWide
  • TermsOnly
  • TermsWithLicenses
  • ChangeExpensifyLoginLink
  • PasswordForm
  • ResendValidationForm

Other

  • DetailsPage
  • NewChatPage
  • NewGroupPage
  • NotFound
  • ReportParticipantsPage
  • SearchPage
  • SetPasswordPage

Luke9389
Luke9389 suggested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks

src/components/ConfirmModal.js Outdated Show resolved Hide resolved
src/components/UpdateAppModal/UpdateAppModalPropTypes.js Show resolved Hide resolved
src/languages/en.js Outdated Show resolved Hide resolved
src/components/OptionsSelector.js Outdated Show resolved Hide resolved
src/pages/settings/InitialPage.js Outdated Show resolved Hide resolved
src/pages/settings/PreferencesPage.js Outdated Show resolved Hide resolved
src/pages/signin/TermsAndLicenses/TermsOnly.js Outdated Show resolved Hide resolved
@eVoloshchak
Copy link
Contributor Author

Updated

Luke9389
Luke9389 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for these changes 👍

@Luke9389 Luke9389 merged commit cb3eb87 into Expensify:main Apr 26, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

iwiznia
iwiznia reviewed Apr 26, 2021
View reviewed changes
Copy link
Contributor

@iwiznia iwiznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, wanted to review this before merging... Seems there are a few things conceptually wrong, so I am going to revert this.
Another thought I had is that maybe we should make all these methods of the withLocalize HOC props themselves, so instead of having to do props.translations.translate we could do props.translate directly.

src/ONYXKEYS.js Show resolved Hide resolved
src/components/AttachmentPicker/index.native.js Show resolved Hide resolved
src/components/RenderHTML.js Show resolved Hide resolved
src/components/TextInputFocusable/index.js Show resolved Hide resolved
src/components/UpdateAppModal/UpdateAppModalPropTypes.js Show resolved Hide resolved
src/components/WelcomeText.js Show resolved Hide resolved
src/languages/en.js Show resolved Hide resolved
src/libs/OptionsListUtils.js Show resolved Hide resolved
src/pages/home/report/ReportActionContextMenu.js Show resolved Hide resolved
src/pages/settings/PreferencesPage.js Show resolved Hide resolved
@iwiznia iwiznia mentioned this pull request Apr 26, 2021
Merged
@iwiznia iwiznia added DeployBlockerCash This issue or pull request should block deployment and removed DeployBlockerCash This issue or pull request should block deployment labels Apr 26, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.31-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@eVoloshchak eVoloshchak mentioned this pull request Apr 29, 2021
Closed
5 tasks
@eVoloshchak eVoloshchak mentioned this pull request May 7, 2021
Merged
5 tasks
@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwiznia iwiznia iwiznia left review comments

@Luke9389 Luke9389 Luke9389 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply localization to all hard coded text in the Expensify.cash app
4 participants
@eVoloshchak @Luke9389 @OSBotify @iwiznia