Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention list doesnt automatically popup when typing @ #25660

Merged
merged 6 commits into from
Aug 24, 2023
Merged

Mention list doesnt automatically popup when typing @ #25660

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b93d8e9
fix: sellection end check
WikusKriek Aug 22, 2023
434923a
fix: remove sellection dependency
WikusKriek Aug 22, 2023
c680833
fix: iOS suggestion not showing
WikusKriek Aug 23, 2023
b569af6
chore: remove comment
WikusKriek Aug 23, 2023
13fac95
Merge branch 'main' into 25649-Mention-list-doesnt-automatically-popu…
WikusKriek Aug 23, 2023
d4e4d85
fix: insert caallback
WikusKriek Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions src/pages/home/report/ReportActionCompose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ function ReportActionCompose({

const calculateMentionSuggestion = useCallback(
(selectionEnd) => {
if (shouldBlockMentionCalc.current || selection.end < 1) {
if (shouldBlockMentionCalc.current || selectionEnd < 1) {
shouldBlockMentionCalc.current = false;
resetSuggestions();
return;
Expand Down Expand Up @@ -631,24 +631,13 @@ function ReportActionCompose({
}));
setHighlightedMentionIndex(0);
},
[getMentionOptions, setHighlightedMentionIndex, value, selection, resetSuggestions],
[getMentionOptions, setHighlightedMentionIndex, value, resetSuggestions],
);

const onSelectionChange = useCallback(
(e) => {
LayoutAnimation.configureNext(LayoutAnimation.create(50, LayoutAnimation.Types.easeInEaseOut, LayoutAnimation.Properties.opacity));
setSelection(e.nativeEvent.selection);

/**
* we pass here e.nativeEvent.selection.end directly to calculateEmojiSuggestion
* because in other case calculateEmojiSuggestion will have an old calculation value
* of suggestion instead of current one
*/
calculateEmojiSuggestion(e.nativeEvent.selection.end);
calculateMentionSuggestion(e.nativeEvent.selection.end);
},
[calculateEmojiSuggestion, calculateMentionSuggestion],
);
const onSelectionChange = (e) => {
LayoutAnimation.configureNext(LayoutAnimation.create(50, LayoutAnimation.Types.easeInEaseOut, LayoutAnimation.Properties.opacity));
setSelection(e.nativeEvent.selection);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useCallback can still be used with empty dependency array

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump for this minor change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @situchan.


const setUpComposeFocusManager = useCallback(() => {
// This callback is used in the contextMenuActions to manage giving focus back to the compose input.
Expand Down Expand Up @@ -979,6 +968,11 @@ function ReportActionCompose({
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

useEffect(() => {
calculateEmojiSuggestion(selection.end);
calculateMentionSuggestion(selection.end);
}, [calculateEmojiSuggestion, calculateMentionSuggestion, selection.end]);

const prevIsModalVisible = usePrevious(modal.isVisible);
const prevIsFocused = usePrevious(isFocusedProp);
useEffect(() => {
Expand Down
Loading