Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify
MoneyRequestConfirmPage
for Distance Request #25707Modify
MoneyRequestConfirmPage
for Distance Request #25707Changes from all commits
95f4998
9bbd398
72015a7
733a01c
f54184b
af2d584
4ee061d
e9d3949
ff4c5e1
4fe5ff3
34086ed
9d2bcb5
e2d3d94
eef6380
ae13f9d
5b8cd86
20b742c
5eb207b
c4d139b
2abd45c
837a04f
3048b71
892d4c2
73e19ee
4d72e7e
327c545
972c2d0
58199fa
9b1c8ec
57d6942
3f31e60
fdb997c
ed4046e
f2fcbce
891c5e8
55e0ba9
40dea40
c0167aa
656bec9
66e4d1c
8199f92
0cd7020
6fdaef8
540b3cd
53be182
d65ae30
7410a90
f6d9144
6665d0c
64ccf7d
61c34bd
049d760
07b7045
ffb2597
103a7d6
8eb66bd
26289e5
034131b
3ab8897
531461b
e93e94a
031c040
35d0404
40e254e
605d1ad
6000908
2a1c6f8
151c98e
d4d70d2
d7ab640
4aacd97
ab9de25
4533e8b
bdc404d
f9dee21
8e64620
febe630
2a9c100
557d58a
82c9f70
da8c84e
9a90258
b1b5aea
ea1828f
a4ef2ce
edf051c
01877bf
c50ad59
fe1c429
471b017
8f28603
c3d1be3
a2d946d
b5689b6
470c54a
a8a102e
46437d7
de56adf
2ad0edb
13adca8
872462c
9117371
60580db
556b36c
df9e8c8
4857735
3aa090c
82fa54e
12f358f
04db489
ddefdeb
1328bc4
c4ad234
fddfb85
6d687ff
b18b6d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
MAP_PADDING
value caused the following issue:Because the value was too high, on certain narrow layout devices (mobile) the value caused the app to crash when submitting a distance request. The issue was fixed by decreasing the value to
32
and removing / unifying theMAP_PADDING
into usingMAPBOX.PADDING
variable instead. More details can be found in the issue / proposal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could pass
initialState
prop with start waypoint to avoid locating wrong location on first render.Issue: #26726